file uploads

[skdzines]

I am working on a script to upload an image to the server and insert data to the database. I have 2 parts to this script. The user is not required to upload an image but if they do, I want the script to make sure it is uploaded properly before inserting the data to the database, otherwise if there is no image being uploaded, then just add the data to the database. Below is my code:

if(empty($error)){
		if($_POST['pic']){
		$uploaddir = '../'.$cat.'Listings/images/';
		$uploadfile = $uploaddir . basename($_FILES['pic']['name']);
		$pic = basename($_FILES['pic']['name']);
			if (move_uploaded_file($_FILES['pic']['tmp_name'], $uploadfile)) {
				$sql = "INSERT INTO ".$cat." (`style`, `salePrice`, `leaseRate`, `approxSize`, `sqftForLease`, `landSize`, `municipality`, `zoning`, `notes`, `address`, `city`, `state`, `disclaimer`, `pic`) 
				VALUES ('$style', '$salePrice', '$leaseRate', '$sqFt', '$sqFtForLease', '$landSize', '$municipality', '$zoning', '$notes', '$address', '$city', '$state', '$disclaimer', '$pic');" or die ('Could not insert into database because: ' . mysql_error());
				$insert = mysql_query($sql);
				reviseDate();
				$address = "";
				$city = "";
				$state = "";
				$disclaimer = "";
				$pic = "";
				$style = "";
				$salePrice = "";
				$leaseRate = "";
				$sqFt = "";
				$sqFtForLease = "";
				$landSize = "";
				$municipality = "";
				$zoning = "";
				$notes = "";
				$success = true;
			}
		}elseif(!$_POST['pic']){
			$sql = "INSERT INTO ".$cat." (`style`, `salePrice`, `leaseRate`, `approxSize`, `sqftForLease`, `landSize`, `municipality`, `zoning`, `notes`, `address`, `city`, `state`, `disclaimer`, `pic`) 
			VALUES ('$style', '$salePrice', '$leaseRate', '$sqFt', '$sqFtForLease', '$landSize', '$municipality', '$zoning', '$notes', '$address', '$city', '$state', '$disclaimer', '$pic');" or die ('Could not insert into database because: ' . mysql_error());
				$insert = mysql_query($sql);
				reviseDate();
				$address = "";
				$city = "";
				$state = "";
				$disclaimer = "";
				$pic = "";
				$style = "";
				$salePrice = "";
				$leaseRate = "";
				$sqFt = "";
				$sqFtForLease = "";
				$landSize = "";
				$municipality = "";
				$zoning = "";
				$notes = "";
				$success = true;
		}else{
			$error .= "There was a problem uploading the image and therefore no listing was added. Please try again";
		}
	}

For some reason $_POST['pic'] keeps coming back as an empty string and so no image is ever uploaded it always goes to my elseif(). How do I get it to check to see if the 'pic' file field contains an image to be uploaded? I have also tried using this if($FILES['pic']) to validate it and that doesn't work either.

I am new to uploading files so bear with me. I would also like to know how to validate if the file is a jpg or gif image only. Antything else I want to throw an error.

Any help is appreciated.

Thanks

[devinemke]

what does the form look like?

[skdzines]

This is my form:

<form action='$PHP_SELF' method='post' name='addListing' enctype='multipart/form-data'>
<input type='hidden' name='MAX_FILE_SIZE' value='200000' />
<br/>
<table width='100%'  border='0' cellspacing='0' cellpadding='3'>
  <tr>
    <td width='17%' align='right'>Address:</td>
    <td width='28%'><input type='text' name='address' id='textBoxStyle' value='$address'></td>
    <td width='18%' align='right'>Sale Price: $</td>
    <td width='37%'><input type='text' name='salePrice' id='textBoxStyle' value='$salePrice'></td>
  </tr>
  <tr>
    <td align='right'>City:</td>
    <td><input type='text' name='city' id='textBoxStyle' value='$city'></td>
    <td align='right'>Lease Rate: $</td>
    <td><input type='text' name='leaseRate' id='textBoxStyle' value='$leaseRate'></td>
  </tr>
  <tr>
    <td align='right'>State:</td>
    <td><input type='text' name='state' id='textBoxStyle' value='$state'></td>
    <td align='right'>Sq. Ft:</td>
    <td><input type='text' name='sqFt' id='textBoxStyle' value='$sqFt'></td>
  </tr>
  <tr>
    <td align='right'>&nbsp;</td>
    <td>&nbsp;</td>
    <td align='right'>Sq. Ft. for Lease: </td>
    <td><input type='text' name='sqFtForLease' id='textBoxStyle' value='$sqFtForLease'></td>
  </tr>
  <tr>
    <td align='right'>&nbsp;</td>
    <td>&nbsp;</td>
    <td align='right'>Land Size: </td>
    <td><input type='text' name='landSize' id='textBoxStyle' value='$landSize'></td>
  </tr>
  <tr>
    <td align='right'>Municipality:</td>
    <td><input type='text' name='municipality' id='textBoxStyle' value='$municipality'></td>
    <td align='right'>Style:</td>
    <td><input type='text' name='style' id='textBoxStyle' value='$style'></td>
  </tr>
  <tr>
    <td align='right'>Zoning:</td>
    <td><input type='text' name='zoning' id='textBoxStyle' value='$zoning'></td>
    <td align='right'>&nbsp;</td>
    <td>&nbsp;</td>
  </tr>
  <tr>
    <td align='right' valign='top'>Notes:</td>
    <td><textarea name='notes' cols='40' rows='5' id='textBoxStyle'>$notes</textarea></td>
    <td align='right' valign='top'>Disclaimer:</td>
    <td><textarea name='disclaimer' cols='40' rows='5' id='textBoxStyle'>$disclaimer</textarea></td>
  </tr>
  <tr>
    <td align='right'>&nbsp;</td>
    <td>&nbsp;</td>
    <td align='right'>&nbsp;</td>
    <td>&nbsp;</td>
  </tr>
  <tr>
    <td align='right'>Upload Picture:</td>
    <td><input type='file' name='pic' id='textBoxStyle' value='$pic'></td>
    <td align='right'>&nbsp;</td>
    <td>&nbsp;</td>
  </tr>
  <tr>
    <td>&nbsp;</td>
    <td>&nbsp;</td>
	<td>&nbsp;</td>
    <td><input type='submit' name='addListing' value='Submit' class='submitStyle'/>
	<input type='hidden' name='form' value='addListing'></td>
  </tr>
</table>
</form>

If I don't try to validate that there is something in the 'pic' form field and just attempt to upload something whether it is there or not, it works. Meaning, if there is no image to upload, I get the error message telling me there was a problem and if I have added an image to upload it uploads it fine. It's only when I'm checking to see if $_POST['pic'] is empty or not. Apparently it always comes back as being empty.

Thanks for your help.

[devinemke]

$POST['pic'] will never be set. the "pic" form field will not be present in the $POST array. it will only be present in the $FILES array. do the following in your form processing code...

print_r($_POST);
print_r($_FILES);

...and you will have a better idea of how PHP passes the form variables.

[skdzines]

okay, I am now checking to see if the $_FILES['pic']['name'] is empty or not by doing this which is working for me:

if (!$_FILES['pic']['name']){
   $error .= "No image selected";
}else{
   $error .= $_FILES['pic']['name'];
}

I am only doing this to see if it is recognizing that there is an image to be uploade or not which it is doing just fine. If I have an image to upload it prints out the name of the image to be uploaded. However when I do the same thing for my insert statement like this is doesn't work.

if ($_FILES['pic']['name']){ 
        $uploaddir = '../'.$cat.'Listings/images/'; 
        $uploadfile = $uploaddir . basename($_FILES['pic']['name']); 
        $pic = basename($_FILES['pic']['name']); 
            if (move_uploaded_file($_FILES['pic']['tmp_name'], $uploadfile)) { 
                $sql = "INSERT INTO ".$cat." (`style`, `salePrice`, .......
............etc..
}elseif (!$_FILES['pic']['name']) {
   $sql = "INSERT INTO ".$cat." (`style`, `salePrice`, `leaseRate`, `approxSize`, `sqftForLease`, `landSize`, `municipality`, `zoning`, `notes`, `address`, `city`, `state`, `disclaimer`, `pic`) 
            VALUES ('$style', '$salePrice', .................etc...........
..........................
}

Why is this?

Thanks for your help.

[devinemke]

if you looked at the output from print_r($_FILES) you will see that one of the array indexes is "error". that is really what you should be using for your validation.