Logic failing, Simple if else

[Enlightened]

Im trying to make this snippet of form validation allow the form to be optional.
Instead its failing as a requirement, Im sure it has something to do with the strlen function but i dont know how to change it. If spousename has a value and its length is less then 2, or is greater then 20 fail. Please help 🙂

if(isset($_POST['spousename']) === true && strlen($_POST['spousename']) < 2 || strlen($_POST['spousename']) > 20)
	{
		$errors[] = "Your spouse's first name is required.<br />";
		}else{
		$sn = trim($_POST['spousename']);
	}

[Vbabiy]

try that it should work:

if(isset($_POST['spousename']) && strlen($_POST['spousename']) < 2 || strlen($_POST['spousename']) > 20) 
    { 
        $errors[] = "Your spouse's first name is required.<br />"; 
        }else{ 
        $sn = trim($_POST['spousename']); 
    }  

[Enlightened]

Thanks for your reply, It did the same thing. I believe its not checking strlen if the first one is true

It just checks to see if its less then 2. If i type in 2-3 char's there is no error
I might try a different conditional type or something

[Vbabiy]

 if(strlen($_POST['spousename']) < 2 AND strlen($_POST['spousename']) > 20)  

    {  

        $errors[] = "Your spouse's first name is required.<br />";  

        }else{  

        $sn = trim($_POST['spousename']);  

    }  

That should work... Since it hast to larger then 2 and smaller then 20 if its not enter it will return a error

[Enlightened]

Yeah but that would make it a mandatory to have a value, It needs to be optional, ( If it has a value, check to make sure its > 2, and < 20

[gufmn]

if(isset(..........){
if(strlen(..........){
}
}

[Enlightened]

Cool ill do that, Any idea why this shouldnt work though?

[Enlightened]

this is making the spousename field manadtory as well

if(isset($_POST['spousename']) === true) 
{
if(strlen($_POST['spousename']) < 2 || strlen($_POST['spousename']) > 20)
{
$errors[] = "Your spouse's first name is required.<br />";
}else{
$sn = trim($_POST['spousename']);

}
}

[gufmn]

If you don't want it manditory, why are you doing this:

$errors[] = "Your spouse's first name is required.<br />";

And you don't need the === true thing.

Try this:

if(isset($_POST['spousename'])) {
    if(strlen($_POST['spousename']) < 2 || strlen($_POST['spousename']) > 20) {
        $errors[] = "Your spouse's first name is required.<br />";
        echo "Invalid Spouse name entered!";
    }
    else {
        $sn = trim($_POST['spousename']);
        echo "You entered " . $sn . "as a spouse name.";
    }
else {
    echo "No spouse name entered.";
}

[Enlightened]

umm thats the error array, if it has a value, its checked, if not its ignored
Why would i echo something after adding there error to the array?

[gufmn]

I can see it's in the error array. Your making this confusing for those trying to help by saying you don't want $_POST['spousename'] to be manditory and then having something like that in your script. Makes it harder to see exactly what your trying to do.

As far as the echo statements, they are for testing.

You have 3 possible scenarios:
1) Valid spouse name is entered.
2) Invalid spouse name is entered.
3) No spouse name is entered.

By using the echos you should be able to see the if/else statements working. Once you are sure they are, you can handle each scenario appropriately.

[Enlightened]

Ok apparently it still fails, Does that mean for some reason it isset?

[gufmn]

My guess is it's getting posted as an empty string which is not the same as a null value. So in that case, it is set even though it's set to "".

so do something like:

if(isset($POST['spousename']) && $POST['spousename'] != ""){