PHP form question

mammothguy

A small problem (hopefully)

I've got an html form that uses a .php file to send me contact and service info to my email account. It works fine, but part of the form is a long list of text fields that can be left empty by the customer. My php code sends me every single field name and field value even if the field was left blank. How can I get the php to send me just the fields that have been filled in and leave the blank fields out of my email.

Here is the relevant php code:

$msg = "Below is a result from your contact form. It was submitted on $date at $time.\n\n";

if ($SERVER['REQUEST_METHOD'] == "POST") {
foreach ($POST as $key => $value) {
$msg .= ucfirst ($key) ." : ". $value . "\n";
}
}
else {
foreach ($_GET as $key => $value) {
$msg .= ucfirst ($key) ." : ". $value . "\n";
}
}

What do I need to add?

maxpup979

try this:


if(($value!="")){
 $msg .= ucfirst ($key) ." : ". $value . "\n";
}

dalecosp

foreach ($_GET as $key => $value) {
   if (isset($value)) {
      $msg .= ucfirst ($key) ." : ". $value . "\n";
   }
}
}

should do the trick.

dalecosp

Heh, sorry, maxpup.

I guess this sat here for an hour or so, open on my browser, whilst I fought with a newbie mistake one of my juniors made ... on my wife's 'puter. :mad:

mammothguy

I tried them both and no dice. Where should they go on the page? I'm using METHOD="POST" in the html form tag if that helps.

dalecosp

Well, you should simply put maxpup's above (and closing bracket below) the concatenation of the $msg variable.

I apparently copied my start at your code from the GET portion of the "else if" layout; but if you change it to $_POST and put it in the right spot ... it should work.

Bah, heck:

<?php

$msg = "Below is a result from your contact form. It was submitted on $date at $time.\n\n";

if ($_SERVER['REQUEST_METHOD'] == "POST") {
   foreach ($_POST as $key => $value) {
      if (isset($value)&& $value!='') {
         $msg .= ucfirst ($key) ." : ". $value . "\n";
      }
   }
} else {
   foreach ($_GET as $key => $value) {
      if (isset($value) && $value!='') {
         $msg .= ucfirst ($key) ." : ". $value . "\n";
      }
   } 
}
?>

If this doesn't work, then what do you get? Error messages, copy of output, etc.

mammothguy

Kool and the Gang. It works like a charm.

I had put it in your (dalecosp) way, but I left out a bracket somewhere.

Thanks a lot.

dalecosp

mammothguy wrote:
I had put it in your (dalecosp) way, but I left out a bracket somewhere.

Thanks a lot.

Style makes a big difference sometimes. Mine is above, note that each closing bracket should line up in a straight line below the conditional (or whatever) that caused the need for it.

Another, possibly more prevalent style, sometimes known as "K&R" (for Brian Kernighan and Dennis Ritchie, authors of the most well-known C textbook [among other things]):

<?php
if ($foo)
{
   if (isset($foo))
   {
      do_some_foo();
   } 
}
?>

So, every top and bottom bracket are aligned. Helps to check for balance. Of course, some IDE's/editors can do this for ya, too....