parser error (T_Variable)

claire

I have a very simple script for a login form, but cannot get it to work! I'm getting a parse error (unexpected T_variable) which I do not understand. Can anyone help, please?

session_start();

if ($op=="ds") {

            if (($username !="admin") || ($password != "123456")) {
                           $msg= "<P> <font color= "#FF0000"> <strong> Unsuccesful login !</strong> </font></p>";
                            $show_form = "yes";

                            } else {

                            session_register ('valid');
                            $valid = "yes";

                            $show_menu = "yes";
                            }

                } else {

                						 if ($valid =="yes") {
                             $show_menu = "yes";
                           } else {
                             $show_form = "yes";
                           }
               }

$form_block ="<h1>Login</h1>
<form method= post action="$PHP_SELF">
$msg
<P><strong>username:</strong><br>
<input type="text" name="username" size =15 maxlength=25></P>
<P><strong>password:</strong><br>
<input type="password" name="password" size=15 maxlength=25></P>
<input type="hidden" name="op" value="ds">
<br>
<P><input type="submit" name="submit" value="login"></P>
</form>";
$menu_block="<h1>MENu</h1>";

if ($show_form =="yes") {
$display_block=$form_block;
} else if ($show_menu =="yes") {
$display_block = $menu_block;
}

?>
<HTML>
<HEAD>
<TITLE>loginscript</TITLE>
</HEAD>
<BODY>
<? echo "$display_block";?>
</BODY>
</HTML>

trexx

you have to escape quotes in strings. write:

$s = 'this is a "quote" and so on'; # string begins and end with single quotes;

$s = "this is a \"quote\" and so on"; # string begins with double quotes, quotes have to be escaped

gufmn

Things like this are 1000 times easier to decipher when your code is in [ php ][/ php ]
tags.

Rodney_H_

I think the culprit might be this:

$msg= "<P> <font color= "#FF0000"> <strong> Unsuccesful login !</strong> </font></p>";

I think it should be this:

$msg= "<p style=\"color:#FF0000;\"><strong>Unsuccesful login !</strong></p>";

pjleonhardt

Rodney H. wrote:
And if you want to get technical, the font tags are deprecated and it should be something like this:
$msg= "<p style=\"color:#FF0000;\"><strong>Unsuccesful login !</strong></p>"; 

well, if you want to get really techinical, the style attribute is also deprecated and you should do

<p class="error>Unsuccesful login</p>

and then with CSS

  p.error {
    color: #F00;
    font-weight: bold;
  }

😃

Rodney_H_

pjleonhardt wrote:
well, if you want to get really techinical, the style attribute is also deprecated and you should do
<p class="error>Unsuccesful login</p>
and then with CSS
  p.error {
    color: #F00;
    font-weight: bold;
  }
😃

Nice One!! Roger that! 😃

trexx

I really don't think that the style attribute is deprecated. ok, it's ugly - you're right =) but in HTML 4.01 style is perfectly okay:

http://www.w3.org/TR/REC-html40/present/styles.html#h-14.2.2

anyway... we're somehow OT with that :-D