Broken loop problem

[SeventhOmen]

Greetings.
I have a tabular form that has editable columns. The default value for one of the coulmns is zero. The problem I have is that the loop breaks as soon as it encounters a zero or null value. How do I fix this?
The code:

<?

//echo "<hr /><pre>";print_r($_REQUEST); echo "</pre><hr />";

As you can see, I already varified that the array data is getting here.

---

do
{
$b = current($rid);

$c = current($qoh);

$o = current($qr);

This is the variable that breaks the loop if it is set to zero or null.

$n = current($qo);
$d = current($quote);
$e = current($po);
$f = current($pod);
$g = current($poed);
$h = current($lpr);
$i = current($unwd);
$j = current($core);
$k = current($material);
$l = current($bin);
$m = current($status);
$diff = ($c - $o);




//The query

---

The query works fine.

}while(next($rid) && next($qoh) && next($qr) && next($qo) && next($quote) && next($po) && next($pod) && next($poed) && next($lpr) && next($unwd) && next($core) && next($material) && next($bin) && next($status));

?>

Everything worked as planned until I introduced the $o variable.
I do not understand how to get this loop to skip over the portion of array data that contains the $qr=false and continue on with the next.

Thank you in advance for your time and effort with this matter.
Omen

[Weedpacket]

I can certainly tell you one thing: there is a much better way of handling your data.

Instead of separate arrays $rid, $qoh, $qr etc. etc. etc., just have one array $thingies (though of course you should use a better name than that!) and have the elements of the arrays stored in that; instead of $rid[0] you have $thingies[0]['rid'], instead of $qoh[42] you have $thingies[42]['qoh'], etc. etc..

Then you can use [man]foreach[/man] to loop through them all.

foreach($thingies as $thingy)
{
    $rid = $thingy['rid']; // Now we can use $rid to contain the rid instead of the obscure $b;
    $qoh = $thingy['qoh']; // Etc.
    // Etc.
}

That would tidy up your code hugely and probably fix your problem in the process (or at least reveal what the problem is).

[SeventhOmen]

I guess I need to clarify things a bit.
I am working with up to 25 lines on the tabular form. Thus the need for seperate arrays. What I am trying to do is inspect the value of $o. If it returns 0(zero) I would need to stop and advance the array pointers by one. The do-while loop currently breaks when (in 'while') the value of $qr equates to 0(zero). Remember that $o = current($qr)
I am also pulling in the arrays and their data via $_GET
Perhaps I am misunderstanding what Weedpacket wrote. I tried to adjust my code but it grew immensely using 'foreach'. The current script is small and thats a design goal that I need to follow.
Here is the entire script:
<?
Session_start();
header("Cache-control: private");
include_once("../xxx.php");
include_once("../xxxxx.php");
include_once("../xxxx.php");

$success = "xxxx.html";
$customer=$SESSION['customer'];
$orion=$GET['or'];
$rid=$GET['rid'];
$qoh=$GET['qoh'];
$qr=$GET['qr'];
$qo=$GET['qo'];
$quote=$GET['quote'];
$po=$GET['po'];
$pod=$GET['pod'];
$poed=$GET['poed'];
$lpr=$GET['lpr'];
$unwd=$GET['unwd'];
$core=$GET['core'];
$material=$GET['material'];
$bin=$GET['bin'];
$status=$GET['status'];

//echo "<hr /><pre>";print_r($_REQUEST); echo "</pre><hr />";

//Connect to the database server
//mysql_connect("localhost","$USERNAME","$PASSWORD") or die ("can not connect");
include "xxxxxxx.php";
//Change to the database
mysql_select_db ("$xxxxxx") or die ("Could not select database");

do
{
$b = current($rid);
$c = current($qoh);
$o = current($qr);
$n = current($qo);
$d = current($quote);
$e = current($po);
$f = current($pod);
$g = current($poed);
$h = current($lpr);
$i = current($unwd);
$j = current($core);
$k = current($material);
$l = current($bin);
$m = current($status);
$diff = ($c - $o);

//echo $diff;

//echo "The next element group is: $b, $c, $d, $e, $f, $g,$h, $i, $j, $k, $l, $m, $n, $o, $diff .";
//The query
$query="UPDATE inventory SET `Current_Quote`='$d',`Qty_On_Hand`='$diff',`Qty_Ordered`='$n',`Bin_Location`='$l',`Unwind_Direction`='$i',`Labels_Per_Roll`='$h',`Core_Size`='$j',`Material`='$k',`Status`='$m',`PO_Date`='$f',`PO_Exp_Date`='$g',`PO_Number`='$e' WHERE `rowID`='$b'";
$result=mysql_query($query);

}while(next($rid) && next($qoh) && next($qr) && next($qo) && next($quote) && next($po) && next($pod) && next($poed) && next($lpr) && next($unwd) && next($core) && next($material) && next($bin) && next($status));
?>

Most (if not all) 'echo' are there for troubleshooting.

Thank you in advance for your time and effort with this matter,
Omen

[Weedpacket]

I still say there must be a much better approach. But if you say otherwise....

Your will will only continue for as long as none of your swarm of variables are false. As soon as any of them are false (or zero, or null, or an empty string), then the loop will stop.

If you want to keep going until all of them are false, then you want to keep going as long as any of them are not false. So you want || instead of &&.

[SeventhOmen]

Here is a bit of the tabular form code so that you can see how the arrays are structured

<tr>

<td BGCOLOR="ffffff"><font face="Arial, Helvetica, sans-serif" size="-1"><INPUT NAME='qoh[]' size=8 value=<? echo"$qoh"?>></font></td>
<td BGCOLOR="ffffff"><font face="Arial, Helvetica, sans-serif"><INPUT NAME='qr[]' size=8 value = "0"></font></td>
<td BGCOLOR="ffffff"><font face="Arial, Helvetica, sans-serif"><INPUT NAME='qo[]' size=8 VALUE=<? echo"$qo"?>></font></td>
<td BGCOLOR="ffffff"><font face="Arial, Helvetica, sans-serif"><INPUT NAME='quote[]' size=8 VALUE=<? echo "$quote"; ?>></font></td>
<td BGCOLOR="ffffff"><font face="Arial, Helvetica, sans-serif"><INPUT NAME= 'po[]' size=16 value=<? echo "$po"; ?>></font></td>
<td BGCOLOR="ffffff"><font face="Arial, Helvetica, sans-serif"><INPUT NAME= 'pod[]' size=10 value=<? echo "$pod"; ?>></font></td>
<td BGCOLOR="ffffff"><font face="Arial, Helvetica, sans-serif"><INPUT NAME='poed[]' size=10 VALUE=<?echo"$poed"?>></font></td>
<td BGCOLOR="ffffff"><font face="Arial, Helvetica, sans-serif"><INPUT NAME='lpr[]' size=8 value=<? echo "$lpr"; ?>></font></td>
<td BGCOLOR="ffffff"><font face="Arial, Helvetica, sans-serif"><INPUT NAME='unwd[]' size=8 value=<? echo "$unwd"; ?>></font></td>
<td BGCOLOR="ffffff"><font face="Arial, Helvetica, sans-serif"><INPUT NAME='core[]' size=4 value=<? echo "$core"; ?>></font></td>
<td BGCOLOR="ffffff"><font face="Arial, Helvetica, sans-serif"><INPUT NAME='material[]' size=24 value="<?echo $material ?>"></font></td>
<td BGCOLOR="ffffff"><font face="Arial, Helvetica, sans-serif"><INPUT NAME='bin[]' size=8 VALUE=<?echo"$bin"?>></font></td>
<td BGCOLOR="ffffff"><font face="Arial, Helvetica, sans-serif"><INPUT NAME='status[]' size=24 VALUE="<?echo$status?>"></font></td>
</tr>
I hope this clarifies the way that the arrays are structured.

I agree that weedpackets method is good, I just do not see how it will work in this application. I admit that I might be missing something, still. I dont want to debate the pros/cons. I just want to find a viable solution to this dilemma, so all input is valued. Maybe I just dont understand 'foreach' as it may apply here.

Thank you in advance for your time and effort with this matter,
Omen

[umrguy]

I have to agree with Weedpacket on this, there is a much better way and he has wrote a way that is pretty good. As far as your error goes, when assigning the variables, you could include a loop that checks for 0 or NULL values in the variables. If one of them is the case, you could set a variable like $next. Inside of your do-while loop, you could nest everything within an if statement that checked for if $next was set. If it was, it would skip all of your variable assignments and move straight to the while logic.

Example could be:

if ($anyvariablethatcouldbenull == NULL or $anyvar == 0)
$next = 1;

do
{
if ($next != 1)
{
do all assignments
}
}while(your while statement)

This would skip over any data set that contains a NULL or 0 value for anything that can not have a null or 0 value.

[Weedpacket]

Oh, for crying out loud; you mean there are still people who use <font> tags?! Haven't they heard the twenty-first century has already begin? 🙂🙂

I don't know what you're displaying on each row, so I'm still going to call them thingies. But consider naming your fields

<INPUT NAME='thingy[0][qoh]' size=8 value = "0">
<INPUT NAME='thingy[0][qr]' size=8 value = "0">
<INPUT NAME='thingy[0][poed]' size=8 value = "0">

etc. in the first row, then

<INPUT NAME='thingy[1][qoh]' size=8 value = "0">
<INPUT NAME='thingy[1][qr]' size=8 value = "0">
<INPUT NAME='thingy[1][poed]' size=8 value = "0">

in the next row, and so on.
Then you'd have an array $POST['thingy'] which contains all of your thingies. $POST['thingy'][0] is the zeroth thingy, $POST['thingy'][1] is the first thingy, $POST['thingy'][2] is the second thingy, and it's obvious how to loop over that.

Each of those is an array. The values of the above fields, for example, would be contained in $POST['thingy'][0]['qoh'], $POST['thingy'][0]['qr'], $POST['thingy'][0]['poed'], $POST['thingy'][1]['qoh'], $POST['thingy'][1]['qr'], and $POST['thingy'][1]['poed']. Even if some of them are missing for some reason there's still no risk of thingy[4]'s fields getting mixed up with those of thingy[3].

If you find yourself writing something like "while(next($rid) && next($qoh) && next($qr) && next($qo) && next($quote) && next($po) && next($pod) && next($poed) && next($lpr) && next($unwd) && next($core) && next($material) && next($bin) && next($status));" then it's a very good sign that you need to take a step back and look at your data and whether it has any structure that you're not exploiting.

[PABobo]

I am looking at your responses to the borken loop thread. I am trying to do the same thing but having major issues. I tried an inner join with 2 tables and each time i would get a return of false and no output. So i created 2 seperate queries and tried to loop them together. I am getting the first line of the true data but nothing of the false data. Here is my quieries and my table format. Can you help me? Also my IFNULL is not working
<?php
mysql_select_db($database_vp, $vp);
$query_csfm = "SELECT * FROM csf Where csf.csf_type = '$typem' ORDER by csf.csf_id";
$csfm = mysql_query($query_csfm, $vp) or die(mysql_error());
$row_csfm = mysql_fetch_assoc($csfm);
$totalRows_csfm = mysql_num_rows($csfm);
$query_csfmv = "SELECT csf_orders.csf_id, csf_percentage, IFNULL(SUM(csf_orders.october_order_total),0) as totalsoctobercsf, IFNULL(SUM(csf_orders.january_order_total),0) as totalsjanuarycsf, IFNULL(SUM(csf_orders.february_order_total),0) as totalsfebruarycsf, IFNULL(SUM(csf_orders.march_order_total),0) as totalsmarchcsf, IFNULL(SUM(csf_orders.april_order_total),0) as totalsaprilcsf, IFNULL(SUM(csf_orders.may_order_total),0) as totalsmaycsf, IFNULL(SUM(csf_orders.june_order_total),0) as totalsjunecsf, IFNULL(SUM(csf_orders.july_order_total),0) as totalsjulycsf, IFNULL(SUM(csf_orders.august_order_total),0) as totalsaugustcsf, IFNULL(SUM(csf_orders.september_order_total),0) as totalsseptembercsf, IFNULL(SUM(csf_orders.november_order_total),0) as totalsnovembercsf, IFNULL(SUM(csf_orders.december_order_total),0) as totalsdecembercsf, csf.csf_type, csf.csf_name FROM csf_orders INNER JOIN csf ON csf.csf_id = csf_orders.csf_id WHERE csf_orders.member_profile_id ='$col' AND csf.csf_type = '$typem' Group By csf.csf_id";
$csfmv = mysql_query($query_csfmv, $vp) or die(mysql_error());
$row_csfmv = mysql_fetch_assoc($csfmv);
$totalRows_csfmv = mysql_num_rows($csfmv);
?>

YADA YADA YADA YADA and by they way YADA!

<?php
$row_csfm = mysql_fetch_assoc($csfm);
$row_csfmv = mysql_fetch_assoc($csfmv);

do {
?>
<tr>
<td class="paragraph" align="left" style='border-top:none'><?php echo ucfirst($row_csfm['csf_name']); ?></td>
<td class="paragraph" align="center">&nbsp;</td>
<td class="paragraph" align="center"><?php echo $row_csfm['csf_percentage']; ?></td>
<td class="paragraph" align="center"><?php if (!(strcmp($row_csfmv['totalsjanuarycsf'], ""))) {echo "0";} else echo $row_csfmv['totalsjanuarycsf']; ?></td>
<td class="paragraph" align="center"><?php if (!(strcmp($row_csfmv['totalsfebruarycsf'], ""))) {echo "0";} else echo $row_csfmv['totalsfebruarycsf']; ?></td>
<td class="paragraph" align="center"><?php if (!(strcmp($row_csfmv['totalsmarchcsf'], ""))) {echo "0";} else echo $row_csfmv['totalsmarchcsf']; ?></td>
<td class="paragraph" align="center"><?php if (!(strcmp($row_csfmv['totalsaprilcsf'], ""))) {echo "0";} else echo $row_csfmv['totalsaprilcsf']; ?></td>
<td class="paragraph" align="center"><?php if (!(strcmp($row_csfmv['totalsmaycsf'], ""))) {echo "0";} else echo $row_csfmv['totalsmaycsf']; ?></td>
<td class="paragraph" align="center"><?php if (!(strcmp($row_csfmv['totalsjunecsf'], ""))) {echo "0";} else echo $row_csfmv['totalsjunecsf']; ?></td>
<td class="paragraph" align="center"><?php if (!(strcmp($row_csfmv['totalsjulycsf'], ""))) {echo "0";} else echo $row_csfmv['totalsjulycsf']; ?></td>
<td class="paragraph" align="center"><?php if (!(strcmp($row_csfmv['totalsaugustcsf'], ""))) {echo "0";} else echo $row_csfmv['totalsaugustcsf']; ?></td>
<td class="paragraph" align="center"><?php if (!(strcmp($row_csfmv['totalsseptembercsf'], ""))) {echo "0";} else echo $row_csfmv['totalsseptembercsf']; ?></td>
<td class="paragraph" align="center"><?php if (!(strcmp($row_csfmv['totalsoctobercsf'], ""))) {echo "0";} else echo $row_csfmv['totalsoctobercsf'] ;?></td>

<td class="paragraph" align="center"><?php if (!(strcmp($row_csfmv['totalsnovembercsf'], ""))) {echo "0";} else echo $row_csfmv['totalsnovembercsf']; ?></td>
<td class="paragraph" align="center"><?php if (!(strcmp($row_csfmv['totalsdecembercsf'], ""))) {echo "0";} else echo $row_csfmv['totalsdecembercsf']; ?></td>
<td class="paragraph" align="center">&nbsp;</td>
</tr> <?php } while (next($row_csfmv) && next($row_csfm)) ; ?>

[PABobo]

If i change from && to || i get

<?php } while (next($row_csfmv) || next($row_csfm));
?>

PG Check-off box on AF cards? 2% 0 0 0 0 0 0 0 0 0 0 0 0

PG Check-off box on AF cards? 2% 0 0 0 0 0 0 0 0 0 0 0 0

PG Check-off box on AF cards? 2% 0 0 0 0 0 0 0 0 0 0 0 0

PG Check-off box on AF cards? 2% 0 0 0 0 0 0 0 0 0 0 0 0

PG Check-off box on AF cards? 2% 0 0 0 0 0 0 0 0 0 0 0 0

PG Check-off box on AF cards? 2% 0 0 0 0 0 0 0 0 0 0 0 0

PG Check-off box on AF cards? 2% 0 0 0 0 0 0 0 0 0 0 0 0

Changed the 7 seperate questions to only 1 missing 6 others

If i leave it at && i get

<?php } while (next($row_csfmv) && next($row_csfm));
?>

PG Check-off box on AF cards? 2% 0 0 0 0 0 0 0 0 0 0 0 0

missing the other 6 questions