Hi,

I am using a PHP script to randomise background images of pages which are loaded into an iframe on my site. As I do not understand PHP, I cannot tell which bit of the code I am using is selecting the image randomly. The script works well but has a tendancy to select the same picture a few times or it almost goes through the pictures from the top of the list to the bottom - not very random!

I wondered if someone could have a look at it for me and see if they can improve the randomness of the script?

The website is www.occasionaljazz.co.uk and the PHP script I am using is below. It is setup so that it has just been dropped in the folder of images concerned.

Thanks

Alex

<?php
$folder = '.';

$extList = array();
$extList['gif'] = 'image/gif';
$extList['jpg'] = 'image/jpeg';
$extList['jpeg'] = 'image/jpeg';
$extList['png'] = 'image/png';

$img = null;

if (substr($folder,-1) != '/') {
$folder = $folder.'/';
}

if (isset($GET['img'])) {
$imageInfo = pathinfo($
GET['img']);
if (
isset( $extList[ strtolower( $imageInfo['extension'] ) ] ) &&
file_exists( $folder.$imageInfo['basename'] )
) {
$img = $folder.$imageInfo['basename'];
}
} else {
$fileList = array();
$handle = opendir($folder);
while ( false !== ( $file = readdir($handle) ) ) {
$file_info = pathinfo($file);
if (
isset( $extList[ strtolower( $file_info['extension'] ) ] )
) {
$fileList[] = $file;
}
}
closedir($handle);

if (count($fileList) > 0) {
$imageNumber = time() % count($fileList);
$img = $folder.$fileList[$imageNumber];
}
}

if ($img!=null) {
$imageInfo = pathinfo($img);
$contentType = 'Content-type: '.$extList[ $imageInfo['extension'] ];
header ($contentType);
readfile($img);
} else {
if ( function_exists('imagecreate') ) {
header ("Content-type: image/png");
$im = @imagecreate (100, 100)
or die ("Cannot initialize new GD image stream");
$background_color = imagecolorallocate ($im, 255, 255, 255);
$text_color = imagecolorallocate ($im, 0,0,0);
imagestring ($im, 2, 5, 5, "IMAGE ERROR", $text_color);
imagepng ($im);
imagedestroy($im);
}
}

?>

    if (count($fileList) > 0) {
    $imageNumber = time() % count($fileList);
    $img = $folder.$fileList[$imageNumber];
    }

    Try:

    if (Count($fileList) > 0 {
      $img = $folder.$fileList[array_rand($fileList)];
    }

    A few things:
    1. I like the music!
    2. Please indent your code (or use the CODE tags)!!!

    Good luck!

      Hi,

      Sorry about the lack of CODE tags. Your answer works brilliantly and is a lot more random! Thanks very much!

      Alex

        Write a Reply...