[RESOLVED] user defined functions

joviyach

I am to take the following code and make it use two user defined functions.

One function is supposed to process the "order" information. The second is supposed to write the information to a text file. Problem is, I don't know where to start, and the writing of the information technically already uses the non-user defined fopen function.

<?php

require('header.inc');

?>
<?php

$DOCUMENT_ROOT = $_SERVER['DOCUMENT_ROOT']//."/genesis/web_pages/joviyach";
?>
<html>
<head>
<title>Bob's Auto Parts - Order Results</title>
</head>
<body>
<h1>Bob's Auto Parts</h1>
<h2>Order Results</h2>
<?php
$date = date('H:i, jS F');

echo 'Order processed at ';
echo $date;
echo '';

echo 'Your order is as follows: ';

$totalqty = 0;
$totalqty = $POST['tireqty'] + $POST['oilqty'] + $POST['sparkqty']
+ $POST['coolqty'] + $_POST['wiperqty'];
echo 'Items ordered: '.$totalqty.' ';

if( $totalqty == 0)
{
echo 'You did not order anything on the previous page! ';
}
else
{
if ( $POST['tireqty']>0 )
echo $POST['tireqty'].' tires ';
if ( $POST['oilqty']>0 )
echo $POST['oilqty'].' bottles of oil ';
if ( $POST['sparkqty']>0 )
echo $POST['sparkqty'].' spark plugs ';
if ( $POST['coolqty']>0 )
echo $POST['coolqty'].' coolant ';
if ( $POST['wiperqty']>0 )
echo $POST['wiperqty'].' wiper blades ';
}

$totalamount = 0.00;

define('TIREPRICE', 100);
define('OILPRICE', 10);
define('SPARKPRICE', 4);
define('COOLPRICE', 1);
define('WIPERPRICE', 3);

$totalamount = $POST['tireqty'] TIREPRICE + $POST['oilqty'] OILPRICE + $POST['sparkqty'] SPARKPRICE
+ $POST['coolqty'] COOLPRICE + $_POST['wiperqty'] * WIPERPRICE;

$totalamount = $totalamount + ($totalamount * .10);
$totalamount=number_format($totalamount, 2, '.', ' ');

echo 'Total of order is '.$totalamount.'';
echo 'Address to ship to is '.$_POST['address'].'';

$outputstring = $date."\t".$POST['tireqty']." tires \t".$POST['oilqty']." oil\t"
.$POST['sparkqty']." spark plugs\t".$POST['coolqty']." coolant\t"
.$POST['wiperqty']." wiper blades\t\$".$totalamount
."\t". $POST['address']."\n";

// open file for appending
@ $fp = fopen("$DOCUMENT_ROOT/folder2/orders.txt", 'ab');

flock($fp, LOCK_EX);

if (!$fp)
{
echo ' Your order could not be processed at this time. '
.'Please try again later.</body></html>';
exit;
}

fwrite($fp, $outputstring, strlen($outputstring));
flock($fp, LOCK_UN);
fclose($fp);

echo 'Order written.';
?>
 Click <A HREF="vieworders2.php">HERE</A> to see all submitted orders.
 Click <A HREF="bobs_front_page.php">HERE</A> to go to the home page.
 Or click <A HREF="orderform-c.php">HERE</A> to spend some more money.
</body>
<?php

require('footer.inc');

?>
</html>

[/B][/COLOR]

matto

non-user defined functions in user-defined functions are not a problem but the way a program language is used 🙂

you will need sth like this:

function processOrder($quantity, $item_no, $user_id)
{
  // database writing
  // e-mail sending
  // whatever necessary ...
  // on success:
  return true;
  // else:
  return false; // outside, react upon this with an error message
}

// usage example:

if(isset($_POST['my_submit_button_name']))
{
  $success = processOrder($_POST['qty'], $_POST['itemno'], $logged_in_user_id);
  if(!$success)
    echo "ERROR, could not process order";
}

// writing function:

function storeOrder($quantity, $item_no, $user_id)
{
  // here comes the fopen/flock/fwrite part, using the parameters from above ($quantity, ...)
  // you could call this inside processOrder, if processOrder was successful, so you just need to call one function from outside.
}

hints:
if you need to use a variable from outside and it's not convenient to pass it via the parameter list, "pull it inside" via global $var_from_outside; at the begin of your function.
a parameter should be optional?
function blah($parameter1, $optional_parameter='default_value') { ... }
if $optional_parameter is not given on call, it automatically gets 'default_value' set.

hope this helps.

joviyach

I apologize, but I'm still not sure I understand the concept of inside and outside variables.

Rodney_H_

This should help clarify with example: http://www.zend.com/php/beginners/php101-6.php#Heading8

dalecosp

joviyach wrote:
I apologize, but I'm still not sure I understand the concept of inside and outside variables.

Brief tutorial:

<?php

// scope.php - a short demonstration of "inside"
// and "outside" variables, otherwise and correctly
// known as "in scope" and "out of scope", or something
// equally inane like that...


function print_foo($foo) {
   echo nl2br("Foo is $foo
   Bar is $bar -
   Baz is $baz -
   And I don't care 'bout no garply...

   ");
}


function print_all($foo) {

   global $bar, $baz, $garply;

   echo nl2br("Foo is $foo 
   Bar is $bar -
   Baz is $baz -
   And I got $garply for a garply value...

   ");

}

// assign some values
$foo="foo";
$bar="bar";
$baz="baz";
$garply="something really weird";


// call the functions

print_foo($foo);
print_foo($bar);
print_all($foo);

?>

Here's your output:

Foo is foo
   Bar is  -
   Baz is  -
   And I don't care 'bout no garply...

   Foo is bar
   Bar is  -
   Baz is  -
   And I don't care 'bout no garply...

   Foo is foo 
   Bar is bar -
   Baz is baz -
   And I got something really weird for a garply value...

By telling the "print_all" function to get values for $bar, $baz, and $garply from the global (outside) scope, the print_all function succeeds in printing the correct values for all four variables....

HTH,