Is this a valid query?

Hi,
I want to make a basic selection from the DB and I'm not sure if this is valid:

$check_sent_sql = "SELECT * FROM cadogan_send_checker WHERE mailID = '$email_id' AND mailQ = 0 OR mailQ = 2";

I need to select a row which matches 2 values (one could be one of 2)

Thanks

it looks ok to me. but a few tips on that subject:

if $emailId is a numeric value don't use single quotes around the value
if $emailId is a numeric value and if it's submitted by a form or by a URL use the intval function on it.
echo your $query and execute it in phpMyAdmin or on the mysql command line to see if it's valid or not. MySQL (and other databases) will tell you exactly what's wrong with your statement.
if $emailId is non-numeric you should use addslashes() on it. because your query will fail if there's a single quote in the string (see also get_magic_quotes_gpc() in the php manual)
instead of using or in a where clause you could write it that way:
```
...where mailq in (0,2);
```

Thanks alot Trexx, That's exactly the type of advice I was looking for,

I'll run some checks in phpMyAdmin and also check into the quotations etc.

Enjoy

trexx wrote:
...where mailq in (0,2);

Just one quickie, what does the "in" mean?
Thanks

I believe it stands for while $mailq is equal to either 0 or 2.

that's right. it's just a shorter notation of "x=0 or x=2 or x=4 or ...".

Thanks again 🙂

Please mark this thread as resolved.