[RESOLVED] help plz

[stebut05]

Hi,

Really, really appreciate any help given urgent problem. I have moved a website from one server to another and having problems. On a product page a user clicks on a link that directs them to more details about a product. The link uses a varibale from database query:

<a href="artificial_christmas_tree_details.php?product_name=<?php echo ['$row_prod['product_name']; ?>

Now this was working but not working now???? I dont know if has anything to do with URL code. As product name has %20 in it. But as i say this was working on first server not now.

URL: artificial_christmas_tree_details.php?product_name=Yardley%20Fir.

Really need some help and really appreciate help. advice, suggestions

Regards

Steven

[paulnaj]

First of all, this link ...

<a href="artificial_christmas_tree_details.php?product_name=<?php echo ['$row_prod['product_name']; ?>

... is not well-formed as it stands. Should be something like ...

<a href="artificial_christmas_tree_details.php?product_name=<?php echo ['$row_prod['product_name']; ?>"><?php echo ['$row_prod['product_name']; ?></a>

Secondly, how is product_name referred to in artificial_christmas_tree_details.php? You should use $GET['product_name'] and not just $product_name. Using the $GET (or $_POST) variable is now default behaviour.

(BTW Don't use $HTTP_GET_VARS['product_name'] either ... this has been deprecated altogether).

Paul 🙂

PS. The %20 is just URL-encoded 'space' and shouldn't be a problem.

[stebut05]

Hi,

Thanks for your time. I have formated the link has above, but didnt want to add it on post, sorry. On the the artificial_christmas_tree_details.php page i used the following:

if (isset($POST['product_name']))
{
$product_name_RS = (get_magic_quotes_gpc()) ? $POST['product_name'] : addslashes($_POST['product_name']);
}

However, i have a feeling it is not this. I have just changed the website to live server and on live server i am having this problem, but on testing server i have no problems????? Any advice please???

Regards,

Steven

[paulnaj]

Hi Steven,

The statement ...

if (isset($_POST['product_name']))
{
$product_name_RS = (get_magic_quotes_gpc()) ? $_POST['product_name'] : addslashes($_POST['product_name']);
}

... is checking for a POST variable. These normally come from HTML forms that have set the attribute method="POST".

Variables that are sent via a link (as yours is) are usually GET variables, so should be referred to accordingly in the target script. So, you should have ...

if (isset($_GET['product_name']))
{
$product_name_RS = (get_magic_quotes_gpc()) ? $_GET['product_name'] : addslashes($_GET['product_name']);
}

I don't understand how it could work locally, though not on the target server!

Paul 🙂

[stebut05]

Thanks for your help paul,

I have changed to GET, but again still not working.

Link to testing server:
http://www.sbwebhosting.co.uk/CTL/artificial_christmas_trees.php

Link to live server:
http://www.christmastreeland.co.uk/artificial_christmas_trees.php

Both are using the same database and connection, so i really dont understand what the problem could be???

Regards,

Steven

[paulnaj]

Just had a look at the source of both pages and they are substantially different. The working site has the link ...

<a href="javascript:;" onClick="MM_openBrWindow('artificial_christmas_tree_details.php?product_name=Yardley+Fir','deliveryzones','scrollbars=yes,height=450,width=670')" class="imagelink">

... and the new non-working page has the link as ...

<a href="artificial_christmas_tree_details.php?product_name=Yardley+Fir" class="imagelink">

The good one's using a Dreamweaver Javascript function to pop-up the window, and the bad's just using a straightforward link. I don't use Dreamweaver so don't know exactly how it works ... I think you're going to have to ensure that you really are just moving files from one location to another.

Paul 🙂

[stebut05]

Hi Paul,

I removed the javascript to make it a little easier to read whilst tring to solve this problem, but i have tried with javascript on and odesnt work. As you can see with the code above they both have the same variable name and value. Any other thoughts?? really appreicate you help

Regards,

Steven

[paulnaj]

No, they are still straightforward links on the new site (just checked) ... so they are not exact copies.

I would first put EXACT copies onto the new site. It's not worth doing anything else until then.

Paul 🙂

[stebut05]

Hi Paul,

Should be the same now with standard links. Still same problem, thanks for your help any ideas??

Regards,

Steven

[paulnaj]

Ok, we're getting somewhere now ... when I try to see the detail page, I get two warnings:

Warning: mysql_fetch_assoc(): supplied argument is not a valid MySQL result resource in e:\domains\c\christmastreeland.co.uk\user\htdocs\artificial_christmas_tree_details.php on line 134

... and ...

Warning: mysql_free_result(): supplied argument is not a valid MySQL result resource in e:\domains\c\christmastreeland.co.uk\user\htdocs\artificial_christmas_tree_details.php on line 183

I think you are going to have to how us the artificial_christmas_tree_details.php in it's entirety.

Paul.

[stebut05]

Hi Paul,

The error message was caused when i echoed $product_name in the heading. I have removed it now. any ideas???

Regards,

Steven

[paulnaj]

Not without seeing the code.

If it's enormous (shouldn't be) then save a copy as a text file and attach it to a post.

If there is any sensitive info (connection details, usernames, passwords) then just XXX them out before posting.

P.

[stebut05]

Paul your a star mate,

Really, really appreciate all your help and patience, but i have done it. Variable error, but was working fine on old site and not on new site???? very strange!!! Any way its working fine now, thanks for all your help.

Kind Regards,

Steven