if/else PANIC

vronsky

Sorry,sorry...
but since a few years I am quietly coding scripts like :


if ($my_var == "this"){
// do anything
} elseif ($my_var == "that"){
// do anything else
} else {
// do default action....
}

This works ( I think) in everey version of php 4.x

Now I have purchased another server where is installed php 4.3.2 (here info.php file )
and it does not works anymore :eek:

Now, I have tons of code written in this way.... what could happen on this server?
Any help very very appreciated....
Max

toplay

That syntax will work with earlier versions of PHP too. So, my guess is that you have bugs in your code. You may have thought it was working before when perhaps it really wasn't.

Please post the exact code in question and specify the precise problem with it (what is happening?).

🙂

vronsky

I swear my code has worked on many platforms before this.

On a script like myscript.php

if ($my_var == "this"){
echo "this";
} elseif ($my_var == "that"){
echo "that";
} else {
echo "default";
}

If I call the script :

<a href="myscript.php?myvar=this">myscript</a>

It always return the default.

Rodney_H_

You need to convert the value to a variable before calling it in your script. Try this:

<?php
// get var
$my_var = trim($_GET['my_var']);

if ($my_var == "this"){
  echo "this";
}

elseif ($my_var == "that"){
  echo "that";
}

else {
  echo "default";
}

?>

thorpe

you need to reference $myvar from within the $GET array. ie $GET['myvar'].

vronsky

Ok, this maybe, but why this script use to work on any plattform and not in the last?

toplay

Oh, that's what you're talking about. Well, I have the answer.

Your 'register_globals' php.ini setting is set to off. You probably had it on before. When it's on, the $myvar variable will get created for you automatically by PHP. Since it's now off, PHP will not create it.

It is best to keep it off for security reasons and program accordingly. This means using $_GET in this instance. Example:

$myvar = isSet($GET['myvar']) ? $GET['myvar'] : ''; // Set to a default you want

if ('this' == $myvar) {
...

If you want it to behave the way it does with register_globals being on, but without actually turning it on, then you can use import_request_variables() or extract():
http://us2.php.net/manual/en/function.import-request-variables.php

🙂

EDIT: Posted too late.

vronsky

Thank you very much.... now I got.

A pizza paid next time you come to Italy
🙂