[RESOLVED] Simple Form Validation Problem

[middleman666]

ok, this is getting a tad too anoying - probly because I'm not understanding it correctly, but could someone please point out the problem with what I have:

if ($_POST["submitted"] == "yes"){

// Have all Fields been filled out? --------------------------------

$userfile = $_POST['userfile'];
$Thumbnail = $_POST['Thumbnail'];

if ($userfile == "" || $Thumbnail == "") { 
	$message = "- You did not fill out all the fields -"; 
	print "<script>window.location.href='$url_this?message=$message'</script>";
	exit; 
}

}

I have that code after my form. I want it to simply check that those two fields have been filled out. Problem im getting is that even if the fields are filled out, the error still appears.

any help would be great, thanks.

[toplay]

Since you didn't post the HTML form - double check the names used in your HTML form with what you are checking in your code. Maybe you called the HTML form variable "thumbnail" but in the code you're using a capital "T" as in "Thumbnail" for example.

Post the snippet of HTML form that pertains to this.

🙂

[Rodney_H_]

EDIT:

"Maybe you called the HTML form variable "thumbnail" but in the code you're using a capital "T" as in "Thumbnail" for example."

What toplay says is correct.

That is why you may want to consider coming up with a naming convention: ie, always name using $lowercaseletters ... or always $UpperCaseFirstLetterOfVariable...

[middleman666]

heres my form:

<form action="' . "$PHP_SELF" . '" method="post" enctype="multipart/form-data" name="upload">
	<b>: Location of File :</b><br>
	<input name="userfile" type="file" id="userfile" size="37">
	<br>
	<b>: Thumbnail Image : </b><br>
	<input name="Thumbnail" type="file" id="Thumbnail" size="37">
	<br>
	<br>
	<INPUT TYPE=hidden NAME="submitted" VALUE="yes">
	<input type="submit" name="action" id="action" value="Upload"> 
	<input name="clear" type="reset" id="clear" value="Clear">
	<br>
</form>

sorry, should have posted it earlier.

would it possibly be because the field types are 'file'? or should that not matter?

if there is a simple piece of code I could use to check if all fields are filled out then could someone post it?

thanks for the replies, the field name wasn't the problem and to tell the truth, im not sure why I put the T as a capital as I usually stick to lowercase.

[toplay]

I assume this form is being echoed out since I see you're using quotes and the period concatenation character on this line:

<form action="' . "$PHP_SELF" .

Try not to rely on that variable since that requires register_globals on which is a security risk. Change it to:

<form action="' . $_SERVER['PHP_SELF'] .

FYI: put quotes: <INPUT TYPE="hidden" NAME="submitted" VALUE="yes">
.

[qolbu]

for checking a "file" type use this :

if (isset($_FILES['Thumbnail']['name']) && ($_FILES['Thumbnail']['name']) {
 do upload etc..
} else {
throw the error..
}

[middleman666]

thanks toplay. I tried what you said but still no luck.

qolbu - thanks for the reply and pointer, but i already have validation for dealling with the files - which is kind of why this is puzzeling me because that works perfectly.

I can post my file validation if you think it would help? but I don't really see how it would..

[toplay]

qolbu is right. I didn't even really see it. You won't have a $POST['Thumbnail'] or $POST['userfile'] values set because they're type "file". Did you mean for one to be of type text or what?

🙂

[middleman666]

i thought qolbu was just pointing out how to check if a file is of the write type.

with what youve (toplay) have said though, I just want to check that a file has been selected for both of the fields - is that possible? or do i have to do it some other way?

[qolbu]

<form action="" method="post" enctype="multipart/form-data" name="upload"> 
    <b>: Location of File :</b><br> 
    <input name="userfile" type="file" id="userfile" size="37"> 
    <br> 
    <b>: Thumbnail Image : </b><br> 
    <input name="Thumbnail" type="file" id="Thumbnail" size="37"> 
    <br> 
    <br> 
    <INPUT TYPE=hidden NAME="submitted" VALUE="yes"> 
    <input type="submit" name="action" id="action" value="Upload">  

    <input name="clear" type="reset" id="clear" value="Clear"> 
    <br> 
</form>  

<?
if (isset($_POST['action']) && ($_POST['submitted']== 'yes')) { 

// Have all Fields been filled out? --------------------------------     
if (($_FILES['userfile']['name']) && ($_FILES['Thumbnail']['name'])) { 
    echo "file uploaded";  
} else {
	$message = "- You did not fill out all the fields -";  
    print "<script>window.location.href='$url_this?message=$message'</script>"; 
    exit;
}
}  

?>

ok, i've try it on my machine and it work, give it try. But i notice when I use isset php won't response so I remove the isset it work though, maybe just for "file" type. dunno 😃.

hope that help.

[middleman666]

That worked perfectly!

thanks for all your help qolbu and everyone else that replied.

[resolved]