Error in code

[Serpent7]

Hi there all!

I'm just starting db connectivity with mySQL, and it's been a while since I used php.

This code has an error somewhere, but my host is suppresing error messages, and I can't see for myself what's wrong; please advise? Thanks.

if ($add == "yes")
{
	$check = "[^0-9A-Za-z]";
	$agecheck = "[^0-9]";
	if (ereg($check, $username)) die('Username can only contain a-z and 0-9');
	if (ereg($check, $password)) die('Password can only contain a-z and 0-9');
	if ($age != "")
	{
		if (ereg($agecheck, $age)) die('Age can only contain 0-9');
	}
	elseif ($age == "")
	{
		$age = "NULL";
	}

// Connecting, selecting users database
	echo "Connecting, selecting users database...<BR>";
	$link = mysql_connect('localhost', 'username', 'password')
	   or die('Could not connect: ' . mysql_error());
	echo 'Connected successfully...<BR>';
	mysql_select_db('domd') or die('Could not select database');

$query = 'INSERT INTO `users` (`UserID`, `Username`, `Heirachy`, `Password`, `Age`, `Join_date`, `Last_login`, `Holiday`) VALUES (\'\', \'${username}\', 

\'m\', \'${password}\', \'${age}\', \'${date}\', \'${date}\', \'n\')'; 

	// Closing connection
	mysql_close($link);

}

Nots: The db connecting values aren't username etc., but I've replaced them for obvious reasons. 😉

[bike5]

Put

error_reporting(E_ALL);

before your code to unsupress the errors

also change your query to use double quotes
then take all the backslashes out and curley braces, I don't even know if you can call a variable inside a single quote string using curly braces?

[Serpent7]

Okay, thanks for your reply.

However, I've done all you said, and I still get a blank page with no indication of what's wrong.

I now personally believe there's something wrong with this:

if ($add == "yes")
{
	$check = "[^0-9A-Za-z]";
	$agecheck = "[^0-9]";
	if (ereg($check, $username)) die('Username can only contain a-z and 0-9');
	if (ereg($check, $password)) die('Password can only contain a-z and 0-9');
	if ($age != "")
	{
		if (ereg($agecheck, $age)) die('Age can only contain 0-9');
	}
	elseif ($age == "")
	{
		$age = "NULL";
	}

Thanks again.

[bike5]

start echo'ing the variables to see what they hold.. Does $age = yes? Maybe it doesn't and its not going over the rest of you code thus finding no errors and not displaying anything.

[Serpent7]

Thankyou, that helped a lot. I've resolved the problem now, only to face another. But that's specific to my host, and therefore not your problem. ><

Tyvm. +1 😉

[bike5]

Where is $add coming from? A form? If it is try using if ($POST['add'] == 'yes'), if you are sending it via "get" method then use $GET in replace or $_POST but I would recommend the post method.

YW 😉

[Serpent7]

Yes, $add is from a form.

And yes, it's POST.

Now it adds $username etc. as the values into the table, not what is contained within the variable. :S

EDIT- I thought it might be helpful to include a little more:

<p>Add user:</p>
<form action="http://www.thisiscorrect.com" method="post">
<p><input type=text name="username" maxlength=12> <<< Username (Max 12 characters) <br>
<input type=password name="password" maxlength=12> <<< Password (Max 12 characters) <br>
<input type=text name="age" maxlength=2> <<< Age (optional) <br>
<input type=hidden name="add" value="yes"> <br> </p>
<input type=submit value="Add user">



<?php

error_reporting(E_ALL);

if ($_POST['add'] == "yes")
{
	$check = "[^0-9A-Za-z]";
	$agecheck = "[^0-9]";
	if (ereg($check, $username)) die('Username can only contain a-z and 0-9');
	if (ereg($check, $password)) die('Password can only contain a-z and 0-9');
	if ($age != "")
	{
		if (ereg($agecheck, $age)) die('Age can only contain 0-9');
	}
	elseif ($age == "")
	{
		$age = "NULL";
	}


// Connecting, selecting users database
	echo "Connecting, selecting users database...<BR>";
	$link = mysql_connect('localhost', 'username', 'pass')
	   or die('Could not connect: ' . mysql_error());
	echo 'Connected successfully...<BR>';
	mysql_select_db('domd') or die('Could not select database');

$query = 'INSERT INTO `users` (`UserID`, `Username`, `Heirachy`, `Password`, `Age`, `Join_date`, `Last_login`, `Holiday`) VALUES (\'\', \'$username\', 

\'m\', \'$password\', \'$age\', \'$date\', \'$date\', \'n\')'; 

$result = mysql_query($query);
if (!result) error_message(sql_error());

	// Closing connection
	mysql_close($link);

}

?>

[bike5]

The your query is still messed up, try this-

$query = "INSERT INTO `users` (`UserID`, `Username`, `Heirachy`, `Password`, `Age`, `Join_date`, `Last_login`, `Holiday`) VALUES ('', '$username',
'm', '$password', '$age', '$date', '$date', 'n')"; 

You can't call the contents of a variable inside a single quote string, only a double quote or outside a string.

[Serpent7]

Just trying, I'll edit with the result in a sec. 😉 Thanks again, btw.

EDIT- Okay, it works brilliantly, thanks so much. Gl with your coding in the future. 😃

[bike5]

😉