Testing POST variables.

unreal128

I have a function that handles a form submission. One of the common validation tests I perform on the data is an 'isempty.' I would like to create a for loop to test this in all POST variables but am not quite sure the best way to do it.

$form_elements=array("username", "password", "zipcode");
foreach ($element as $form_elements)
{
     if (isempty($_POST[$element])
         ...
}

For some reason PHP doesn't like the way I did this and I think it has to do with the globbing of the variable. Does anyone have a best practice that they can share with me for handling multiple form elements with a single function?

toxic_brain

foreach($_POST as $element) {
      if (isempty($element) )
      .....  

}

$form_elements=array("username", "password", "zipcode");

but i didn't get why u used this.. ??

laserlight

You made a mistake in writing the start of the foreach loop, just swap the names and that should fix it.

$form_elements = array("username", "password", "zipcode");
foreach ($form_elements as $element) {
	if (isempty($_POST[$element])) {
		//...
	}
}

but i didn't get why u used this.. ??

unreal128 wants to test those incoming variables in particular. This may be more useful than your version, since your version tests all incoming variables from POST, but may not test required incoming variables that are not actually sent.

toxic_brain

mmmm

bretticus

Here's a way I like to do this. It's a blending of both your idea and toxic_brains...

$formIsValid = false;
foreach ($_POST as $key => $value) {
	switch ($key) {
		case "username":
			$formIsValid = !empty($value); //demonstrative only, don't really use this test.
			break;
		case "password":
			// or various tests within this case block.
			break;
		case "zipcode":
			break;	
		default:
			break;
	}
}

Not saying this is the best way to do this. Just a way, that's all.

laserlight

Heh, technically my fix isnt complete:

$form_elements = array("username", "password", "zipcode");
foreach ($form_elements as $element) {
    if (!isset($_POST[$element]) || isempty($_POST[$element])) {
        //...
    }
}

Of course, if all isempty() does is use empty(), then one might as well just check if empty($_POST[$element]).

unreal128

These are all great ways to evaluate POST variables, thanks guys. I can now move forward and bang my head on another upcoming issue. 😃