doesnt iterate

jorge_c

Hi,

I'm trying to do write a multiple update routine but its not looping , just runs once and stops.
Can some one help please ?

TIA

if ($REQUEST_METHOD=="POST")
{
if (isset($num)){
$i=0;
while ($i<=$num){
($result = mysql_query ("UPDATE data SET valid = '$valid' WHERE id = '$id' "));
$i++;
}
echo ("<P><center> Successfully validated<center></P>\n");
}
}
else

  {.....

BTW, $num is valid and comes from data in other part of the script.

Rodney_H_

You didn't say where you are getting the variables, so I have to assume they are being submitted from your form. If so, this might help you:

<?php
// $num is already defined:

if(isset($_POST['submit'])){
     // convert posted values to variables
	$valid = $_POST['valid'];
	$id = $_POST['id'];

 // SQL statement
$sql = "UPDATE data SET valid = '$valid' WHERE id = '$id' "

 // set counter
$i=0;
while ($i <= $num){
	$result = mysql_query($sql) or die('Could not Execute Query: ' . mysql_error());
	$i++;
}
echo '<p style="align:center;">Successfully validated</p>' . "\n";
}
?>

toxic_brain

while ($i<=$num){ 
($result = mysql_query ("UPDATE data SET valid = '$valid' WHERE id = '$id' ")); 
$i++; 
}

i didn't get why u r executing the same sql for several times !

u may need something like WHERE id='$i'

justsomeone

Or better yet, you could do something like:

$result = mysql_query ("UPDATE data SET valid = '$valid' WHERE id < '$num' ");

This gets rid of the loop from PHP and stops you making multiple expensive database calls.