[RESOLVED] What is wrong with this simple expression?

[TNchatmonk]

I can't get my logic to fall through the "if" statement highlighted below. I have even hard coded the value "us" above the routine to ensure it is the value. When I echo $country at the very end of the routine before I return, $country contains the value "us"

What am I missing? Thanks!

/*******************************************************/
// Begin USPS Insurance functions
/*********************************************************/

function getUSPSIns($cart_total,$total_number_of_items,$destCountryCode) {
global $iso_countries_local,$usps_countries,$USPS_Server,$MailTypeCode;
global $PackageCount;
global $PackageData;

$maxins = 5000.00;
$usps_ins = 0.00;
$country = "us";

$USPS_INS1 = 1.30;  /* US/Canada insurance total up to $50*/

$USPS_INS2 = 2.20;  /* US/Canada insurance for totals $50.01-$100*/

$USPS_INS3 = 1.00;  /* US/Canada for every $100 over $100 add $*/

$USPS_INS4 = 1.85;  /* International insurance total up to $50*/

$USPS_INS5 = 2.60;  /* International insurance for totals $50.01-$100*/

$USPS_INS6 = 1.00;  /* International for every $100 over $100 add $*/  

$cart_total = get_paypal_cart_total();
if(!empty($_GET['ship_insured'])){  
   $packageValue = $cart_total;
}
else{
	$packageValue = 0.00;
	return $usps_ins; 

[COLOR=Red]if (($country == "us") or ($country == "ca")){
	if ($packageValue<=50) {
		$usps_ins=$USPS_INS1;}
	else if ($packageValue<=100) {
		$usps_ins=$USPS_INS2;}
	else {
		$usps_ins = $USPS_INS2 + ((ceil($packageValue/100) - 1) * $USPS_INS3); }[/COLOR]
	}	
else{
	if ($packageValue<=50) {
		$usps_ins=$USPS_INS4;}
	else if ($packageValue<=100) {
		$usps_ins=$USPS_INS5;}
	else {
		$usps_ins = $USPS_INS4 + ((ceil($packageValue/100) - 1) * $USPS_INS6); }
	}
}


return $usps_ins;

}

/*******************************************************/
// End USPS Insurance functions
/*********************************************************/

[bpat1434]

You're not changing the value of $country anywhere in that function. All you're doing is checking to see if it is equal to "us" or "ca". What are you trying to do that it won't do, or you can't get it to do? Explain your logic.

If you're saying that it won't enter the if() statement, then I would say change it to be:
if($country == 'us' || $country == 'ca'){
first to see what happens.

~Brett

[paulnaj]

Hi there,

Do yourself a favour and organise your code properly (indentation etc.)

Seems there's a glaring error once you do!

<?php
function getUSPSIns($cart_total,$total_number_of_items,$destCountryCode) {
	global $iso_countries_local,$usps_countries,$USPS_Server,$MailTypeCode;
	global $PackageCount;
	global $PackageData;
	$maxins = 5000.00;
	$usps_ins = 0.00;
	$country = "us";

$USPS_INS1 = 1.30; /* US/Canada insurance total up to $50*/
$USPS_INS2 = 2.20; /* US/Canada insurance for totals $50.01-$100*/
$USPS_INS3 = 1.00; /* US/Canada for every $100 over $100 add $*/
$USPS_INS4 = 1.85; /* International insurance total up to $50*/
$USPS_INS5 = 2.60; /* International insurance for totals $50.01-$100*/
$USPS_INS6 = 1.00; /* International for every $100 over $100 add $*/

$cart_total = get_paypal_cart_total();
if(!empty($_GET['ship_insured'])){
	$packageValue = $cart_total;
} else {
	$packageValue = 0.00;

	// This looks like your problem!!
	return $usps_ins;

	if(($country == "us") or ($country == "ca")){
		if($packageValue <= 50){
			$usps_ins = $USPS_INS1;
		} else if($packageValue <= 100){
			$usps_ins = $USPS_INS2;
		} else {
			$usps_ins = $USPS_INS2 + ((ceil($packageValue/100) - 1) * $USPS_INS3); 
		}
	} else {
		if ($packageValue <= 50) {
			$usps_ins = $USPS_INS4;
		} else if ($packageValue <= 100) {
			$usps_ins = $USPS_INS5;
		} else {
			$usps_ins = $USPS_INS4 + ((ceil($packageValue/100) - 1) * $USPS_INS6); 
		}
	}
}
return $usps_ins;
} 
?>

Paul 😉

[TNchatmonk]

Thanks paulnaj,

My code is not that ugly, I just don't know how to paste it to the forum and keep it in tact!

My problem was I wanted to fall through if !empty instead of empty and I didn't need that extra return. The below along with taking out the return fixed the problem.

$cart_total = get_paypal_cart_total();
if(empty($_GET['ship_insured'])){
$usps_ins = 0.00;
} else {

Thanks so much for your help as sometimes you can't see the forest for the trees!