Notice: Undefined variable: submit

Pryach

<html>
<head><title></title></head>

<? 
if ($submit == "click"){ 
echo "Hello, $UserName"; 
} 
else{ 
echo ' 
<html><body> 

<form method="post" action="test.php"> 

Enter Your Name 
<input type="text" name="UserName"></input><br> 

<input type="submit" name="submit" value="click"></input> 

</form> 

</body></html> 
'; 
} 

?>

When I load the page it tells me

Notice: Undefined variable: submit in C:\websites\test.php on line 4

When I click submit, it just clears the form and gives me the error again.

PHP 5.0.5
IIS 5.0

This works on my Linux setup with Apache but not my windows setup with IIS. Any idea why?

drew010

the php.ini directive [man]register_globals[/man] is most likely off which would cause the problem.

the proper code would be

if ( isset($_POST['submit']) && $_POST['submit'] == "click" ) {

[man]isset[/man] checks to see that the variable exists, and if it does it then checks to see if its equal to 'click'.
when you first visit the page, it doesnt exist so php generates a warning, since display_errors is turned on, and the error_reporting is set to show warnings.

qolbu

I assuming you're using register_global on, so make it OFF 🙂.

and for your problem you can use isset maybe, eg:

<?php
/* for register_global on if (isset($submit) && ($submit == 'click')){
* but better you start using coding with register global off :D
*/
if (isset($_POST['submit']) && ($_POST['submit'] == 'click'))
{
     echo "hello ," . $_POST['UserName'];
}
else {
<html><body> 

<form method="post" action="test.php"> 

Enter Your Name 
<input type="text" name="UserName"></input><br> 

<input type="submit" name="submit" value="click"></input> 

</form> 

</body></html> 
'; 
}
?>

or, to avoid seeing notice error you can edit php.ini to :

;   - Show all errors, except for notices
;
error_reporting = E_ALL & ~E_NOTICE

hope that help.

PS: oops, i don't see drew post sorry.

Pryach

Thanks.

Rodney_H_

Pryach wrote:
Register Globals was off. I'll try either turning it on or using $_POST.

Thanks.

Keep it off. Use POST. It's safer.

Pryach

Even if being used on an intranet site with no outside access?

thorpe

yes, register globals is bad. change your code, and get in the habbit of using $_POST.