Switch statement problem

[Sul]

Not really new to PHP.. but seems like a very simple problem and I just can't see why this isn't working at the moment:

function switchfntxt()
{
  switch($txt)
  {
   case "foo":
     echo "bar";
     break;

   case "bar"
     echo "foo";
     break;
   }
}

switchfntxt();

I'm getting nothing from calling the function and not sure why.. 😕

[subwayman]

With the code here there is no value assigned to $txt so there is no match in ther switch statement as it does not have a default outcome. As a rule of thumb ALWAYs have a default clause in a swtich statement. Saves a ny a mount of confusion when things don't work. Try the follwing:

function switchfntxt($txt)
{
switch($txt)
{
case "foo":
echo "bar";
break;

case "bar"
echo "foo";
break;
}
}

switchfntxt('foo');

[Sul]

Oh - forgot to say, you can assume that $txt has been assigned somewhere outside the function. I still have to pass in the arguement though I think, I'll try that and see how it goes. Thanks.

Works now, thanks.

[subwayman]

Or you can let the function know about $txt by declaring it as global in the function:

function switchfntxt() {

global $txt;

switch($txt) {

   case "foo": 
         echo "bar"; 
         break; 

   case "bar":  
         echo "foo"; 
         break;

   default:      
         echo "Something is wrong:$txt<BR>";
         break;

}
}

switchfntxt();

Note the defualt clause. Better in than out....