Two Include() Warnings - Why? - PHPBuilder Forums

Two Include() Warnings - Why?

Shotster

I'm simply wanting to include a remote file and display a single error message if there's a problem/warning. I then want the script to continue. The problem is getting just a SINGLE message to display. PHP seems to issue two warnings that state basically the same thing. My custom error handler is invoked each time, so two messages get displayed. Here's my code:

<?php
include('../scripts/errors.php');

include('http://some.resource.that/timesout.html');
?>

The errors.php file is as follows:

<?php
function handleIncludeError($errno, $errstr, $errfile, $errline)
{
print("Resource Temporarily Unavailable\n");
}

$oldHandler = set_error_handler("handleIncludeError");
?>

Why does PHP issue two warnings and thus causes my message to appear twice? And more importantly, how can I get it to display just once?

Thanks for any help,

Steve

subwayman

Are you sure there are not two errors being triggered? You are trying to include two files. If php can't find either of them it will call your erro handler twice. If you don;t want this to happen why not get your error handler to terminate the script on first call?

Shotster

subwayman wrote:
Are you sure there are not two errors being triggered? You are trying to include two files. If php can't find either of them it will call your erro handler twice. If you don;t want this to happen why not get your error handler to terminate the script on first call?

Thanks for your quick reply. No, they are warnings, and it's only a single file I'm including. Here are the warnings:

Warning: main(http://some.resource.that/timesout.html): failed to open stream: Connection timed out in /home/shotster/public_html/testjunk/servererror_test.php on line 21

Warning: main(): Failed opening 'http://some.resource.that/timesout.html' for inclusion (include_path='.:/usr/lib/php:/usr/local/lib/php:/usr/local/cpanel/3rdparty/lib/php') in /home/shotster/public_html/testjunk/servererror_test.php on line 21

Is there any way to output just a single message when only the first warning occurs? I've tried implementing a flag that indicate the message has already been printed, but that doesn't work. It always prints the message twice - once for each warning occurrence. I just don't get it.

Thanks,

Steve

subwayman

Try:

function handleIncludeError($errno, $errstr, $errfile, $errline)
{
exit("Resource Temporarily Unavailable\n");
}

Shotster

subwayman wrote:
Try:

function handleIncludeError($errno, $errstr, $errfile, $errline)
{
exit("Resource Temporarily Unavailable\n");
}

I tried that initially. The problem then is that the rest of the page after the PHP block doesn't get output. In other words, everything is aborted with a call to 'exit'. That's why my initial post said that I "want the script to continue". There has got to be a simple way to do this, no?

Thanks again,

Steve

subwayman

As these are warnings you could set the error reporting level to ignore them.

Shotster

subwayman wrote:
As these are warnings you could set the error reporting level to ignore them.

Yeah, but whole point is that I WANT to notify the user that the resource isn't available, but I want to do it in a more friendly manner than a raw PHP warning, and I also don't want to do it twice. I could also just use the '@' to ignore them, but that's not the solution I'm after. That's why I say the crux of the issue is that PHP is issuing two warnings for seemingly the same problem - i.e. the file couldn't be included.

Hmm, I just thought of something clever that might work. I'm going to try it and report back...

Shotster

Shotster wrote:
Hmm, I just thought of something clever that might work. I'm going to try it and report back...

JavaScript to the rescue! Here's the simple change I made to the errors.php file to get my message output only once:

<?php
echo "<p id=\"errMsg\"></p>\n";
function handleIncludeError($errno, $errstr, $errfile, $errline)
{
	$msg = 'Resource Temporarily Unavailable';
	echo "<script type=\"text/JavaScript\">document.getElementById('errMsg').innerHTML='$msg';</script>\n";
}

$oldHandler = set_error_handler("handleIncludeError");
?>

Well ok, it is of course still output twice by the server, but a touch of client-side JS ensures the user sees it only once. And by simply editing a style sheet, I can alter the appearance of the message box on a per-page basis. Being a JS guru, I don't know why this didn't occur to me sooner. Anyway, my entire site relies on JS, so using client-side scripting is not an issue. In fact, it's preferred. I resort to PHP only when I have to.

Thanks for the input. I wanted to make sure I wasn't overlooking some obvious server-side solution.

Regards,

Steve

madwormer2

Erm, you could find an easier way by doing:

<?php
function handleIncludeError($errno, $errstr, $errfile, $errline)
{
if($error_done == 1){
print("<p>Resource Temporarily Unavailable</p>\n");
$error_done = 1;
}
}

$oldHandler = set_error_handler("handleIncludeError");
?>

Erm, ya.

Shotster

madwormer2 wrote:

Erm, you could find an easier way by doing:

<?php
function handleIncludeError($errno, $errstr, $errfile, $errline)
{
if($error_done == 1){
print("<p>Resource Temporarily Unavailable</p>\n");
$error_done = 1;
}
}

$oldHandler = set_error_handler("handleIncludeError");
?>

Erm, ya.

Erm, tried that, wormie - except I used a boolean flag instead of an integer (as I stated in one of my posts here). Didn't work for me. I don't understand why, but it didn't.

Thanks for the suggestion though...

Steve

madwormer2

global $error_done;

😛

Shotster

madwormer2 wrote:
global $error_done;

Well, unlike your example, my flag was "declared" outside the function definition, so it's not clear why I would have to declare it "global". The docs say that included files inherit the scope of the script in which they're included, so it should have worked, but it didn't.

At any rate, I'll stick with what I have. It works. Thanks though.

Steve

Shotster

madwormer2 wrote:
global $error_done;

Aha! Thanks for forcing me to read the docs! I now see that, unlike C and virtually every other language I've used, global vars are not automatically accessible to functions unless explicitly declared such with the 'global' keyword.

Yeah, I realize this is probably PHP 101, but hey I've only needed a handful of functions on my site so far. Anyway, I've completely revamped my solution, but I do use the 'global' keyword now.

Thanks,

Steve

madwormer2

lol, glad i could help 😛