having problem in fopen() ,feof() and fread(): please help

dennyx

Hi all

I am having a small problem in my code. This piece of code get the site html data in an array. its working fine but when the url gets wrong I mean if changed the its start loading an infinite loop of errors.

Please let me know what will be the solution if I teminate the script when error found in url etc.

$urlmy="http://127.0.0.1/mypage.hml";

preg_match("/^(https?:\/\/)?([^\/]*)(.*)/i", "$myurl", $mymatches);
$mydomain = "http://" . $mymatches[2];
$mypage = $mymatches[3];

$getopen = fopen($mydomain.$mypage, "rb");
$code = "";
while(!feof($getopen)){
	$mycode .= fread($getopen, 4096);	
}
fclose($getopen);

The looping problem came when its try to open the url and not found ($getopen = fopen($mydomain.$mypage, "rb")😉 and unable to start the while loop. for example if I write mypageddddddd.hml instead of mypage.hml and (mypageddddddd.hml) is not availabl at the above mentioned url.

Below is the erro that i am getting if I put the wrong html url.

Warning: fopen(http://127.0.0.1/mypage.hml): failed to open stream: HTTP request failed! HTTP/1.1 404 Not Found in c:\apache\www\mypage.hml on line 7

Warning: feof(): supplied argument is not a valid stream resource in c:\apache\www\mypage.hml on line 9

Warning: fread(): supplied argument is not a valid stream resource in c:\apache\www\mypage.hml on line 10

Weedpacket

Warning: fopen(http://127.0.0.1/mypage.hml): failed to open stream: HTTP request failed! HTTP/1.1 404 Not Found in c:\apache\www\mypage.hml on line 7 You've never seen a 404 error before?

Anyway, let's see what The Manual has to say about what happens [man]fopen[/man] can't open a file:

If the open fails, the function returns FALSE and an error of level E_WARNING is generated. You may use @ to suppress this warning.

And of course if the file can't be opened, there's no point trying to see if it's finished or reading from it.

justsomeone

Only open your while loop if you've successfully opened the file. Otherwise you've created an infinite loop for yourself...


if ($getopen = fopen($mydomain.$mypage, "rb")){
    $code = "";
    while(!feof($getopen)){
	$mycode .= fread($getopen, 4096);	
    }
    fclose($getopen);
}

dennyx

Thanks for your help guys.
Offcuse I have seen the 404 error and I know whats it mean, I was just trying to explain the error and things in good way. If you feel that sits not a good way to explain thinsg I am sorry.

any way thanks for the help