error check

scrypte

trying to establish if something is already in the database and if so display various graphics.

// check pending friends
   $sql = "SELECT * FROM friends WHERE userid_1='$userid' && status='1'"; 
   $result = @mysql_query($sql) or die("couldn't execute query  $sql.".mysql_error()); 
   while($row = mysql_fetch_array($result)) { 
      $id1=$row{'userid_1'}; 
      $id2=$row{'userid_2'}; 
   $sqlb = "SELECT * FROM friends WHERE userid_2='$userid' && status='1'"; 
   $resultb = @mysql_query($sqlb) or die("couldn't execute query  $sql.".mysql_error()); 
   while($row = mysql_fetch_array($resultb)) { 
      $id3=$row{'userid_1'}; 
      $id4=$row{'userid_2'}; 
   }
}
// check current friends
   $sqlc = "SELECT * FROM friends WHERE userid_1='$userid' && status='2'"; 
   $resultc = @mysql_query($sqlc) or die("couldn't execute query  $sqlc.".mysql_error()); 
   while($row = mysql_fetch_array($result)) { 
      $id5=$row{'userid_1'}; 
      $id6=$row{'userid_2'}; 
   $sqld = "SELECT * FROM friends WHERE userid_2='$userid' && status='2'"; 
   $resultd = @mysql_query($sqld) or die("couldn't execute query  $sqld.".mysql_error()); 
   while($row = mysql_fetch_array($resultd)) { 
      $id7=$row{'userid_1'}; 
      $id8=$row{'userid_2'}; 
   }
}
if ($userid == $id1) {
echo "<img src=images/addfriendpending.gif border=0><p>\n";
} else {
if ($userid == $id3) {
echo "<img src=images/addfriendpending.gif border=0><p>\n";
} else {
if ($userid == $id5) {
echo "<img src=images/addfriendcurrent.gif border=0><p>\n";
} else {
if ($userid == $id7) {
echo "<img src=images/addfriendcurrent.gif border=0><p>\n";
} else {
echo "<a href=viewprofile.php?id=$id&addme=true><img src=images/addfriend.gif border=0><p>\n";
}

If this is just completely retardedly done please let me know how to fix it please

qadeer_ahmad

Thier are two things looking some wrong
1. if (userid_1='$userid') userid is integer value then it shuld be like this
(userid_1=$userid) same as status.
2. your last if else block is also confusing use like this

if ($userid == $id1) 
{ 
	echo "<img src=images/addfriendpending.gif border=0><p>\n"; 
} 
else if ($userid == $id3)
{ 
	echo "<img src=images/addfriendpending.gif border=0><p>\n"; 
} 
else if ($userid == $id5) 
{ 
	echo "<img src=images/addfriendcurrent.gif border=0><p>\n"; 
} 
else if ($userid == $id7) 
{ 
	echo "<img src=images/addfriendcurrent.gif border=0><p>\n"; 
} 
else 
{ 
	echo "<a href=viewprofile.php?id=$id&addme=true><img src=images/addfriend.gif border=0><p>\n"; 
}

scrypte

the table is setup as so

userid_1: requesting party
userid_2: approving party
status: 1=pending
status: 2=approved

the $userid variable is set by cookie upon login
the $id variable is set by fetching the users userid in the table

here is the coding:

// check pending friends 
   $sql = "SELECT * FROM friends WHERE userid_1='$id' AND status='1'";  

   $result = @mysql_query($sql) or die("couldn't execute query  $sql.".mysql_error());  

   while($row = mysql_fetch_array($result)) {  

      $id1=$row{'userid_1'};  // fetch id of requesting party
      $id2=$row{'userid_2'};  // fetch id of party requested
   }
// check current friends 
   $sqlc = "SELECT * FROM friends WHERE userid_1='$id' && status='2'";  

   $resultc = @mysql_query($sqlc) or die("couldn't execute query  $sqlc.".mysql_error());  

   while($row = mysql_fetch_array($result)) {  

      $id3=$row{'userid_1'};    // fetch id of requesting party
      $id4=$row{'userid_2'};    // fetch id of approving party
   } 

if ($id == $id2)  {  // check if friend pending
    echo "<img src=images/addfriendpending.gif border=0><p>\n";  

}  else if ($userid == $id3 && $id == id4)  {  // check if approved by userid
    echo "<img src=images/addfriendcurrent.gif border=0><p>\n";  

}  else if ($userid == $id4 && $id == id3)  {  // check if approved by id 
    echo "<img src=images/addfriendcurrent.gif border=0><p>\n";  

}  else if ($userid == $id)  {   // check if self
    echo "<p>\n";  

}  else  {  

    echo "<a href=viewprofile.php?id=$id&addme=true><img src=images/addfriend.gif border=0></a><p>\n";  

}

for some reason the only one that works is the check if self

qadeer_ahmad

ok if these all numeric fields then use queries like this

$sql = "SELECT FROM friends WHERE userid_1=$id AND status=1";

$sqlc = "SELECT FROM friends WHERE userid_1=$id && status=2";

I hope it will solve your problem.

scrypte

nah that didnt make a bit of difference

thanks though

unreal128

Unrelated to your prime objective but I would scratch the die method that you use. By showing the SQL query, you are revealing your database schema to the end user. Instead you should just show the mysql_error that is a text portion at a redirect page. So you could create a generic error page that transmits the error code by errorpage.php?error=$sqlerrormsg.

Back to your main issue. To eliminate duplicate work, I would compact it into a function like.

queryFriends($id, $status)
{
    $sqlquery = 'SELECT * FROM `friends` WHERE `user_id`= "'.$id.'" AND `status`="'.$status.'"';
    $sqlresult = @ mysql_query($sqlquery,$connection) || die('however you want to do this');
    $row = mysql_fetch_array($sqlresult)
    $queryids[0] = $row['userid_1'];
    $queryids[1] = $row['userid_2'];
    return $queryids;
}

Then you could call it like...

$friends_pending = queryFriends($id, "1");
$friends_approved = queryFriends($id, "2");

As far as the many else if statements, I would use a switch statement instead since this will trim down on excessive code. I would help out with the later part of the code but I am really tired and am having a hard time backtracking what id1-4 means. For my sake, could you rename the id variables to words instead of numbers so I can understand it easier? I will in return show you how I would do it if that helps. A little background on what the fields in the friends table are would help too.