include help

Tobeon

I was wondering how you can use include with the GET function so that...

www.test.com/test.php?click=01.php

would make the page include 01.php

<?php
$_GET["click"];
include $click;
?>

somthing like that.. I have tried lots of variations but cant seem to get it to work, can anyone help?

madwormer2

include($_GET['click']);

I wouldn't reccomend it though, its a big security risk.

Consider using switch instead

bpat1434

If you are not going to consistently use "click" as your GET variable, I would suggest you look at the code (second grouping) in my article and modify it to your needs:
http://phpbuilder.com/columns/patterson20051018_2.php3

~Brett

Tobeon

thanks v much 🙂

just one other quick question, how can you put a . in
e.g.

include($_GET['click'].php);

laserlight

include $_GET['click'] . '.php';

That said, this is rather insecure. You should first check that $_GET['click'] exists by using [man]isset/man or [man]empty/man, and then validate it. One way to validate is to place the expected values in an array, and check if the value of $_GET['click'] is in that array.

subwayman

No, definitely not a good idea. Use a switch . Your implementation makes it far too easyt for someone to randomly spoof any of your php.

pblancher

Do NOT do this. On a friend's site, he did this so it would switch .inc files. It opened up a whole big security hole on his server allowing for the $_GET to include an off site PHP code that allowed access to the server. Mind you the security wasn't great on that server, it still wasn't pretty. 30 sites with the content wiped for some greeting from a brazillian IRC chat list.

Go with a switch!

Weedpacket

I prefer laserlight's array suggestion; the array can be constructed at runtime if desired, but the switch would be reconstructed by hand every time there's a change.

Plus, the array could be associative, with the value from $GET['click'] being the key and the real name being the value: if(isset($pages[$GET['click']])) include $arrays[$pages[$_GET['click']];