[RESOLVED] link from a query result?

[jmartinez]

I am sure this is possible just not sure how to do it. I am using this code to display a query result

<?
include("dbinfo.inc.php");
mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die( "Unable to select database");
$sql = 'SELECT *FROM `invoices` ORDER BY `id` DESC LIMIT 0, 100 ';
$result=mysql_query($sql);

$num = mysql_numrows($result); 

mysql_close();

echo "";

?>
<?
$i=0;
while ($i < $num) {
$date=mysql_result($result,$i,"date");
$id=mysql_result($result,$i,"id");
$status=mysql_result($result,$i,"status");
$billto=mysql_result($result,$i,"billto");
$total=mysql_result($result,$i,"total");
?>
<div align="center">
<table border="0" width="700">
	<tr>
		<td width="140" align="left"><? echo "$id"; ?></td>
		<td width="140" align="left"><? echo "$date"; ?></td>
		<td width="140" align="center"><? echo "$billto"; ?></td>
		<td width="140" align="right">$<? echo "$total"; ?></td>
		<td width="140" align="right"><? echo "$status"; ?></td>
	</tr>
	</div>

<?
++$i;
} 
echo "</table>";
?>

what I am wanting to do is create a link from the <? echo "$id"; ?> tag to a preformated invoice style output for that respective id "invoice" number. I am not quite sure how to do this. Any help would be greatly appriciated.

Thanks in advance,
Josh

[subwayman]

I have rewritten your code:

<?php
include("dbinfo.inc.php");
mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die( "Unable to select database");
$sql = 'SELECT *FROM `invoices` ORDER BY `id` DESC LIMIT 0, 100 ';
$result=mysql_query($sql);

$num = mysql_numrows($result); 
?>

<div align="center">
  <table border="0" width="700">

<?php 
for ($rowcount = 1; $rowcount <= $ num, $rowcount++) {

$row_data = mysql_fetch_array($result);
?>

<tr>
   <td width="140" align="left"><?php echo $row_data['id']; ?></td>
   <td width="140" align="left"><?php echo $row_data['date']; ?></td>
   <td width="140" align="center"><?php echo $row_data['billto']; ?></td>
   <td width="140" align="right">$<?php echo $row_data['total']; ?></td>
   <td width="140" align="right"><?php echo $row_data['status']; ?></td>
</tr>

<?php } ?>

  </table>
</div>

<?php mysql_close(); ?>

Not note only the change in structure from a while to a for (and removing the use of $i - try to use menaingful name everywhere). But also that some bits have moved around. Oringnally, your code had a table tag in every iteration of your loop. You had also closed the mysql connetion before needing it in the loop. I have also only used php to echo the dynamic elements of the html.

[jmartinez]

I appriciate the help as I am brand new to both MySQL and PHP and some of this is hard to understand. I used the code you have rewrote and get this error when viewing the page.

Parse error: parse error, unexpected T_STRING, expecting T_VARIABLE or '$' in view.php on line 15

that row is
for ($rowcount = 1; $rowcount <= $ num, $rowcount++) {

[subwayman]

sorry typing too fast with the laptop actually on my lap....

remove the space between $ and num

[jmartinez]

I removed the space and now get this error

Parse error: parse error, unexpected ')', expecting ';' in view.php on line 15

however this really is not the original issue just an error in the code somewhere, the original post was

what I am wanting to do is create a link from the <? echo "$id"; ?> tag to a preformated invoice style output for that respective id "invoice" number. I am not quite sure how to do this. Any help would be greatly appriciated.

[subwayman]

<td width="140" align="left">
<a href= "invoice.php?invoiceid=<?php echo $row_data['id']; ?>><?php echo $row_data['id']; ?>
</td>

This assumes that your invoice page is invoice.php and that it knows which invoice to display by the query string invoiceid=$row_data['id']. And before you ask the invoice page would get the id by using $_GET['invoiceid'].

[jmartinez]

ahh haa, ok I will run with this thanks!!