if / else logic trouble = unexpected }

ATS16805

this is a page from an app that i took a break from a few weeks ago-- largely in part due to the trouble i'm having w/ this page. i've put a lot of time into trying to get it to work right, but there is obviously something very basic yet essential i'm missing here. i hope that if you find it you might be able suggest something for me to study so i don't make the same mistake again. is it my interpretatioin of the if / else function? thanks!

<?php
$artid = $_GET['var'];
$var2 = $_GET['var2'];
global $artid; 
global $var2;


$datesoutput = '';
$datesoutput2 = '';
$datesoutput3 = '';
$formatted_date = '';
$conn = mysql_connect("localhost", "private", "private") or die(mysql_error());
mysql_select_db("cb_shows1", $conn) or die(mysql_error());

$checkinids = "SELECT show_date FROM concerts WHERE $artid IN (artist_id1, artist_id2, artist_id3)";
$checkinres = mysql_query($checkinids, $conn) or die(mysql_error());
$checkinnum = mysql_num_rows($checkinres) or die(mysql_error());

if ($checkinnum == 0 ) { 
   echo $checkinres;
   echo "Sorry, no Concerts Scheduled for $var2";


   } else if ($checkinnum >= 1); {

$htmlblock = "<h2>Performance Dates Scheduled:";

function getdates() {
	global $conn;
	$seldates = "SELECT DATE_FORMAT(show_date, '%W, %M %D, %Y') AS formatted_date FROM concerts where artist_id1 =$_GET[var] order by show_date";
	$datesres = mysql_query($seldates, $conn) or die(mysql_error());
	return $datesres;
	}

function getdates2() {
	global $datesres2;
	global $conn;
	$seldates2 = "SELECT DATE_FORMAT(show_date, '%W, %M %D, %Y') AS formatted_date FROM concerts where artist_id2 =$_GET[var] order by show_date DESC";
	$datesres2 = mysql_query($seldates2, $conn) or die(mysql_error());
	return $datesres2;
	}

function getdates3() {
	global $datesres3;
	global $conn;
	$seldates3 = "SELECT DATE_FORMAT(show_date, '%W, %M %D, %Y') AS formatted_date FROM concerts where artist_id3 =$_GET[var] order by show_date DESC";
	$datesres3 = mysql_query($seldates3, $conn) or die(mysql_error());
	return $datesres3;
	}

$datelist1 = getdates();
$datelist2 = getdates2();
$datelist3 = getdates3();	


	$datesArray1['formatted_date'] = '';

while ($datesArray1 = mysql_fetch_array($datelist1)) {	
	$datesoutput = $datesArray1['formatted_date'].=" $datesoutput ";


}

while ($datesArray2 = mysql_fetch_array($datelist2)) {
	$datesoutput2 = $datesArray2['formatted_date'].=" $datesoutput2 ";

}

while ($datesArray3 = mysql_fetch_array($datelist3)) {
	$datesoutput3 = $datesArray3['formatted_date'].=" $datesoutput3 ";

}

$datesblock = $datesoutput." ".$datesoutput2." ".$datesoutput3


}
?>
<html>
<head>
<title>List of performance dates for<?php echo $var2; ?></title>
<link rel="stylesheet" type="text/css" href="css/php.css" />
</head>
<body>
<?php 

echo $htmlblock;
echo "$datesblock<br>"; 

?>
</body>
</html>

i have actually applied another level of normalization to the database which serves this app, but i think i should figure out what's going wrong here before i start to route my data to and from my new table. thanks again!

Roger_Ramjet

It's ELSEIF not ELSE IF

I guess what you are after is IF/ELSE not IF/ELSEIF cos I don't see what the 3rd option would be, unless it's a negative number, ie <0, and the normal program logic flow would be IF/ELSEIF/ELSE

homchz

Just becasue I do not know and have wondered the same.

will ELSE by iteself allow you conditions or is it just the opposite of the IF condition?

I though if there were specific conditions you needed ELSE IF.

Roger_Ramjet

IF/ELSE does what it does in every language
IF condition is true - do this
ELSE (ie condition is false) do that.

If you want to have
IF condition 1 is true then do this
ELSE, IF condition 2 is true then do that
the you need IF/ELSEIF .... AND YOU WRITE 'ELSEIF' NOT 'ELSE IF' with a space - again like every language - as I pointed out in my first post

What I don't see is where elseif fits into your logic on this specific script

If $checkinnum = 0 do this
if $checkinnum > 0 do that
WHAT ELSE IS LEFT except less than zero, ie a negative number, but I guess yours are unsigned integers so less than zero never happens, so all you have are 2 possible conditions zero, and if not then it must be greater than zero.
Or absent of course but you should have tested for the existance of the variable before you tried to use it, cos a missing var will break your script anyway.

ATS16805

cool. thanks for clearing that up for me. i don't know where i ever got the "else if" bit (w/ the space, that is)-- somewhere along the lines, i ended up believing that they did the same thing in php-- and the correct (apparently), "elseif" was merely a matter of preference, not unlike print and/ or echo. i do understand now more clearly about the condidtions.

my problem is, i am too unsure of myself, so i'll put something like elseif in where i know it should have been only "else". i'm sure this script started out for me using else, then in my attempts under the horribly erroneous philosophy of "the more stuff i try the sooner it might work", is likely how that got there-- i dont know what was going on here really, but i opened it up in PHPEclipse, and i fixed the } at the bottom... wait, it appears to reflect that fix in what i've submitted here. i'm sorry-- i'm not positive which version this is! hmph. :o

anyway, i wish i could have got back here sooner-- let's scrap this for now, and i'll post my revised script which reflects my revised schema... here in a little while as soon as i work it out. thanks for the prompt reply! ha! it's my luck that i get a lot of feedback just when i'm not even goingn to use that script anymore! ugh!@

it hasn't been for naught-- i have leaned something here! (elseif proper syntax!)

Rodney_H_

To clear things up... elseif

PHP.net wrote:
In PHP, you can also write 'else if' (in two words) and the behavior would be identical to the one of 'elseif' (in a single word).

ATS16805

ahhh. so, "else if" is acceptable. i knew i read that somewhere!
thanks for adding that clarification!!

the reason i had been using (at least at this stage of my game) "else if" over "elseif", is that it helps me to break down the logic. i can look at it, think about the conditions, then consider "if the preceding statement holds true, [or] else, if the following statement holds true..."
which for whatever reason helps me to see it, if even 1% more clearly.

i realize that "elseif" makes for cleaner looking code, and probably more easily debugged code as well.

Roger_Ramjet

Did not know that 'else if' worked in php - never come across it before. Personally I'm much more used to VB & VBA so it's just a coding habit I have.