[RESOLVED] If and else question

dalty52

I made a simple e-mail for with a yes and no button. When the info is sent to my e-mail I want it to tell me if the person clicked "yes" or "no". The .php I am trying to use is this:

if ($list == "&listno")
$mailinglist = "no\n";
else $mailinglist = "yes\n";

This is the section where I tell the e-mail what to printout:
From: $visitor ($visitormail)\n
Subject: $subject \n
Message: $notes \n
Mailing list: $mailinglist \n

The problem is that the $mailinglist printout always reads "yes", even if the button has been clicked "no". I'm not sure if I set up the If and Else command correctly. Thanks for your help.

Weedpacket

$mailinglist would always contain "yes\n" if $list is never equal to "&listno". So .... what is the value of $list?

justsomeone

Umm...

if ($list == "&listno")

looks very suspect.

If you have a get variable called "list" you can access it using the variable name $_GET["list"] the value will be whatever you set in the form.

dalty52

Ok, here is where list is defined:

Would you like to be added to my mailing list? <br>
No<input name="list" type="radio" value="listno" />

Yes<input checked="checked" name="list" type="radio" value="listyes" />

This is in a form section in the regular file for the contact page. This form is linked to a file which contains what I gave above. Obviously, there is more to the code than these snippets, but I think the problem lies within these lines:

if ($list == "&listno")
$mailinglist = "no\n";
else $mailinglist = "yes\n";
$message = " $todayis [CST] \n
From: $visitor ($visitormail)\n
Subject: $subject \n
Message: $notes \n
Mailing list: $mailinglist \n

Basically, when the person clicks on the "no" radio button, I want mailing list to equal a printout of "no", and vice-versa. Thanks for your help.

justsomeone

Yes the problem is in those lines. In fact there could be a couple of problems.

1
$list will only be set if the php.ini setting REGISTER_GLOBAL_VARIABLES is set to true. It shouldn't be, as this is a major security risk. instead of testing the value of $test, use $_POST['list'] (assuming that your form is POSTed).

2
Neither of the options in your form sets this variable to "&listno". It will eitherbe "listno" or "listyes"

So, change

if ($list == "&listno")

if ($_POST['list'] == "listno")

and all should be well.

dalty52

Thank you! That fixed the problem. I appreciate your help!

justsomeone

Very welcome. And could you please mark the thread as resolved?