[RESOLVED] This works, but its backwards, why?

[ElectricRain]

Youre going to want to look mostly at the bottom part of this- from
//Check if user account has been verified downwards please. Ive included the rest just in case Ive missed an obvious mistake.

<? 

//prevents caching 
header("Expires: Sat, 01 Jan 2000 00:00:00 GMT"); 
header("Last-Modified: ".gmdate("D, d M Y H:i:s")." GMT"); 
header("Cache-Control: post-check=0, pre-check=0",false); 
session_cache_limiter(); 

session_start(); 

//require the functions file 
require ("config.php"); 

//clear session variables 
session_unset(); 

//make the connection to the database 
$connection = @mysql_connect($server, $dbusername, $dbpassword) or die(mysql_error()); 
$db = @mysql_select_db($db_name,$connection)or die(mysql_error()); 

$match = "select * from $table_name WHERE username = '".$_POST['username']."' AND password = '".$_POST['password']."';"; 
$qry = mysql_query($match) 
or die ("Could not match data because ".mysql_error()); 
$num_rows = mysql_num_rows($qry); 

// If no matching username and pass send back to login screen 
if ($num_rows != 1) { 
echo ("Sorry, there is no username $username with the specified password.<br> 
    <a href='login.html'>Try again</a>"); 
exit; 
} 

else { 
//Check if user account has been verified 
if (verified != "1") { 
    echo ("Your account must be activated before you can log in, please visit the 
activation page that was included in the email we sent you."); 
    exit; 
    } 
//set cookies 
setcookie("loggedin", "TRUE", time()+(3600 * 24)); 
setcookie("mysite_username", "$username"); 
echo ("You are now logged in!"); 
} 
?> 

Ok. Problem is that when the mysql database field "verified" does not equal 1, the code is setting the cookies. When it DOES equal 1 (and therefore the code SHOULD set the cookies) it throws the error re activation and quits. I think I need to rewrite the line

if (verified != "1") {

but Im not sure how? please help?

[ravnen]

try a different operator for unequality test: <>

[ElectricRain]

Speak idiot-ish, i beg of you.... seriously, im not good with php... or err.. rather knowing what operators and things are. Well err... Ive sort of got the hang of it but Im at a loss when ppl use proper terms. Please give me an example or something?

[Weedpacket]

if (verified != "1") {  

You missed the $ before "verified". But there's still a problem because I don't see where $verified (or verified, for that matter) is coming from.

I recommend when you're developing you set error reporting to E_ALL and then you'll be notified about mistakes like this.

[justsomeone]

A couple of things here...

Firstly, you're not actually processing any data from the database:

$qry = mysql_query($match) 
or die ("Could not match data because ".mysql_error()); 
$num_rows = mysql_num_rows($qry); 

At this point, $qry just contains a pointer to where the results are. You now need to extract the results. You could do this by adding the following:

else { 

//Read row from database
$row = mysql_fetch_assoc($qry)

//Check if user account has been verified 

Now, $row actually contains the data.

Your second problem is your if statement:

if (verified != "1") {  

It makes no sense as it is. The values on either side of the "!=" operator should have values. "1" certainly does have a value but "verified" doesn't.

$qry contains the details you pulled back from the database, so if that row contains a field called "verified", you ought to be able to replace "verified" in the equals statement with $row['verified'].

Putting all of that together, here is the new code to replace your old...

else { 
//Read row from database
$row = mysql_fetch_assoc($qry)

//Check if user account has been verified
if ($row['verified'] != "1") { 
    echo ("Your account must be activated before you can log in, please visit the
activation page that was included in the email we sent you."); 
    exit; 
    }  

For further reading on this, check out the mysql section of the PHP manual.

[ElectricRain]

You are my god.

I actually got as far as ($row['verified'] != "1") at one point but I deleted it because it wasnt working. Didnt realise there was another bit missing, but it makes sense NOW! thank you!

[justsomeone]

Glad I could help. Nice to see ya again too.

[ElectricRain]

Howve ya been..? long time no talk n stuff 🙂

[justsomeone]

Let's continue this off the board. 😉