[RESOLVED] preg_replace() help

[Butthead]

I have a form that will accept comma delimited values for adding addresses to the mail server.

if (isset($_POST['horvitzaddresses']) or 
					isset($_POST['kcjaddresses']) or 
					isset($_POST['miraddresses']) or 
					isset($_POST['pdnaddresses']) or 
					isset($_POST['rnaddresses']) or 
					isset($_POST['tdtaddresses']) or 
					isset($_POST['svraddresses']) ){



					$horvitzaddresses 	= explode(', ',$_POST['horvitzaddresses']);
					$kcjaddresses 		= explode(', ',$_POST['kcjaddresses']);
					$miraddresses 		= explode(', ',$_POST['miraddresses']);
					$pdnaddresses 		= explode(', ',$_POST['pdnaddresses']);
					$rnaddresses  		= explode(', ',$_POST['rnaddresses']);
					$tdtaddresses 		= explode(', ',$_POST['tdtaddresses']);
					$svraddresses 		= explode(', ',$_POST['svraddresses']);

					$horvitzaddresses 	= preg_replace( '/([a-z]*)/', '\[e-mail]', $horvitzaddresses );
					$kcjaddresses	 	= preg_replace( '/([a-z]*)/', '\[e-mail]', $kcjaddresses );
					$miraddresses	 	= preg_replace( '/([a-z]*)/', '\[e-mail]', $miraddresses );
					$pdnaddresses	 	= preg_replace( '/([a-z]*)/', '\[e-mail]', $pdnaddresses );
					$rnaddresses	 	= preg_replace( '/([a-z]*)/', '\[e-mail]', $rnaddresses );
					$tdtaddresses	 	= preg_replace( '/([a-z]*)/', '\[e-mail]', $tdtaddresses );
					$svraddresses	 	= preg_replace( '/([a-z]*)/', '\[e-mail]', $svraddresses );


					$newaddresses = array(	'main' => $mainaddresses,
											'horvitznewspapers' => $horvitzaddresses,
											'kingcountyjournal' => $kcjaddresses,
											'mireporter' => $miraddresses,
											'peninsuladailynews' => $pdnaddresses,
											'reporternewspapers' => $rnaddresses,
											'thedailytimes' => $tdtaddresses,
											'valleyrecord' => $svraddresses
										  );

					$count = 0;
					foreach ($newaddresses as $locations => $domainlist){
						foreach ($domainlist as $address => $addresslist){
							if (isset($newaddresses[main]) ){
								$info['maildrop'][$count] = $addresslist;
							}
						}
						echo "<br><br>$location - $address :  $addresslist<br><br>";
						$count++;
					}
		}

outputs this:
["maildrop"]=>
array(8) {
[0]=>
string(32) "[e-mail]"
[1]=>
string(71) "[e-mail]@[e-mail]"
[2]=>
string(70) "[e-mail]@[e-mail]"
[3]=>
string(52) "[e-mail]@[e-mail]"
[4]=>
string(73) "[e-mail]@[e-mail]"
[5]=>
string(72) "[e-mail]@[e-mail]"
[6]=>
string(58) "[e-mail]@[e-mail]"
[7]=>
string(37) "[e-mail]@valleyrecord.com"
}
}

Two things are wrong first each address should get it's own location in the array, and also the addresses are being lost.

if I put it blah, blah2, blah3 it creates [email][e-mail]@[e-mail][/email]

What am I missing here?

[Kudose]

preg_replace should be:

preg_replace( '#^([-A-Za-z_\.]+)@#', '\\[e-mail]', $kcjaddresses );

################

Thinking more on it...

$kcjaddresses = preg_replace(...);

Should be...

foreach($kcjaddresses as $key=>$addy){
  $kcjaddresses[$key] = preg_replace( '#^([-A-Za-z_\.]+)@#', '\\[e-mail]', $addy );
}

Repeat for each set of addresses.

[Weedpacket]

Actually, preg_replace can take an array as it's third argument, so that's not the problem. But I do agree that the regexp itself needs work in that it misses out many valid characters. if what is wanted is the bit before the first '@' then that would be /^[@]+/

I think one problem is lower down; $count is getting incremented after the loop where it's being used. That doesn't look right, somehow.

Finally, if I understand what $info['maildrop'] is supposed to be, then a single call to array_merge() could combine all those arrays into one.

[Butthead]

it was a combination of a bad regex, and the count being in the wrong place (D'OH!). I dunno why I missed the counter thing.

Here's the working code for posterity.

                                          $horvitzaddresses 	= preg_replace( '#^([-A-Za-z0-9_\.]*+)#', '\\[e-mail]', $horvitzaddresses );
						$kcjaddresses		= preg_replace( '#^([-A-Za-z0-9_\.]*+)#', '\\[e-mail]', $kcjaddresses );
						$miraddresses	 	= preg_replace( '#^([-A-Za-z0-9_\.]*+)#', '\\[e-mail]', $miraddresses );
						$pdnaddresses	 	= preg_replace( '#^([-A-Za-z0-9_\.]*+)#', '\\[e-mail]', $pdnaddresses );
						$rnaddresses	 	= preg_replace( '#^([-A-Za-z0-9_\.]*+)#', '\\[e-mail]', $rnaddresses );
						$tdtaddresses	 	= preg_replace( '#^([-A-Za-z0-9_\.]*+)#', '\\[e-mail]', $tdtaddresses );
						$svraddresses	 	= preg_replace( '#^([-A-Za-z0-9_\.]*+)#', '\\[e-mail]', $svraddresses );



					$newaddresses = array(	'main' => $mainaddresses,
											'horvitznewspapers.net' => $horvitzaddresses,
											'kingcountyjournal.com' => $kcjaddresses,
											'mi-reporter.com' => $miraddresses,
											'peninsuladailynews.com' => $pdnaddresses,
											'reporternewspapers.com' => $rnaddresses,
											'thedailytimes.com' => $tdtaddresses,
											'valleyrecord.com' => $svraddresses
										  );

					$count = 0;
					foreach ($newaddresses as $locations => $domainlist){
						foreach ($domainlist as $address => $addresslist){
							$info['maildrop'][$count] = $addresslist;
							$count++;
						}
						echo "<br><br>$location - $address :  $addresslist<br><br>";

					}