Problem With Arithmetic in PHP script

[latemodern]

Hi,

Can you spot the problem here?

//if own avg rent is within 50 of users avg rent then add a point
if( ( ( ($own_minrent + $own_maxrent) / 2) - ( ($minrent + $maxrent) / 2) <=50) ) &&( ( ($own_minrent + $own_maxrent) / 2) - ( ($minrent + $maxrent) / 2) >= -50)
)
{$comp_score = $comp_score +1;}

I get this error:

Parse error: syntax error, unexpected T_BOOLEAN_AND in c:\wamp\www\grouprent\findhousemates.php on line 374

Cheers

[drew010]

the last ) before the && is closing the parans for the whole if statement.

if ( ( ( ( ($own_minrent + $own_maxrent) / 2) - ( ($minrent + $maxrent) / 2) <= 50) ) && 
   ( ( ( ($own_minrent + $own_maxrent) / 2) - ( ($minrent + $maxrent) / 2) >= -50) ) )

should work

[Weedpacket]

Either that, or there is one too many ) immediately before the && 🙂

Removing some parentheses might make it a bit easier to read:

if( $own_minrent + $own_maxrent - $minrent + $maxrent <= 100
	&&
	$own_minrent + $own_maxrent - $minrent + $maxrent >= -100
) 

I also took the liberty of multiplying through by 2.
Actually, now that some of the undergrowth has been cleared away that looks like it could be simplified further

if(abs($own_minrent + $own_maxrent - $minrent + $maxrent) <= 100)

[latemodern]

Thanks guys.

That's really helped!