Prepared Statements - help!

[Crussell]

Hey all,

I'm trying to get my head around prepared statements and not having much luck (see code sample below). It seems the mysqli_prepare isn't happening but I've no idea why... Any help grately appreciated as this is driving me nuts and I've probably done really stupid 🙂

Probably should mention I'm using PHP 5.0.4

MY CODE

$link = mysqli_connect($dbhost,$dbuser,$dbpass,$dbname,$dbport);
if (!$link) {
print "Couldn't open DB";
exit();
}
// prepare the select statement ...
$strSql = "SELECT * FROM tbl_a7_a5_story_code WHERE codeid= ?";
if ($prepSql = mysqli_prepare($link,$strSql)) {
mysqli_stmt_bind_param($prepSql, 'i', $loopVar);

    for ($loopVar=1; $loopVar < 50; $loopVar++) {

        mysqli_stmt_execute($prepSql);

      [ .. more stuff in here but it's immaterial at the mo ..]
    }
} else {
    print "the prepare didn't work";
}

END OF MY CODE

[mmonaco]

Just glancing I noticed your bind_param() function is wrong. The first parameter, in quotes should be a list of the datatypes

$prepSql = mysqli_bind_param("issid", $int_var, $str_var, $str_var2, $int_var2, $dbl_var);

Hope that helps.

[rheinen]

Verify that your server is running mysql >= 4.1.3. I believe that mysqli (MySQL Improved Extension) only work with that version or newer. The mysqli page seems to indicate that as well:

PHP Manual wrote:

Note: The mysqli extension is designed to work with the version 4.1.3 or above of MySQL. For previous versions, please see the MySQL extension documentation.

Reply back with the version number of MySQL and any error messages that you are encountering and someone may be able to help you.

Ryan

[rheinen]

mmonaco wrote:

Just glancing I noticed your bind_param() function is wrong. The first parameter, in quotes should be a list of the datatypes

$prepSql = mysqli_bind_param("issid", $int_var, $str_var, $str_var2, $int_var2, $dbl_var);

Hope that helps.

Crussel is using mysqli_stmt_bind_param() which is the procedural variant of bind_param() (this appears to be the method your are referring to). The first argument should be the prepared statement itself, and the second should be the list of datatypes. Thus it looks like Crussel's code (on that line anyways) is correct.

Ryan

[mmonaco]

I'm sorry, listen to him I usually work work in an object oriented approach and didn't lookup the procedural.

[Crussell]

I'm using the 5.0.15 release of MySQL, all other mysqli calls seem to be working fine, but for some reason this is giving me issues.

I am officially lost !!!

[rheinen]

How about placing

print mysqli_error();

in the else branch that is executed if the prepare doesn't succeed. Generally that will give a relatively helpful error message and without seeing your database/table structure that's all I can suggest at this point. Your PHP code up until the prepare looks correct.

Ryan