Why doesn't it work?

Swedie

Why do I get: Parse error: syntax error, unexpected T_STRING in F:\Hemsidor\htdocs\forum\admincp\webgb_install.php on line 637

from the follow:

$DB_site->query("INSERT INTO " . TABLE_PREFIX . "setting
(varname, grouptitle, value, defaultvalue, optioncode, displayorder, advanced, volatile)
VALUES
("webpagevbcodeorhtml", "vbcode", "1", "<select name=\"setting[$setting[varname]]\" tabindex=\"1\" class=\"bginput\">\n<option value=\"vbcode\" \" . iif($setting['value']=='vbcode','selected=\"selected\"') . \">$vbphrase[wg_vbcode]</option>\n<option value=\"html\" \" . iif($setting['value']=='html','selected=\"selected\"') . \">$vbphrase[wg_html]</option>\n</select>", 70, 0, 1)
");

drew010

you are using quotes around all the VALUES in there, and the string is surrounded by quotes, so php things the string is done and its looking for php code. changing them to single quotes ' should fix it.
also if you want to reference arrays in a string like that, they should be written as {$setting['varname']} to have 100% correct syntax. if warnings were on, it would be generating undefined index errors.

Swedie

thanks I believe you understand I am messing around with the vbulletin scripts. (don't point me to vb.org please).

I need to insert the following exactly the way it is to the database through an insert query:
<select name=\"setting[$setting[varname]]\" tabindex=\"1\" class=\"bginput\">\n<option value=\"vbcode\" " . iif($setting['value']=='vbcode','selected="selected"') . ">$vbphrase[wg_vbcode]</option>\n<option value=\"html\" " . iif($setting['value']=='html','selected="selected"') . ">$vbphrase[wg_html]</option>\n</select>

all strings unprocessed by php.

Can you point me to the explain when to use { } . I haven't come that far in my php coding to use them. thanks

drew010

the thing about the brackets is on the [man]echo[/man] page. you will see in that first example block, near the middle they have
echo "this is {$bar['value']} !"; // this is foo !

thats not really whats causing the error though, it has to do with the part of the query near VALUES.

INSERT INTO " . TABLE_PREFIX . "setting
(varname, grouptitle, value, defaultvalue, optioncode, displayorder, advanced, volatile)
VALUES
("webpagevbcodeorhtml",

notice you have the quotes surrounding webpagevbcodeorhtml. thats whats messing up php.

its similar to doing
echo "hi this is a "cool quote" i like to say";
once it hits the " before cool it thinks the string is done and doesnt expect another string since its not valid in that context.

Swedie

thanks. I'll look into that!

btw, what does foo stand for? it's short of something?

drew010

just a common variable name used in programming examples that allows the writer to not have to think of a meaningful or meaningless variable name
http://en.wikipedia.org/wiki/Foo