Inserting options from Drop Down Box in MySQL

Dada78

Hello, I sure hope someone here can help me. I have been trying to get this work for a week and I am new to php and the whole MqSQL but it is very interesting and learn fast. I have a couple of sites that use php and MySQL but this is my first try at writing something from scratch.

I am need a build a drop down box that has about 6 options to enter into the DB. That's the easy part which I have already done. here is how it looks.

<form name="cache_type" action="cache_types.php" method="POST">
<div align="left">
<select name="cache_type">
<option value="traditional">Traditional Cache</option>
<option value="multi">Multi-Stage Cache (Multicache)</option>
<option value="mysterypuzzle">Mystery/Puzzle Cache</option>
<option value="letterbox">Letterbox (Hybrid)</option>
<option value="geocacheevent">Geocaching Event (Event Cache)</option>
<option value="CITO">Cache In Trash Out Event</option>
</select> 
      <br /><input value="Submit" name="Submit" type="submit">
</div>
</form>

Here is the PHP page that the form is calling

<?

include("dbinfo.inc.php");

$str_cache_types = $_POST['cache_type'];

mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die( "Unable to select database");

$query = mysql_query("INSERT INTO cache_types (id_field, cache_types_field) VALUES ($number_value,$cache_types)");

{
echo "Thanks for your help while we continue to develop. Click the Home button in the upper left corner to return back to the Home Page.";
} 


mysql_close();
?>

Here is my DB setup

TABLE cache_types

(id int(6) NOT NULL auto_increment,

cache_types enum('traditional','multi','mysterypuzzle','letterbox','geocacheevent','CITO') default NULL,
PRIMARY KEY (id)
) TYPE=MyISAM AUTO_INCREMENT=1 ;

This is the info I have got up to this point on it but don't know if it's correct. The werid thing is I don't get any errors, but nothing is entered into the table. Here is the url of wher the form is that I am working on.

http://www.texascaching.com/type2.html

I hope someone can help, I am in dire need to get this working and I would be much apprecitive.

-Thanks

harmor

I'll explain this statement

$query = mysql_query("INSERT INTO cache_types (id_field, cache_types_field) VALUES ($number_value,$cache_types)");

INSERT INTO cache_types
The cache_types is the table you're inserting the values into and it appears that you have this correct.

(id_field, cache_types_field)
These are the fields that you are inserting the values into.
You do not need to have the id field nor do you need to put _field after it.

VALUES ($number_value,$cache_types)
These are the the values that you are getting from the form.
Notice $cache_types This is wrong because you assigned $_POST['cache_type'] to $str_cache_types

Try replacing your insert query with this one

$query = mysql_query("INSERT INTO cache_types (cache_types) VALUES ($str_cache_types)")or die (mysql_error());

The or die (mysql_error() function will return any errors to show you what you need to fix.

Delete

 `cache_types` enum('traditional','multi','mysterypuzzle','letterbox','geocacheevent','CITO') default NULL,

Run this in phpmyadmin.

`cache_types` varchar(50) NOT NULL default '',

I don't know what enum is.

Dada78

Thank you so much for the advice. You have explained it to me where it made perfect sense, thank you. I did as you suggested and the little trick or die (mysql_error() function is really cool, I will definately have to remember that. Any kicks back this error

Unknown column 'traditional' in 'field list'

you can try it here
http://www.texascaching.com/type2.html

here is how it looks now after the changes

<?

include("dbinfo.inc.php");

$str_cache_types = $_POST['cache_type'];

mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die( "Unable to select database");

 $query = mysql_query("INSERT INTO cache_types (cache_types) VALUES ($str_cache_types)")or die (mysql_error()); 
{
echo "Thanks for your help while we continue to develop. Click the Home button in the upper left corner to return back to the Home Page.";
} 


mysql_close();
?>

here is the update DB settings

TABLE cache_types
(
id int(6) NOT NULL auto_increment,

cache_types varchar(50) NOT NULL default '',
PRIMARY KEY (id)
) TYPE=MyISAM AUTO_INCREMENT=1 ;

harmor

I think I know what the problem is

I didn't put single quotes around the value

$query = mysql_query("INSERT INTO cache_types (cache_types) VALUES ('$str_cache_types')")or die (mysql_error());

Notice $str_cache_types now has single quotes around it.

Now you need to make it more secure.
I could make a form

<form action="http://www.texascaching.com/cache_types.php" method="post">
<input type="text" name="cache_type" />
<input type="submit" value="submit" />
</form>

With this I can insert anything into your database incuding html to mess up your site if you're calling the data.

I don't know that much aobut security but to strip html from incoming forms place after
$str_cache_types = $_POST['cache_types'];

$str_cache_types = preg_replace("#\<.+?\>(.+?)\</.+?\>#is", "\\1", $str_cache_types);

So now your php script will look like this

include("dbinfo.inc.php");

$str_cache_types = $_POST['cache_type']; 
$str_cache_types = preg_replace("#\<.+?\>(.+?)\</.+?\>#is", "\\1", $str_cache_types);

Dada78

OMG I am so happy I could do cart wheels, It works like a charm now. Thanks so much for your help. I have been trying to get this to work for a week. I defiantely learned a lot that will help me on my next boxes. I am sure I will have more questions down the road on other stuff.

-Thanks Again.

harmor

I appreciate the graditude.

I'll try to answer all your questions in detail because I've experienced those short answer questions telling what I should do without explaining.

Dada78

I do just have one question. In this statement below.

$str_cache_types[/php[

at the begining with the $str, what exactly does that mean? Reason I am asking is I have a few more boxes I need to make and I was just going to pretty much copy the method above but alter it for each box to suit my needs. Just curious so I would know in the future instead of just copying and pasting which is nice, but I would like to learn what each function does as I am building these forms etc.

-Thanks

harmor

It means nothing, just consider it text

you assigned $_POST['cache_type'] to $str_cache_types
You could've used

$cache_types = $POST['cache_type']; or
$some_text_here = $POST['cache_type']; or
$almfqewiognqiwg = $_POST['cache_type'];

It doesn't matter