[RESOLVED] Form update not updating, but no error(s) ???

dmacman1962

Hi All,

I have a form that is supposed to update the records after you hit submit, but it's not.

This code gets the FormID from the previous page, then after making the changes and hitting submit, it "should" update the record, but it does not. Nor does it produce any kind of error???
Any clues anyone?

include ('../includes/x.php');
if($submit)
{
$sql = "INSERT INTO Forms (Title, FirstName, LastName, Position, SubjectTaught, GradeLevel7, GradeLevel8, GradeLevel9, GradeLevel10, GradeLevel11, GradeLevel12, School, SchoolAddress1, SchoolAddress2, City, State, Zip, EmailAddress, Washington, AmericOne, Greed, Scaring, Freeloaders, WouldLikeBecause, PlanOnUsing, VideoUse, Promise, Comments, Processed)
VALUES ('$Title','$FirstName', '$LastName','$Position','$SubjectTaught','$GradeLevel7','$GradeLevel8','$GradeLevel9','$GradeLevel10','$GradeLevel11','$GradelLevel12','$School','$SchoolAddress1','$SchoolAddress2','$City','$State','$Zip','$EmailAddress','$Washington','$AmericaOne','$Greed','$Scaring','$Freeloaders','$WouldLikeBecause','$PLanOnUsing','$AverageStudents','$VideoUse','$Promise','$Comments','$Processed')";
$result = mysql_query($sql);
echo "Thank you! Information entered.\n";
} else if($update) {
$sql = "UPDATE Forms SET FirstName='$FirstName',LastName='$LastName',Postion='$Position',SubjectTaught='$SubjectTaught',
GradeLevel7='$GradeLevel7', GradeLevel8='$GradeLevel8', GradeLevel9='$GradeLevel9', GradeLevel10='$GradeLevel10', GradeLevel11='$GradeLevel11', GradeLevel12='$GradeLevel12',
School='$School', SchoolAddress1='$AchoolAddress1', SchoolAddress2='$SchoolAddress2', City='$City', State='$State', Zip='$Zip', EmailAddress='$EmailAddress', Washington='$Washington', AmericaOne='$AmericaOne', Greed='$Greed', Scaring='$Scaring', Freeloaders='$Freeloaders',
WouldLikeBecause='$WouldLikeBecause', PlanOnUsing='$PlanOnUsing', AverageStudents='$AverageStudents', VideoUse='$VideoUse', Promise='$Promise', Comments='$Comments', Processed='$Processed' WHERE FormID=$FormID";
$result = mysql_query($sql);
echo "Thank you! Information updated.\n";
echo "<br><br><a href=\"statelookup.php\">Return to the lookup page</a>";
} else if($FormID) {
$result = mysql_query("SELECT * FROM Forms WHERE FormID=$FormID",$db);
$myrow = mysql_fetch_array($result);
?>
<form method="post" action="<?php echo $PHP_SELF?>">
<input type="hidden" name="FormID" value="<?php echo $myrow["FormID"]?>">
First Name:<input type="Text" name="FirstName" value="<?php echo $myrow["FirstName"]?>"><br>
Last Name:<input type="Text" name="LastName" value="<?php echo $myrow["LastName"]?>"><br>
Position:<input type="Text" name="Position" value="<?php echo $myrow["Position"]?>"><br>
Subject Taught:<input type="Text" name="SubjectTaught" value="<?php echo $myrow["SubjectTaught"]?>"><br>
Grade Level 7:<input type="Text" name="GradeLevel7" value="<?php echo $myrow["GradeLevel7"]?>"><br>
Grade Level 8:<input type="Text" name="GradeLevel8" value="<?php echo $myrow["GradeLevel8"]?>"><br>
Grade Level 9:<input type="Text" name="GradeLevel9" value="<?php echo $myrow["GradeLevel9"]?>"><br>
Grade Level 10:<input type="Text" name="GradeLevel10" value="<?php echo $myrow["GradeLevel10"]?>"><br>
Grade Level 11:<input type="Text" name="GradeLevel11" value="<?php echo $myrow["GradeLevel11"]?>"><br>
Grade Level 12:<input type="Text" name="GradeLevel12" value="<?php echo $myrow["GradeLevel12"]?>"><br>
School:<input type="Text" name="School" value="<?php echo $myrow["School"]?>"><br>
School Address 1:<input type="Text" name="SchoolAddress1" value="<?php echo $myrow["SchoolAddress1"]?>"><br>
School Address 2:<input type="Text" name="SchoolAddress2" value="<?php echo $myrow["SchoolAddress2"]?>"><br>
City:<input type="Text" name="City" value="<?php echo $myrow["City"]?>"><br>
State:<input type="Text" name="State" value="<?php echo $myrow["State"]?>"><br>
Zip:<input type="Text" name="Zip" value="<?php echo $myrow["Zip"]?>"><br>
E-mail:<input type="Text" name="EmailAddress" value="<?php echo $myrow["EmailAddress"]?>"><br>
Washington:<input type="Text" name="Washington" value="<?php echo $myrow["Washington"]?>"><br>
America One:<input type="Text" name="AmericaOne" value="<?php echo $myrow["AmericaOne"]?>"><br>
Greed:<input type="Text" name="Greed" value="<?php echo $myrow["Greed"]?>"><br>
Scaring:<input type="Text" name="Scaring" value="<?php echo $myrow["Scaring"]?>"><br>
Freeloaders:<input type="Text" name="Freeloaders" value="<?php echo $myrow["Freeloaders"]?>"><br>
Would Like Because:<input type="text" name="WouldLikeBecause" value="<?php echo $myrow["WouldLikeBecause"]?>"><br>
Plan On Using:<input type="Text" name="PlanOnUsing" value="<?php echo $myrow["PlanOnUsing"]?>"><br>
Average Students:<input type="Text" name="AverageStudents" value="<?php echo $myrow["AverageStudents"]?>"><br>
Video Use:<input type="Text" name="VideoUse" value="<?php echo $myrow["VideoUse"]?>"><br>
Promise:<input type="Text" name="Promise" value="<?php echo $myrow["Promise"]?>"><br>
Comments:<input type="Text" name="Comments" value="<?php echo $myrow["Comments"]?>"><br>
Processed:<input type="Text" name="Processed" value="<?php echo $myrow["Processed"]?>"><br>
<input type="Submit" name="update" value="Update information"></form>
<?
}
else
{
?>
<form method="post" action="<?php echo $PHP_SELF?>">
Title:<input type="Text" name="Title"><br>
First Name:<input type="Text" name="FirstName"><br>
Last Name:<input type="Text" name="LastName"><br>
Subject Taught:<input type="Text" name="SubjectTaught"><br>
Grade Level 7:<input type="Text" name="GradeLevel7"><br>
Grade Level 8:<input type="Text" name="GradeLevel8"><br>
Grade Level 9:<input type="Text" name="GradeLevel9"><br>
Grade Level 10:<input type="Text" name="GradeLevel10"><br>
Grade Level 11:<input type="Text" name="GradeLevel11"><br>
Grade Level 12:<input type="Text" name="GradeLevel12"><br>
School:<input type="Text" name="School"><br>
School Address 1:<input type="Text" name="SchoolAddress1"><br>
School Address 2:<input type="Text" name="SchoolAddress2"><br>
City:<input type="Text" name="City"><br>
State:<input type="Text" name="State"><br>
Zip:<input type="Text" name="Zip"><br>
E-mail:<input type="Text" name="EmailAddress"><br>
Washington:<input type="Text" name="Washington"><br>
America One:<input type="Text" name="AmericaOne"><br>
Greed:<input type="Text" name="Greed"><br>
Scaring:<input type="Text" name="Scaring"><br>
Freeloaders:<input type="Text" name="Freeloaders"><br>
Would Like Because:<input type="Text" name="WouldLikeBecause"><br>
Plan on Using:<input type="Text" name="PlanOnUsing"><br>
Average Use:<input type="Text" name="AverageUse"><br>
Video Use:<input type="Text" name="VideoUse"><br>
Promise:<input type="Text" name="Promise"><br>
Comments:<input type="Text" name="Comments"><br>
Processed:<input type="Text" name="Processed"><br>
<input type="Submit" name="submit" value="Enter information"></form>
<?
}
?>

Thanks in advance,
Don

Kudose

With your script, you MUST have register_globals turned on. Which is bad from a security stand point.

Check your php.ini or phpinfo to see if they are turned on.

Also, try debugging the code. Put an echo statement right after the if conditional to see if it results in true or false. You can exit the script right after the echo so your queries dont run ...

just my 2 cents

dmacman1962

I am not familar with globals.

If I do a print_r($_POST) I get this:

Array
(
    [FormID] => 82
    [FirstName] => ggg
    [LastName] => ggg
    [Position] => Teacher
    [SubjectTaught] => Current Events
    [GradeLevel7] => GRADE 7
    [GradeLevel8] => GRADE 8
    [GradeLevel9] => GRADE 9
    [GradeLevel10] => GRADE 10
    [GradeLevel11] => GRADE 11
    [GradeLevel12] => GRADE 12
    [School] => mash
    [SchoolAddress1] => 123 north st
    [SchoolAddress2] => 
    [City] => df
    [State] => df
    [Zip] => sfd
    [EmailAddress] => a@a.com
    [Washington] => WANTS SJ05
    [AmericaOne] => WANTS SJ04
    [Greed] => WANTS SJ01
    [Scaring] => WANTS SJ02
    [Freeloaders] => WANTS SJ03
    [WouldLikeBecause] => beacuss rhet are cool
    [PlanOnUsing] => with my ss class
    [AverageStudents] => 50
    [VideoUse] => 4
    [Promise] => PromiseToProvideData
    [Comments] => comemntnssss
    [Processed] => 0
    [update] => Update information
)

the print_r shows that changes, but the tabel does not.
So it is passing the update variable, but not updating the table???

Thanks,

Don

Kudose

Print your SQL to see if the query reflects the posted data.

dmacman1962

I don't follow you with "print your SQL" .

Do you mean

echo "What is ".$update."<br>";

Because this give me

What is Update information

Can you fill me in on what you mean by that.

Sorry to be so dense.

Thanks,

Don

Kudose

I dont really understand how you switch between the edit and add sections. This should really be two pages.

<?php
  //page one
  //-------------------------------
  include ('../includes/x.php');
  if($_POST['update']) {
    extract($_POST);
    $sql = "UPDATE Forms SET FirstName='$FirstName',LastName='$LastName',Postion='$Position',SubjectTaught='$SubjectTaught',
    GradeLevel7='$GradeLevel7', GradeLevel8='$GradeLevel8', GradeLevel9='$GradeLevel9', GradeLevel10='$GradeLevel10', GradeLevel11='$GradeLevel11', GradeLevel12='$GradeLevel12',
    School='$School', SchoolAddress1='$AchoolAddress1', SchoolAddress2='$SchoolAddress2', City='$City', State='$State', Zip='$Zip', EmailAddress='$EmailAddress', Washington='$Washington', AmericaOne='$AmericaOne', Greed='$Greed', Scaring='$Scaring', Freeloaders='$Freeloaders',
    WouldLikeBecause='$WouldLikeBecause', PlanOnUsing='$PlanOnUsing', AverageStudents='$AverageStudents', VideoUse='$VideoUse', Promise='$Promise', Comments='$Comments', Processed='$Processed' WHERE FormID=$FormID";
    if(mysql_query($sql)){
      echo "Thank you! Information updated.\n";
      echo "<br><br><a href=\"statelookup.php\">Return to the lookup page</a>";
    } else {
      echo "Error";
    }
  } else {
    extract($_POST);
    $result = mysql_query("SELECT * FROM Forms WHERE FormID=$FormID",$db);
    $myrow = mysql_fetch_array($result);
    ?>
    <form method="post" action="<?php echo $PHP_SELF?>">
    <input type="hidden" name="FormID" value="<?php echo $myrow["FormID"]?>">
    First Name:<input type="Text" name="FirstName" value="<?php echo $myrow["FirstName"]?>"><br>
    Last Name:<input type="Text" name="LastName" value="<?php echo $myrow["LastName"]?>"><br>
    Position:<input type="Text" name="Position" value="<?php echo $myrow["Position"]?>"><br>
    Subject Taught:<input type="Text" name="SubjectTaught" value="<?php echo $myrow["SubjectTaught"]?>"><br>
    Grade Level 7:<input type="Text" name="GradeLevel7" value="<?php echo $myrow["GradeLevel7"]?>"><br>
    Grade Level 8:<input type="Text" name="GradeLevel8" value="<?php echo $myrow["GradeLevel8"]?>"><br>
    Grade Level 9:<input type="Text" name="GradeLevel9" value="<?php echo $myrow["GradeLevel9"]?>"><br>
    Grade Level 10:<input type="Text" name="GradeLevel10" value="<?php echo $myrow["GradeLevel10"]?>"><br>
    Grade Level 11:<input type="Text" name="GradeLevel11" value="<?php echo $myrow["GradeLevel11"]?>"><br>
    Grade Level 12:<input type="Text" name="GradeLevel12" value="<?php echo $myrow["GradeLevel12"]?>"><br>
    School:<input type="Text" name="School" value="<?php echo $myrow["School"]?>"><br>
    School Address 1:<input type="Text" name="SchoolAddress1" value="<?php echo $myrow["SchoolAddress1"]?>"><br>
    School Address 2:<input type="Text" name="SchoolAddress2" value="<?php echo $myrow["SchoolAddress2"]?>"><br>
    City:<input type="Text" name="City" value="<?php echo $myrow["City"]?>"><br>
    State:<input type="Text" name="State" value="<?php echo $myrow["State"]?>"><br>
    Zip:<input type="Text" name="Zip" value="<?php echo $myrow["Zip"]?>"><br>
    E-mail:<input type="Text" name="EmailAddress" value="<?php echo $myrow["EmailAddress"]?>"><br>
    Washington:<input type="Text" name="Washington" value="<?php echo $myrow["Washington"]?>"><br>
    America One:<input type="Text" name="AmericaOne" value="<?php echo $myrow["AmericaOne"]?>"><br>
    Greed:<input type="Text" name="Greed" value="<?php echo $myrow["Greed"]?>"><br>
    Scaring:<input type="Text" name="Scaring" value="<?php echo $myrow["Scaring"]?>"><br>
    Freeloaders:<input type="Text" name="Freeloaders" value="<?php echo $myrow["Freeloaders"]?>"><br>
    Would Like Because:<input type="text" name="WouldLikeBecause" value="<?php echo $myrow["WouldLikeBecause"]?>"><br>
    Plan On Using:<input type="Text" name="PlanOnUsing" value="<?php echo $myrow["PlanOnUsing"]?>"><br>
    Average Students:<input type="Text" name="AverageStudents" value="<?php echo $myrow["AverageStudents"]?>"><br>
    Video Use:<input type="Text" name="VideoUse" value="<?php echo $myrow["VideoUse"]?>"><br>
    Promise:<input type="Text" name="Promise" value="<?php echo $myrow["Promise"]?>"><br>
    Comments:<input type="Text" name="Comments" value="<?php echo $myrow["Comments"]?>"><br>
    Processed:<input type="Text" name="Processed" value="<?php echo $myrow["Processed"]?>"><br>
    <input type="Submit" name="update" value="Update information"></form>
    <?
  }

  //page 2
  //-------------------
  include ('../includes/x.php');
  if($_POST['submit']){
    extract($_POST);
    $sql = "INSERT INTO Forms (Title, FirstName, LastName, Position, SubjectTaught, GradeLevel7, GradeLevel8, GradeLevel9, GradeLevel10, GradeLevel11, GradeLevel12, School, SchoolAddress1, SchoolAddress2, City, State, Zip, EmailAddress, Washington, AmericOne, Greed, Scaring, Freeloaders, WouldLikeBecause, PlanOnUsing, VideoUse, Promise, Comments, Processed)
    VALUES ('$Title','$FirstName', '$LastName','$Position','$SubjectTaught','$GradeLevel7','$GradeLevel8','$GradeLevel9','$GradeLevel10','$GradeLevel11','$GradelLevel12','$School','$SchoolAddress1','$SchoolAddress2','$City','$State','$Zip','$EmailAddress','$Washington','$AmericaOne','$Greed','$Scaring','$Freeloaders','$WouldLikeBecause','$PLanOnUsing','$AverageStudents','$VideoUse','$Promise','$Comments','$Processed')";
    if(mysql_query($sql))
      echo "Thank you! Information entered.<br>";
    else
      echo "Error!";
  } else {
    ?>
    <form method="post" action="<?php echo $PHP_SELF?>">
    Title:<input type="Text" name="Title"><br>
    First Name:<input type="Text" name="FirstName"><br>
    Last Name:<input type="Text" name="LastName"><br>
    Subject Taught:<input type="Text" name="SubjectTaught"><br>
    Grade Level 7:<input type="Text" name="GradeLevel7"><br>
    Grade Level 8:<input type="Text" name="GradeLevel8"><br>
    Grade Level 9:<input type="Text" name="GradeLevel9"><br>
    Grade Level 10:<input type="Text" name="GradeLevel10"><br>
    Grade Level 11:<input type="Text" name="GradeLevel11"><br>
    Grade Level 12:<input type="Text" name="GradeLevel12"><br>
    School:<input type="Text" name="School"><br>
    School Address 1:<input type="Text" name="SchoolAddress1"><br>
    School Address 2:<input type="Text" name="SchoolAddress2"><br>
    City:<input type="Text" name="City"><br>
    State:<input type="Text" name="State"><br>
    Zip:<input type="Text" name="Zip"><br>
    E-mail:<input type="Text" name="EmailAddress"><br>
    Washington:<input type="Text" name="Washington"><br>
    America One:<input type="Text" name="AmericaOne"><br>
    Greed:<input type="Text" name="Greed"><br>
    Scaring:<input type="Text" name="Scaring"><br>
    Freeloaders:<input type="Text" name="Freeloaders"><br>
    Would Like Because:<input type="Text" name="WouldLikeBecause"><br>
    Plan on Using:<input type="Text" name="PlanOnUsing"><br>
    Average Use:<input type="Text" name="AverageUse"><br>
    Video Use:<input type="Text" name="VideoUse"><br>
    Promise:<input type="Text" name="Promise"><br>
    Comments:<input type="Text" name="Comments"><br>
    Processed:<input type="Text" name="Processed"><br>
    <input type="Submit" name="submit" value="Enter information"></form>
    <?
  }
?>

Kudose

By printing your SQL statement, I meant:

$sql = "UPDATE Forms SET FirstName='$FirstName',LastName='$LastName',Postion='$Position',SubjectTaught='$SubjectTaught',
    GradeLevel7='$GradeLevel7', GradeLevel8='$GradeLevel8', GradeLevel9='$GradeLevel9', GradeLevel10='$GradeLevel10', GradeLevel11='$GradeLevel11', GradeLevel12='$GradeLevel12',
    School='$School', SchoolAddress1='$AchoolAddress1', SchoolAddress2='$SchoolAddress2', City='$City', State='$State', Zip='$Zip', EmailAddress='$EmailAddress', Washington='$Washington', AmericaOne='$AmericaOne', Greed='$Greed', Scaring='$Scaring', Freeloaders='$Freeloaders',
    WouldLikeBecause='$WouldLikeBecause', PlanOnUsing='$PlanOnUsing', AverageStudents='$AverageStudents', VideoUse='$VideoUse', Promise='$Promise', Comments='$Comments', Processed='$Processed' WHERE FormID=$FormID";
echo $sql;    

if(mysql_query($sql)){

dmacman1962

I did a print_r($_POST) and echo $sql and they both reflect the changes made during the edit/update.

If you look at the SchoolAddress2, you will see my comment, that I entered and then tried to submit it to the database.

What is Update information
UPDATE Forms SET FirstName='Joe',LastName='Smith',Postion='Guru',SubjectTaught='Computer Science', GradeLevel7='GRADE 7', GradeLevel8='GRADE 8', GradeLevel9='GRADE 9', GradeLevel10='GRADE 10', GradeLevel11='GRADE 11', GradeLevel12='GRADE 12', School='Technical Memorial', SchoolAddress1='', SchoolAddress2='I added this during Edit Update', City='Erie', State='PA', Zip='16502', EmailAddress='joe.dirt@yahoo.com', Washington='Wants it', AmericaOne='Wants it', Greed='Wants it', Scaring='Wants it', Freeloaders='Wants it', WouldLikeBecause='I would like...', PlanOnUsing='I plan on using...', AverageStudents='400', VideoUse='2', Promise='I Promise...', Comments='My Comments are...', Processed='0' WHERE FormID=107Thank you! Information updated.

Return to the lookup page

Array
(
[FormID] => 107
[FirstName] => Joe
[LastName] => Smith
[Position] => Guru
[SubjectTaught] => Computer Science
[GradeLevel7] => GRADE 7
[GradeLevel8] => GRADE 8
[GradeLevel9] => GRADE 9
[GradeLevel10] => GRADE 10
[GradeLevel11] => GRADE 11
[GradeLevel12] => GRADE 12
[School] => Technical Memorial
[SchoolAddress1] => 3232 Cherry Street
[SchoolAddress2] => I added this during Edit Update
[City] => Erie
[State] => PA
[Zip] => 16502
[EmailAddress] => joe.dirt@yahoo.com
[Washington] => Wants it
[AmericaOne] => Wants it
[Greed] => Wants it
[Scaring] => Wants it
[Freeloaders] => Wants it
[WouldLikeBecause] => I would like...
[PlanOnUsing] => I plan on using...
[AverageStudents] => 400
[VideoUse] => 2
[Promise] => I Promise...
[Comments] => My Comments are...
[Processed] => 0
[update] => Update information
)

This is strange!???

I hope this is pointing you in the right direction, I would like to know why this is not working, yet does not cause any errors??

Thanks,

Don

Kudose

By "not cause any errors" do you mean that nothing is displayed, or everything says it completed properly, but it didnt.

Try this:

if(mysql_query($sql)){
      echo "Thank you! Information updated.\n";
      echo "<br><br><a href=\"statelookup.php\">Return to the lookup page</a>";
    } else {
      echo mysql_error();;
    }

dmacman1962

Bingo!

There was a typo in one of the fields, so it didn't finish the update.

Thank you very much.

I thought I was showing the errors, but I was not.

Most of that code was out of a book on "How to program with PHP".

I guess the author needs to read some books on how to trap errors!

Owe you one.

Don

Kudose

Glad you got it fixed.

dmacman1962

Kudose,

You stated earlier

With your script, you MUST have register_globals turned on. Which is bad from a security stand point.

Our site is hosted by our ISP.

Also, you said that is bad from a security stand point. What would you do differently?

Thanks,
Don

Kudose

I would turn register_globals off.

http://www.programmershelp.co.uk/docs/phpmanual/security.registerglobals.html