Need help to look at the code

[zzz]

I have a code that suppose go through a list of users and email them an attachment. Before this is done, it also needs to look at the list of user preferences and only email to thos that opted in to receive. Email contains PDF attachment.

Now, that part works fine. The problem I am having is with running the look and sending out message. Currently the problem I am having is that it does send emails to the address that match, but put the wrong name of the receiver. Here's what i've got so far:

$subject = "Your file";

$fileatt = "./files/"; // Location of file on server
$fileatt_type = "application/pdf";// Type of file being sent
$fileatt_name = "file.pdf";// Name of file
$fileatt_path = $fileatt.$fileatt_name;// Name of file

// If the file exists -->>
 if (file_exists($fileatt_path))
 { 
	// Encode the file ready to send it off
	$file = fopen($fileatt_path,'rb');
	$data = fread($file,filesize($fileatt_path));
	fclose($file);
	$data = chunk_split(base64_encode($data));

// Generate a boundary string 
$semi_rand = md5(time()); 
$mime_boundary = "==Multipart_Boundary_x{$semi_rand}x";
$headers .= "From: test <[e-mail]>";

// Add the headers for a file attachment 
$headers .= "\nMIME-Version: 1.0\n" . 
"Content-Type: multipart/mixed;\n" . 
" boundary=\"{$mime_boundary}\"";

// Add a multipart boundary above the plain message 
$message = "This is a multi-part message in MIME format.\n\n" . 
"--{$mime_boundary}\n" . 
"Content-Type: text/plain; charset=\"iso-8859-1\"\n" . 
"Content-Transfer-Encoding: 7bit\n\n" . 
$message . "\n"; 

$users = $db->get_results ("SELECT * FROM user_tbl");
foreach ( $users as $user )
{
   	// access user preferences db
   	$db2 = new db("connect to db with User Preferences");

   	$userPref = $db2->get_row ("SELECT emailUpdates FROM userPreferences
   							    WHERE usr_member_id = '". $user->member_id ."'
							    AND usr_login = '". $user->login ."' ");

	if ($userPref->emailUpdates != 'optOut') { 
	{
		$to = $user->email;
		$name = $user->name_f." ".$user->name_l;
		$name = ucwords(strtolower($name));

	    $message .="Dear $name,\r\nAttached is your file\r\n";

	    // Add file attachment to the message
	    $message .= "--{$mime_boundary}\n" . 
	    "Content-Type: {$fileatt_type};\n" . 
	    " name=\"{$fileatt_name}\"\n" . 
	    "Content-Transfer-Encoding: base64\n\n" . 
	    $data . "\n\n" . 
	    "--{$mime_boundary}--\n";

		mail($to, $subject, $message, $headers);
	} // if User Preferences allow <<--
}
} // if file exists <<--

[Najjar]

I don't see a reason why it should not work but test

if ($user->member_id == $userPref->usr_member_id)

Make sure that you read "usr_member_id" in your sql

And check if you have duplicate "usr_member_id" in the userPreferences table.

[zzz]

Do you mean to add this condition to the other one, like this:

 if ($user->member_id == $userPref->usr_member_id && $userPref->emailUpdates != 'optOut')

[zzz]

I should've worked without that extra condition... What am I missing here?

[coreyp_1]

not sure I see our error, but why are you making php filter the results? Your database would do a much better and faster job simply by adding a WHERE clause.
Also, your code would be cleaner, and we might be able to find the error easier.

[zzz]

It's a bit tricky... I get the list of users from one db and have to validate it against the list stored ina different db. The two databases are separate and require different connection. If these were two tables withing the same db I probably won't have any problems.

[zzz]

I believe my problem is in the message being separated in different parts. Am I right?

[coreyp_1]

OK, a couple of questions...

    // Add a multipart boundary above the plain message
    $message = "This is a multi-part message in MIME format.\n\n" . 
    "--{$mime_boundary}\n" . 
    "Content-Type: text/plain; charset=\"iso-8859-1\"\n" . 
    "Content-Transfer-Encoding: 7bit\n\n" . 
    $message . "\n"; 

Why are you referencing $message in setting the variable itself. $message has not been set to anything in the code you've shown us.

Second, realize that each time you loop through the different users and sends them a message, the $message variable just gets bigger and bigger. This looks like a logical error to me. By the time it sends out 10 e-mails, the $message variable will be 10 times bigger than when it started.

Re-work this, and your error will probably go away.

[zzz]

Corey,

I think you're onto something here. I do not quite understand what you mean by

Why are you referencing $message in setting the variable itself. $message has not been set to anything in the code you've shown us.

I moved the multipart boundary part above because I thought it was causing double headers. Now, I was only testing with two emails and the second would be sent to the correct email but would have the first name in the list and it would have two attachments with two headers. Now after your message I think you're right, if I tested with 10 email, my last email would still be sent to the correct address, first name and have 10 attachments...

The code in the original message is all I'm using. I use this code to send individual requests, but I thought I could modify it to send to a list. So going back to your message, I got the SECOND point, but am a bit confused with the first one.

Do you mean I need to rework the code to put it in the following order:

// 1. get file params first

// 2. if the file exists do the followingn

// 3. get the list  of users that match the criteria and run the loop

// 4. filter to keep the ones that can be emailed only

// 5. build the $message and attach the file

// 6. email and start with the next name

Isn't it what I need to do? I sense there's some mix up somewhere but just can't pin pint it. Do you say I'm missing something in my original code? I've been staring too long on this piece, can't seem to get it right. Help!!!!!!!!!

[zzz]

OK, I reshuffeled the code and got rid of the header multiplication, but now I do not know how to insert the name in the message... Here's what i've got now:

$subject = "Your file"; 

$fileatt = "./files/"; // Location of file on server 
$fileatt_type = "application/pdf";// Type of file being sent 
$fileatt_name = "file.pdf";// Name of file 
$fileatt_path = $fileatt.$fileatt_name;// Name of file 

// If the file exists -->> 
 if (file_exists($fileatt_path)) 
 {  

    // Encode the file ready to send it off 
    $file = fopen($fileatt_path,'rb'); 
    $data = fread($file,filesize($fileatt_path)); 
    fclose($file); 
    $data = chunk_split(base64_encode($data)); 

// Generate a boundary string 
$semi_rand = md5(time());  
$mime_boundary = "==Multipart_Boundary_x{$semi_rand}x"; 
$headers .= "From: test <[e-mail]>"; 

// Add the headers for a file attachment 
$headers .= "\nMIME-Version: 1.0\n" .  
"Content-Type: multipart/mixed;\n" .  
" boundary=\"{$mime_boundary}\""; 

// Add a multipart boundary above the plain message 
$message = "This is a multi-part message in MIME format.\n\n" .  
"--{$mime_boundary}\n" .  
"Content-Type: text/plain; charset=\"iso-8859-1\"\n" .  
"Content-Transfer-Encoding: 7bit\n\n" .  
$message . "\n";  

        $message .="Dear $name,\r\nAttached is your file\r\n"; 

        // Add file attachment to the message 
        $message .= "--{$mime_boundary}\n" .  
        "Content-Type: {$fileatt_type};\n" .  
        " name=\"{$fileatt_name}\"\n" .  
        "Content-Transfer-Encoding: base64\n\n" .  
        $data . "\n\n" .  
        "--{$mime_boundary}--\n"; 

     $users = $db->get_results ("SELECT * FROM user_tbl"); 
foreach ( $users as $user ) 
{ 
       // access user preferences db 
       $db2 = new db("connect to db with User Preferences"); 

       $userPref = $db2->get_row ("SELECT emailUpdates FROM userPreferences 
                                   WHERE usr_member_id = '". $user->member_id ."' 
                                AND usr_login = '". $user->login ."' "); 

    if ($userPref->emailUpdates != 'optOut') {  
    {
        $to = $user->email; 
        $name = $user->name_f." ".$user->name_l; 
        $name = ucwords(strtolower($name)); 

        mail($to, $subject, $message, $headers); 
    } // if User Preferences allow <<-- 
} 
} // if file exists <<-- 

[coreyp_1]

Re-arranged your code. Now using $message_header and $message_footer (so you don't have to re-build these sections every time).

$subject = "Your file";

$fileatt = "./files/"; // Location of file on server
$fileatt_type = "application/pdf";// Type of file being sent
$fileatt_name = "file.pdf";// Name of file
$fileatt_path = $fileatt.$fileatt_name;// Name of file

// If the file exists -->>
 if (file_exists($fileatt_path))
 {
    // Encode the file ready to send it off
    $file = fopen($fileatt_path,'rb');
    $data = fread($file,filesize($fileatt_path));
    fclose($file);
    $data = chunk_split(base64_encode($data));

// Generate a boundary string
$semi_rand = md5(time());
$mime_boundary = "==Multipart_Boundary_x{$semi_rand}x";
$headers .= "From: test <[e-mail]>";

// Add the headers for a file attachment
$headers .= "\nMIME-Version: 1.0\n" .
"Content-Type: multipart/mixed;\n" .
" boundary=\"{$mime_boundary}\"";

// Add a multipart boundary above the plain message
$message_header = "This is a multi-part message in MIME format.\n\n" .
  "--{$mime_boundary}\n" .
  "Content-Type: text/plain; charset=\"iso-8859-1\"\n" .
  "Content-Transfer-Encoding: 7bit\n\n";

// Add file attachment to the message
$message_footer = "--{$mime_boundary}\n" .
  "Content-Type: {$fileatt_type};\n" .
  " name=\"{$fileatt_name}\"\n" .
  "Content-Transfer-Encoding: base64\n\n" .
  $data . "\n\n" .
  "--{$mime_boundary}--\n";

$users = $db->get_results ("SELECT * FROM user_tbl");

foreach ( $users as $user )
{
       // access user preferences db
       $db2 = new db("connect to db with User Preferences");

       $userPref = $db2->get_row ("SELECT emailUpdates FROM userPreferences
                                   WHERE usr_member_id = '". $user->member_id ."'
                                AND usr_login = '". $user->login ."' ");

    if ($userPref->emailUpdates != 'optOut') {
    {
        $to = $user->email;
        $name = $user->name_f." ".$user->name_l;
        $name = ucwords(strtolower($name));

        $message = $message_header . "Dear $name,\r\nAttached is your file\r\n" . $message_footer;

        mail($to, $subject, $message, $headers);
    } // if User Preferences allow <<--
}
} // if file exists <<--