Loops help

Boris_Senker

Hello,

we are migrating a mail server from plaintext passwords to md5 and I am having a big issue with loops, so if someone would help me on this I would really be externally grateful, cos this is very urgent and our client is giving us hard time over this.

$link = mysql_connect('localhost', 'xxxx', 'xxxx');
$db = 'xxxx';
if (!$link) {
    die('Could not connect: ' . mysql_error());
}
else mysql_select_db($db, $link);
print "Connected successfully to the '$db' database. Processing...<br><br>";
$pw_db = mysql_query("SELECT password FROM mailbox");
while ($row=mysql_fetch_assoc($pw_db)) {
    $output=generate_password();
    $result=mysql_query("UPDATE mailbox SET password = '$output'");
    }
mysql_close ($link);

This is the problematic part (the actual hashing function works). What happens is it hashes the first password, and populates all following rows with it, instead of taking the next row's password value and hashing it etc.

Can someone please help me get this loop straightened out, I am going crazy over this.

Thanks in advance,

Boris

Weedpacket

Select password, some unique ID from mailbox
...
Update mailbox set password='$output' WHERE some unique ID=the unique id for the current row

Boris_Senker

Thanks for reply.

I need it to cycle automatically through all rows in the database. How can this be done?

Kudose

It's kinda like Weedpacket said ...

$pw_db = mysql_query("SELECT userid, password FROM mailbox");
while ($row=mysql_fetch_assoc($pw_db)) {
    $output=generate_password();
    $id = $row['userid'];
    $result=mysql_query("UPDATE mailbox SET password = '$output' WHERE userid='$id'");
    }

Kudose

This might be a bit easier ...

$db = mysql_query("SELECT userid, password FROM mailbox");
while($row = mysql_fetch_array($db)){
  $id = $row['userid'];
  $pass = $row['password'];
  mysql_query("UPDATE mailbox SET password=MD5('$pass') WHERE userid='$id'");
}

Boris_Senker

:eek: I have been SO stupid, blind....

there, working one:

$pw_db = mysql_query("SELECT password, username FROM mailbox");
while ($row=mysql_fetch_assoc($pw_db)) {
    $output=generate_password(); 
    $id = $row['username'];
    $result=mysql_query("UPDATE mailbox SET password = '$output' WHERE username='$id'");
    }

working like a charm!

Thanks A LOT! THANKS! Huge problem solved! If you were close now a few packs of beer and huge pizzas would be in order!

PS. Actually I couldn't use the simpler example 2, because the generate_password(); is a default PostfixAdmin random-salted-md5 hashing function so I need to use it.

Kudose

Cool beans.

Pizza sounds good ...

😉