Form Code Problem

[obrienkev]

Hey all,

Any ideas why this code doesnt work? Just produces a blank page.

<?php

// create variables
$name = $_POST['name'];
$email = $_POST['email'];
$message = $_POST['message'];
$submit = $_POST['submit'];

$toaddress = '[e-mail]';
$subject = 'Email Script';

// declare an empty error array
$error_message = array();

if(isset($submit)
{
                     if(!$name || $name == '')
                    {
                               $error_message['name'] = '<p>Please Complete the Name field</p>';

                 if(!$email || $email == '')
                {
                           $error_message['email'] ='<p>Please complete the Email Field</p>';
                }

                 if(!$message || $message == '')
                {
                           $error_message['message'] ='<p>Please complete the Message Field</p>';
                }

// create headers
$headers = "MIME-Version: 1.0\r\n";
$headers .= "Content-type: text/plain; charset=iso-8859-1\r\n";
$headers .= "From: \n";

// set variables
$mailcontent = 'Name: '.$name."\n"
                       .'Email: '.$email."\n"
                       .'Title: '.$title."\n"
                       .'Content: '.$message."\n"
                       .'Image: '.$fileName."\n";
$fromaddress = 'From: '.$email;

// remove backslashes
$mailcontent = Stripslashes($mailcontent);
$fromaddress = Stripslashes($fromaddress);

// send email
echo '<p>Thank You '.$name.'</p>';
mail($toaddress, $subject, $mailcontent, $fromaddress, $headers);

} // end if $submit
?>

<form action="email.php" name="frm_email" method="post" >

<?php if(isset($error_message['name'])) { echo $error_message['name']; } ?>
<label for="name">Name:</label>
<input type="text" name="name" id="name" value="<?php if(isset($name)) { echo $name; } ?>" />
<br />

<?php if(isset($error_message['email'])) { echo $error_message['email']; } ?>
<label for="email">Email:</label>
<input type="text" name="email" id="email" value="<?php if(isset($email)) { echo $email; } ?>" />
<br />

<?php if(isset($error_message['message'])) { echo $error_message['message']; } ?>
<label for="message">Message:</label>
<textarea name="message" cols="25" rows="10"></textarea>
<br />

<input type="submit" name="submit" value="Submit" />
<br />

</form>

[jernhenrik]

if(isset($submit)) <-- ?

and the 2nd if needs a closing }

[obrienkev]

Thanks Jernhenrik.

How do I prevent the email being sent if the user has not entered all fields?
I still want to display the form fields if they have completed all fields.

Here's my updated code...

// create variables
$name = $_POST['name'];
$email = $_POST['email'];
$message = $_POST['message'];
$submit = $_POST['submit'];

$toaddress = '[e-mail]';
$subject = 'Email Script';

// declare an empty error array
$error_message = array();

if(isset($submit))
{
 					if(!$name || $name == '')
					{
					 				$error_message['name'] = '<p>Please Complete the Name field</p>';
					}
 					if(!$email || $email == '')
					{
					 				$error_message['email'] ='<p>Please complete the Email Field</p>';
					}

				if(!$message || $message == '')
				{
				 				$error_message['message'] ='<p>Please complete the Message Field</p>';
				}

// create headers
$headers  = "MIME-Version: 1.0\r\n"; 
$headers .= "Content-type: text/plain; charset=iso-8859-1\r\n"; 
$headers .= "From: \n";

// set variables
$mailcontent = 'Name: '.$name."\n"
						 	 .'Email: '.$email."\n"
							 .'Title: '.$title."\n"
							 .'Content: '.$message."\n"
							 .'Image: '.$fileName."\n";
$fromaddress = 'From: '.$email;

// remove backslashes
$mailcontent = Stripslashes($mailcontent);
$fromaddress = Stripslashes($fromaddress);

// send email
echo '<p>Thank You '.Stripslashes($name).'</p>';
mail($toaddress, $subject, $mailcontent, $fromaddress, $headers);


?>

<form action="email.php" name="frm_email" method="post" >

<?php if(isset($error_message['name'])) { echo  $error_message['name']; } ?>
<label for="name">Name:</label>
<input type="text" name="name" id="name" value="<?php if(isset($name)) { echo Stripslashes($name); } ?>" />
<br />

<?php if(isset($error_message['email'])) { echo  $error_message['email']; } ?>
<label for="email">Email:</label>
<input type="text" name="email" id="email" value="<?php if(isset($email)) { echo Stripslashes($email); } ?>" />
<br />

<?php if(isset($error_message['message'])) { echo  $error_message['message']; } ?>
<label for="message">Message:</label>
<textarea name="message" cols="25" rows="10"><?php if(isset($message)) { echo $message; } ?></textarea>
<br />

<input type="submit" name="submit" value="Submit" />
<br />

</form>

<?php
}
?>

[jernhenrik]

Since you are defining an array of error messages, you could count these and if the result is different from zero, don't send the mail.

[obrienkev]

Hi again.

Tried the below but get this error..."Parse error: parse error, unexpected T_BOOLEAN_AND"

<?php

// create variables
$name = $_POST['name'];
$email = $_POST['email'];
$message = $_POST['message'];
$submit = $_POST['submit'];

$toaddress = '[e-mail]';
$subject = 'Email Script';

// declare an empty error array
$error_message = array();

if(isset($submit))
{
 					if(!$name || $name == '')
					{
					 				$error_message['name'] = '<p>Please Complete the Name field</p>';
					}
 					if(!$email || $email == '')
					{
					 				$error_message['email'] ='<p>Please complete the Email Field</p>';
					}
 					if(!$message || $message == '')
					{
					 				$error_message['message'] ='<p>Please complete the Message Field</p>';
					}
}
// create headers
$headers  = "MIME-Version: 1.0\r\n"; 
$headers .= "Content-type: text/plain; charset=iso-8859-1\r\n"; 
$headers .= "From: \n";

// set variables
$mailcontent = 'Name: '.$name."\n"
						 	 .'Email: '.$email."\n"
							 .'Title: '.$title."\n"
							 .'Content: '.$message."\n"
							 .'Image: '.$fileName."\n";
$fromaddress = 'From: '.$email;

// remove backslashes
$mailcontent = Stripslashes($mailcontent);
$fromaddress = Stripslashes($fromaddress);

if(count($error_message) == 0) && (isset($submit))
{
 							 // send email
							 echo '<p>Thank You '.Stripslashes($name).'</p>';
  						 mail($toaddress, $subject, $mailcontent, $fromaddress, $headers);
} // end if count

?>

<form action="email.php" name="frm_email" method="post" >

<?php if(isset($error_message['name'])) { echo  $error_message['name']; } ?>
<label for="name">Name:</label>
<input type="text" name="name" id="name" value="<?php if(isset($name)) { echo Stripslashes($name); } ?>" />
<br />

<?php if(isset($error_message['email'])) { echo  $error_message['email']; } ?>
<label for="email">Email:</label>
<input type="text" name="email" id="email" value="<?php if(isset($email)) { echo Stripslashes($email); } ?>" />
<br />

<?php if(isset($error_message['message'])) { echo  $error_message['message']; } ?>
<label for="message">Message:</label>
<textarea name="message" id="message" cols="25" rows="10"><?php if(isset($message)) { echo $message; } ?></textarea>
<br />

<input type="submit" name="submit" value="Submit" />
<br />

</form>

[jernhenrik]

if(count($error_message) == 0) && COLOR=RED

You have too many paranthesis in the above, try
if(count($error_message) == 0 && isset($submit))
{
//do horrible mail spam
}

[jernhenrik]

... and you should probably consider to validate the email they type. I guess this is some kind of contact form that you are creating, so in this case a simple preg_match to check for the correct syntax will probably be enough.

If you search this forum or google it, you'll find a great amount of info on this.

Cheers

[obrienkev]

Thanks again Jern.

What does this error mean??

"MIME-Version:... List:; syntax illegal for recipient addresses Content-type:... List:; syntax illegal for recipient addresses "

Here's my Mime Version: MIME-Version: 1.0\r\n

Thanks.