Login Problem

[frankobi]

Could some please help me locate the problem with my codes? For about a year, I was able to login with a password to access my MYSQL database. Suddenly, I am getting the following: "Sorry, could not log you in. Wrong login information," when I try to login,” when I try to login.

What could be the problem?

Thanks.

This is the Login File:

<?php
session_start();
// dBase file
include "dbConfig.inc";

$rs = mysql_select_db("lhsnycne_mydatabase",$dbh) 
	or die("error connecting to the database");


	if ($_GET["op"] == "login")
		{
		if (!$_POST["studentid"] || !$_POST["password"])
			{
			die("You need to supply a studentid and password.");
			}

		// Create query
		$q = "SELECT * FROM `grades6` "
			."WHERE `studentid`='".$_POST["studentid"]."' "
			."AND `password`=PASSWORD('".$_POST["password"]."') "
			."LIMIT 1";
		// Run query
		$r = mysql_query($q);

		if ( $obj = @mysql_fetch_object($r) )
			{
			// Login O.K., create session variables
			$_SESSION["valid_lname"] = $obj->lname;
			$_SESSION["valid_fname"] = $obj->fname;
			$_SESSION["valid_id"] = $_POST["studentid"];
			$_SESSION["valid_avg"] = $obj->avg;
			$_SESSION["valid_c"] = $obj->c;
			$_SESSION["valid_time"] = time();


			// Redirect to member page
			Header("Location: members6.php");
			}
		else
			{
			// Login not successful
			die("Sorry, could not log you in. Wrong login information.");
			}
	}
	else
		{
		echo "<form action=\"?op=login\" method=\"POST\">";
		echo "Studentid (last four digits of OSIS): <input name=\"studentid\" size=\"15\"><br />";
		echo "Password: <input type=\"password\" name=\"password\" size=\"8\"><br />";
		echo "<input type=\"submit\" value=\"Login\">";
		echo "</form>";
		}
	?>

==========================================
This is the accompanying file:

<?php
session_start();

if (!$_SESSION["valid_id"])
{
// User not logged in, redirect to login page
Header("Location: login6.php");
}

// Display Member-only stuff
// ...
// ...
// ...

// Display Member information
echo "<p>Name: " . $SESSION["valid_lname"]. ",&nbsp;" . $SESSION["valid_fname"];
echo "<br>Average1: " . $SESSION["valid_avg"];
echo "<p>Comment: " . $SESSION["valid_c"];
echo "<p>Logged in: " . date("m/d/Y", $_SESSION["valid_time"]);

// Display logout link
echo "<p><a href=\"logout6.php\">Click here to logout!</a></p>";
?>

[Kudose]

Try using mysql_error. The problem is that your query is returning false.

[frankobi]

Do you advice that I replace every occurrence of "mysql_query" with "mysql_error"?

Please let me know.

[Kudose]

No no no. Use mysql_error after you use mysql_query to see if MySQL throws an error.

 else
{
// Login not successful
die("Sorry, could not log you in. Wrong login information.<br><br>MySQL said: ".mysql_error());
} 

Sorry about that.

[frankobi]

I have tried your suggestion, but it gave me no information as to what the problem might be.

Could the problem be due to the fact that the session has expired?

[mmonaco]

No it has something to do with the expression in your if statement. Remove the @ operator from the expression to let PHP post and errors or warnings.

[frankobi]

I tried, and it did nothing.

The program has worked perfectly for the past year and a half, and all of a sudden, I am not able to do the things I was able to do up until this past Tuesday. I used to be able get data from the MYSQL database using this code. That was why I asked if the session might have expired.

I have no idea what could have gone wrong.

[batman]

Maybe perhaps your host upgraded to PHP5 and now you have to change your script around a little bit???
ex:
I would change this:

 if ( $obj = @mysql_fetch_object($r) )
{
// Login O.K., create session variables
$_SESSION["valid_lname"] = $obj->lname;
$_SESSION["valid_fname"] = $obj->fname;
$_SESSION["valid_id"] = $_POST["studentid"];
$_SESSION["valid_avg"] = $obj->avg;
$_SESSION["valid_c"] = $obj->c;
$_SESSION["valid_time"] = time();

WITH THIS:

$test = mysql_num_rows($r);
if($test > 1)
{
while($row = mysql_fetch_array($r)){
	foreach( $row AS $key => $val ){
		$$key = stripslashes( $val );
	}

$_SESSION["valid_lname"] = $row["lname"];
$_SESSION["valid_fname"] = $row["fname"];
$_SESSION["valid_id"] = $_POST["studentid"];
$_SESSION["valid_avg"] = $row["avg"];
$_SESSION["valid_c"] =$row["c"];
$_SESSION["valid_time"] = time();
}
}
else
{
echo "I'm sorry but the username / password is incorrect.";
}

[frankobi]

I am still having problems, after making the changes, but the latest is that my host just told me that they upgraded their PHP and mySQL as follows:
PHP4.4.1
mySQL4.1.13

With that in mind is there anything else I can do to get things working again?

[batman]

perhaps updating the mysql messed up your database and your login information doesnt exists anymore....have you tried viewing your database??

[frankobi]

Yes, I am able to view the database remotely, without a password, using the code below. The problem comes when I, or a user, tries to acccess data with a username and password. I never had a problem until four days ago.

<html>
<head>
<title>get data2p</title>
</head>

<body>
<?php
#connect to MySQL
$dbh=mysql_connect ("localhost", "lhsnycne", "psd")
or die ('I cannot connect to the database because: ' . mysql_error());
mysql_select_db ("lhsnycne_mydata");

#select the specified database
$rs = @mysql_select_db("lhsnycne_mydata", $dbh)
or die("Err😃b");

#create the query specifying the required id
#$sql="select id,fname,lname,avg2 from grades9"

$sql="select studentid,fname,lname,avg2 from grades9" ;

#execute the query
$rs=mysql_query($sql,$dbh);

#start table
$list = "<table border=\"1\" cellpadding=\"2\">";
$list.="<tr><th>ID</th>";
$list.="<th>First Name</th>";
$list.="<th>Last Name</th>";
$list.="<th>Password</th></tr>";

#loop through each row
while( $row = mysql_fetch_array($rs) )
{
$list .= "<tr>";
$list .= "<td>".$row["studentid"]."</td>";
$list .= "<td>".$row["fname"]."</td>";
$list .= "<td>".$row["lname"]."</td>";
$list .= "<td>".$row["avg2"]."</td>";
$list .= "</tr>";
}
$list .= "</table>";

#write out the list
echo($list);

?>

</body>
</html>