[RESOLVED] Help with "implode()"

[grahamtx]

I've got a real estate properties database that I want to search using the following form:

<form name="GWCsearch" method=GET action=searchform.php>
 <select name=beds>
<option value="EFF">EFF</option>
<option value="1">1</option>
<option value="2">2</option>
<option value="3">3</option>
<option value="4">4</option>
<option value="5+">5+</option>
</select>

<input type=text name=price size=8 maxlength=9><br><br>
<input type=submit name="submit" value="SEARCH">

<input type = checkbox name=chkType[] value="APT" CHECKED>Apartment<br>
<input type = checkbox name=chkType[] value="CONDO">Condo<br>
<input type = checkbox name=chkType[] value="HOUSE">House/Duplex

</form>

Now I want to search based on the user's selections by # of bedrooms, price, and type. I've tried to use "implode()" on the chkType[] array, but I get the following error:

Warning: implode(): Bad arguments. in /home/gowestca/public_html/searchform.php on line 117

Here is the php code starting with line 116:

mysql_select_db (gowestca_properties);
$sel_type = implode(', ', "$chkType");
$result = mysql_query("SELECT * 
FROM properties 
WHERE prop_beds = '$beds'
AND prop_price <= '$price'
AND prop_type IN ('$sel_type')
") 				//searches DB for matches
or die(mysql_error()); 		//just in case 

Can anyone see what I'm doing wrong? Thanks.

[thorpe]

$sel_type = implode(', ', $_GET['chkType']);

[grahamtx]

Thorpe,

thanks for the help, but I inserted the code and got the same error message. Can you think of anything else it could be?

[thorpe]

not sure, maybe try this and see what $GET['chkType'] acually holds.

echo "<pre>";
print_r($_GET['chkType']);
echo </pre>";

[grahamtx]

Once I entered your code, I still got the error when I refreshed the page. However, when I run a search, I get:

Array
(
[0] => APT
)

Then the corrrect results, but it still won't display any results for more than one "type" at a time.

[Rodney_H_]

I hope I am not WAY off here... but, could you try something like this? Where you add each value from the array to the sql select statement??

<?php
if(isset($_GET['submit'])){

// loop through submitted values
foreach($_GET as $key=>$value){
	if(!empty($value)){
		$$key = $value;
	}
	else {
		echo '<p>You did not fill out the form completely.<br />';
		echo 'Please go back and try again.</p>';
		exit;
	}
}

// begin query statement
$query = "SELECT *
		FROM properties 
		WHERE prop_beds = '$beds'
		AND prop_price <= '$price'
		AND (";
// loop through array of types:
foreach($chkType as $value){
	$query .= "prop_type = '$value' || ";
}
// remove last set of tubes and add closing parenthesis:
$query = substr($query, 0, strlen($query)-4) . ')';

// select db
mysql_select_db ('gowestca_properties');

// results or error:
$result = mysql_query($query) or die(mysql_error());

// Display results here...

}
?>

(??)

[grahamtx]

Rodney,

I'm just getting started with PHP, so I'd be lying if I said I completely understand the "foreach($_GET as $key=>$value)" part. However, I don't think that's exactly what I'm looking for.

If the user selects the "Apartment" check box only, I want to display only the relevant apartments.
If the user selects "Apartment" and selects "Condo", I want to display the relevant apartments and condos (etc,, etc.)
Currently the only thing wrong with the results (aside from the error statement) is it will not search for more than one type at a time. More than one check box selected returns an empty set.

Here's the entire code. Maybe it will help you help me. Thanks again for the work.

mysql_connect (localhost,xxxxxxxx,xxxxxxxxxxx);
mysql_select_db (gowestca_properties);
$sel_type = implode(', ', $_GET['$chkType']);
$result = mysql_query("SELECT * 
FROM properties 
WHERE prop_beds = '$beds'
AND prop_price <= '$price'
")                                         //search DB for matches
or die(mysql_error()); 		//just in case

if (!isset($_GET['submit'])){                //display if no search has been performed yet
echo '<span class="regText">Please enter search criteria above.<span>';}  //end if

else if($row = mysql_fetch_array($result)) {       //check for hits

//display table headers
echo '<table width="380" border="0" cellspacing="0" cellpadding="0">
  <tr> 
    <td class="regText" height="14"><b>Property</b></td>
    <td class="regText" height="14"><b>Bedrooms</b></td>
    <td class="regText" height="14"><b>Baths</b></td>
    <td class="regText" height="14"><b>Price</b></td>
    <td class="regText" height="14"><b>Type</b></td>
    <td class="regText" height="14"><b>Link</b></td>
  </tr>';
do {              //display each returned row in table
echo '<tr>
		<td class="regText" height="14">'.$row["prop_name"].'</td>
		<td class="regText" height="14">'.$row["prop_beds"].'</td>
		<td class="regText" height="14">'.$row["prop_baths"].'</td>
		<td class="regText" height="14">'.$row["prop_price"].'</td>
		<td class="regText" height="14">'.$row["prop_type"].'</td>';

if ($row["prop_url"]){    //display link if it exists
echo'<td class="regText" height="14"><a href ='.$row["prop_url"].'> PIX </a></td>';
}                                     //end of if statement
else{	                  //display X if no link exists
echo '<td class="regText" height="14"><b>X</b></td>
  </tr>';
   }                      //end of else statement
	}                 //end of do statement
     while($row = mysql_fetch_array($result)); //do above for all returned rows

echo '</table></td>';

  }      //end of else if statement 
else {

//print message if no matching records
echo '<tr>
	<td class="regText" height="14">'.'Sorry no records match your criteria.'.'</td></tr>';
	 }				

[andars]

his statement should work for that. For instance, if they selected condo and apt you would get a query that looks like this:

SELECT *
            FROM properties
            WHERE prop_beds = '$beds'
            AND prop_price <= '$price'
            AND (prop_type = 'APT' || 'COND')

Meaning then that the property type can be an apartment or a condo.

[grahamtx]

Thanks for the input. I tried that code and now I get:

Warning: Invalid argument supplied for foreach() in /home/gowestca/public_html/searchformBeta.php on line 135
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 5

Here's what my code looks like now:

<?php
mysql_connect (localhost,xxxx,xxxxx);


if(isset($_GET['submit'])){

// loop through submitted values
foreach($_GET as $key=>$value){
    if(!empty($value)){
        $$key = $value;
    }
    else {
        echo '<p>Please enter search criteria.</p>';
        exit;
    }
} 
// begin query statement
    $query = "SELECT *
            FROM properties
            WHERE prop_beds = '$beds'
            AND prop_price <= '$price'
            AND (";
    // loop through array of types:
    foreach($chkType as $value){
        $query .= "prop_type = '$value' || ";
    }
    // remove last set of tubes and add closing parenthesis:
    $query = substr($query, 0, strlen($query)-4) . ')';

// select db
mysql_select_db ('gowestca_properties');

// results or error:
$result = mysql_query($query) or die(mysql_error());

// Display results here...
echo '<table width="380" border="0" cellspacing="0" cellpadding="0">
  <tr> 
    <td class="regText" height="14"><b>Property</b></td>
    <td class="regText" height="14"><b>Bedrooms</b></td>
    <td class="regText" height="14"><b>Baths</b></td>
    <td class="regText" height="14"><b>Price</b></td>
    <td class="regText" height="14"><b>Type</b></td>
    <td class="regText" height="14"><b>Link</b></td>
  </tr>';

echo '
  <tr>
    <td class="regText" height="14">'.$row["prop_name"].'</td>
    <td class="regText" height="14">'.$row["prop_beds"].'</td>
    <td class="regText" height="14">'.$row["prop_baths"].'</td>
    <td class="regText" height="14">'.$row["prop_price"].'</td>
    <td class="regText" height="14">'.$row["prop_type"].'</td>';

if ($row["prop_url"])  //display link if it exists
{    

echo'
    <td class="regText" height="14"><a href ='.$row["prop_url"].'> PIX</a></td>';
}else
{	                  //display X if no link exists
echo '<td class="regText" height="14"><b>X</b></td>
  </tr>';
}



echo '</table></td>';

}?>

Thanks everyone.

[Rodney_H_]

What does "$query" look like if you just echo() it out now? Try this to take a peek:

<?php
if(isset($_GET['submit'])){

// loop through submitted values
foreach($_GET as $key=>$value){
    if(!empty($value)){
        $$key = $value;
    }
    else {
        echo '<p>Please enter search criteria.</p>';
        exit;
    }
}

// begin query statement
$query = "SELECT *
        FROM properties
        WHERE prop_beds = '$beds'
        AND prop_price <= '$price'
        AND (";
// loop through array of types:
foreach($chkType as $value){
    $query .= "prop_type = '$value' || ";
}
// remove last set of tubes and add closing parenthesis:
$query = substr($query, 0, strlen($query)-4) . ')';

// let's take a LOOK at it:                  
echo $query;

}
?> 

[grahamtx]

Thanks everyone for the help. I got it to work perfectly! Thanks again.

[Rodney_H_]

grahamtx wrote:

Thanks everyone for the help. I got it to work perfectly! Thanks again.

What did you do??