if statment help

ali_p

I have a drop down select box which contains the option other
beside this i have a tewxt input called "other_option " that can be filled in if other is selected.

On my insert page this is the code i am trying to use to determin what goes into the database


//for the property type
if($_POST['property_type']="Other"){
$property_type = $_POST['otherprop'];
} elseif ($_POST['property_type'] != 'Other'){
$property_type = $_POST['property_type'];
}

Now the Other bit is working fine and the value will go into the database however the value from the select box is not coming through. Can anyone see what i am doing wrong.
?

Thanks

Roger_Ramjet

Dunno about what you are doing 'wrong', but the ELSEIF is redundant. Either property_type is equal to 'other', or it's not, so a simple ELSE is all you need.

Echo out the values of $_POST to see what is being submitted, could be that you've got a typo in there some where.

ali_p

I changed my code to this

if($_POST['property_type'] = "Other"){
$property_type = $_POST['otherprop'];
} else {
$property_type = $_POST['property_type'];
}

echo $_POST['property_type'];
echo $property_type;

And 'Other' is always printing out regardless of what i select.

madwormer2

you need two = signs

($_POST['property_type'] == "Other")

not just one.

Roger_Ramjet

ali_p wrote:
Hi

I changed my code to this
if($_POST['property_type'] = "Other"){
$property_type = $_POST['otherprop'];
} else {
$property_type = $_POST['property_type'];
}

echo $_POST['property_type'];
echo $property_type;
And 'Other' is always printing out regardless of what i select.

So, your form is always submitting $_POST['property_type'] as 'Other'?

Something wrong with your form code then isn't there. 😃

madwormer2

For 1994 posts, you're not very observant.

He's not comparing the strings, merely setting the value.

A second = sign would solve that.

Roger_Ramjet

madwormer2 wrote:
For 1994 posts, you're not very observant.

He's not comparing the strings, merely setting the value.

A second = sign would solve that.

Quite right, I'm always forgetting that. :bemused:
My only excuse is that I'm a VB programmer who dabbles in PHP (that's why I'm here - brushing up on PHP), so on a quick scan it looked OK to me. 😃