Checkbox Value

KrisCons

Hi all,

Think I am missing something simple here...

I have the following sample in my form:

Which when checked are meant to insert the value '-1' into the 3 corresponding fields in my table which are defaulted to the value of '0'.

At the moment, if i check all boxes, it updates no problem and inmserts the value '-1' into the fields accordingly, however, if I choose not to tick one, the query fails to update.

Where am I going wrong?

(My database fields are not mandatory.)

Thanks in advance

rincewind456

More likely to be something with your insert statement than this, do you have error reporting set and if so what error message do you get, if not add this

error_reporting( E_ALL );

at the top of your script.

Rodney_H_

Or, the problem could be a result of handling the form after it has been submitted, and the way you are dealing with the submitted values.

If rincewind456's suggestion hasn't shown you where the error exists, post the relevent code.

KrisCons

Here is my PHP (which works if all checkboxes are ticked):

if (!empty($_POST["name"])) {

   $name = $_POST['name'];
   $addressline1 = $_POST['addressline1'];
   $addressline2 = $_POST['addressline2'];
   $addressline3 = $_POST['addressline3'];
   $addressline4 = $_POST['addressline4'];
   $postcode = $_POST['postcode'];
   $gender = $_POST['gender'];
   $age = $_POST['age'];
   $country = $_POST['country'];
   $product = $_POST['product'];
   $colour = $_POST['colour'];
   $size = $_POST['size'];
   $purchased = $_POST['purchased'];
   $comments = $_POST['comments'];
   $hillwalking = $_POST['hillwalking'];
   $climbing = $_POST['climbing'];
   $mountaineering = $_POST['mountaineering'];
   $trailrunning = $_POST['trailrunning'];
   $roadrunning = $_POST['roadrunning'];
   $mountainbiking = $_POST['mountainbike'];
   $roadbiking = $_POST['roadbike'];
   $adventurerac = $_POST['adventurerac'];
   $others = $_POST['others'];

   $sqlupdatequery = "INSERT INTO tblguarantees (name, addressline1, addressline2, addressline3, addressline4, postcode, gender, 
   					 age, countryid, productid, size, purchased, comments, colour, hillwalking, climbing, mountaineering, trailrunning,
					 roadrunning, mountainbiking, roadbiking, adventureracing, others) 

					 VALUES ('$name', '$addressline1', '$addressline2', '$addressline3', '$addressline4', '$postcode', '$gender',
					 '$age', $country, $product, '$size', '$purchased', '$comments', '$colour', $hillwalking, $climbing, $mountaineering,
					 $trailrunning, $roadrunning, $mountainbiking, $roadbiking, $adventurerac, '$others')"; 
   echo $sqlupdatequery;
   $updateresult = mysql_query($sqlupdatequery);
}

Here is part of my Form which posts to itself:

<form name="register" id="register" method="post" action="register.php">
<table cellpadding="0" cellspacing="">
<tr>
<td class="reglabelcell">Sports Participation</td>
<td class="reginputcell"></td>
</tr>
<tr>
<td class="reglabelcell">Hillwalking</td>
<td class="reginputcell"><input name="hillwalking" type="checkbox" id="hillwalking" value="-1"></td>
</tr>
<tr>
<td class="reglabelcell">Climbing</td>
<td class="reginputcell"><input name="climbing" type="checkbox" id="climbing" value="-1"></td>
</tr>
<tr>
<td class="reglabelcell">Mountaineering</td>
<td class="reginputcell"><input name="mountaineering" type="checkbox" id="mountaineering" value="-1"></td>
</tr>
<tr>
<td class="reglabelcell">Trail Running</td>
<td class="reginputcell"><input name="trailrunning" type="checkbox" id="trailrunning" value="-1"></td>
</tr>
<tr>
<td class="reglabelcell">Road Running</td>
<td class="reginputcell"><input name="roadrunning" type="checkbox" id="roadrunning" value="-1"></td>
</tr>
<tr>
<td class="reglabelcell">Mountain Biking</td>
<td class="reginputcell"><input name="mountainbike" type="checkbox" id="roadrunning" value="-1"></td>
</tr>
<tr>
<td class="reglabelcell">Road Biking</td>
<td class="reginputcell"><input name="roadbike" type="checkbox" id="roadbike" value="-1"></td>
</tr>
<tr>
<td class="reglabelcell">Adventure Racing</td>
<td class="reginputcell"><input name="adventurerac" type="checkbox" id="adventurerac" value="-1"></td>
</tr>
<tr>
<td class="reglabelcell">Others</td>
<td class="reginputcell"><textarea class="othertextarea" id="others" name="others"></textarea></td>
</tr>
</table>

</form>

Many Thanks

Rodney_H_

Please correct me if I am wrong, but I don't see anywhere in the code where you are evaluating if the checkboxes have been set. ... for example:

<?php
// after form submitted:
if(isset($_POST['checkbox1'])){
    $checkbox1 = -1;
}
else {
    $checkbox1 = 0;
}
// etc...
?>

So how or where are you determining that all three of them are checked or not??

PS Helps to put your code in the [ php ] code here [ / php ] bb code tags...

Roger_Ramjet

If you don't click a checkbox, it is not posted with the form. So by omitting a checkbox you omit the corresponding var, This means the the value is missing from your query string, but the column name is present. Query fails through wrong number of values for the column list.

You are probably getting a warning message thrown when the $_POST var is absent, but it is non-critical so your script does not break.

What you need to do id to test if each post var is set

if (isset($_POST['checkbox1'])) {
   $checkbox1 = -1;
} else {
   $checkbox1 = 0;
}

// etc for all checkbox vars

Then you will have a value for each field.

Alternatively, you can test for it and omit the column from the column list when the value is not present - but that is unneccessarily complex in this case. It is something you would do if the possible values where not so clearly defined, or you were doing an update query and only need to update changed fileds.

KrisCons

Ahhhh!!!

Thank you so much. It's been a long day...

Many Thanks
K

ravnen

Same thing, just a little neater 😉

$checkbox1=isset($_POST['checkbox1'])?-1:0;

Roger_Ramjet

But it uses the ternary operator - a pig-in-a-poke if ever there was one.
It has absolutely no benefits in processing efficiency.
It does not look any neater, in fact it looks very ugly and can be very confusing to many people. It does not add to the structure of your code, in fact it detracts from it, makinf the processing paths less clear.
It only save you a few keystrokes, and saving a few keystrokes is not a worthwhile ambition for any professional programmer, not when it is at the expense of clarity and ease of maintenence. That is just showing off, and shows scant regard for whomever may have to maintain your code in the future.