while loop//table row question

mashnote

hi guys & girls

i'm about to put my new site online and i'm still struggling with one problem...

i have a table in my DB called pictures
each picture has it's own row, where there's also an ID, name, photographer, date, place & url

when pulling a set of pictures taken by one photographer at a certain date & place
my results are ok.

but sometimes there are pictures of the same subject at the same place & date, BUT of a different photographer.
at first sight everything is displayed fine, but when i compare my results with the info in my table, i notice there are some pictures missing on my page.
i double checked that all the information (like place,etc..) where the subject is the same matches.

i don't know how stable my code is (not very i guess, hehe).
and i'm not sure if implementing a while loop in a while loop is the kosjer way to do this. i searched the site for other options though...

i hope you understand my problem..
here's the full code.
thanx a lot in advance! this site helped me a lot already, and i hope to contribute answers myself in the future. :bemused:

<?php
$name = $_GET['name'];

if ($name == NULL){
$query = "SELECT * from mash_images_bands GROUP BY name,date ORDER BY input_date DESC LIMIT 0,1";
$result = mysql_query($query) or die (mysql_error());

while($row = mysql_fetch_array($result)) {

$name = $row["name"];
$date = $row["date"];
$place = $row["place"];
$photographer = $row["photographer"];

echo "latest set of pictures : ";
echo "".$name."   |  ";
echo $date;
echo " ";
echo "taken by ".$photographer." at ".$place;
echo " ";

}

$query = "SELECT * from mash_images_bands WHERE name LIKE '$name' AND date='$date' ORDER by input_date DESC ";
$result = mysql_query($query) or die (mysql_error());?>
	 <? while($row = mysql_fetch_array($result)) {?>


	 <a href="javascript:void window.open('viewImage.php?id=<? echo($row["ID"]);?>','image','directories=no,location=no,menubar=no, 
	 personalbar=no,toolbar=no,status=no,scrollbars=yes,width=550,height=600');" class="thumbnail"> 
 <img src="<? echo($row["thumbnail"]);?>" class="thumbnail"/>
 </a>

	 <? }
}

else{

$query = "SELECT * from mash_images_bands WHERE name='$name' GROUP BY photographer,date ORDER BY date DESC";
$result = mysql_query($query) or die (mysql_error());

echo "you have chosen to see pictures of   ".$name."";
echo " ";
echo " ";

while($row = mysql_fetch_array($result)) {

$id = $row["ID"];
$date = $row["date"];
$place = $row["place"];
$photographer = $row["photographer"];
$thumb = $row["thumbnail"];

$query2 = "SELECT * from mash_images_bands WHERE name='$name' AND date='$date' AND photographer='$photographer'";
$result2 = mysql_query($query2) or die (mysql_error());
$row2 = mysql_fetch_array($result2);

echo $date;
echo " ";
echo "taken by ".$photographer." at ".$place;
echo " ";
 while($row2 = mysql_fetch_array($result2)) {?>

 <a href="javascript:void window.open('viewImage.php?id=<? echo($row2["ID"]);?>', 'image', 'directories=no,location=no, menubar=no,personalbar=no,toolbar=no,status=no,scrollbars=yes,width=550,height=600');" class="thumbnail">
<img src="http://www.mashnote.net/<?php echo($row2["thumbnail"]);?>" class="thumbnail"/></a>
<?php

}

echo " ";

}
}

dfr574

I think it's because you are grouping by date, remove the group by date in your query.

GROUP BY photographer,date

GROUP BY photographer

mashnote

nah, i already tried that and other things similar..
but thanx anyway!

still no solution. ..still trying...

mashnote

still having probs...help ?

Roger_Ramjet

A clear explanation of what you are trying to acheive would be a help. It's no good expecting us to understand what you are after by just reading your code - cos your code is wrong which is why you are posting in the first place.

What do you want to display on the page?

One thing I can answer : running multiple queries inside a loop is wrong.

mashnote

Roger Ramjet wrote:
One thing I can answer : running multiple queries inside a loop is wrong.

that's what i thought..and one of the reasons i posted it here....

ok, i'll try to give another clear expl.

what i have in my DB
-a table with pictures (with ID, name, place, date, photographer)

what i want to achieve
-if there is a band with more than one set of pictures,
i want them (the different sets of pictures) displayed below eachother. the pictures grouped by place of event, photographer & date

i partially get what i want with the code posted above, but sometimes one picture of the set is missing, or the whole set of pictures is missing, but the place, date & photographer (= data linked to the pics) of the missing set is being displayed.

mashnote

ok, bumpage

still not resolved...

someone gave me this code, but it doesn't work really..

"<?php
// variable declaration
$name = $_GET['name'];
$counter = 0;
// print title of page
echo ' pictures of   '.$name.'';
echo ' ';

// get images of band
$query = 'SELECT * from mash_images_bands WHERE name='.$name.' GROUP BY photographer,date ORDER BY date DESC';
$result = mysql_query($query) or die (mysql_error());
// loop thru images
while($row = mysql_fetch_array($result)) {

$id = $row["ID"];
$date = $row["date"];
$place = $row["place"];
$photographer = $row["photographer"];
$thumb = $row["thumbnail"];

// print only first time in loop
if ($counter == 0) {
	echo $date; 
	echo "<br />";
	echo "taken by ".$photographer." at ".$place;
	echo "<br />";
}
$counter ++;
echo '<a href="javascript:void window.open(\'viewImage.php?id='.$id.'\', \'image\', \'directories=no,location=no, menubar=no,personalbar=no,toolbar=no,status=no,scrollbars=yes,width=550,height=600\');" class="thumbnail">
		<img src="http://www.mashnote.net/'.$thumb.'" class="thumbnail" /></a>';

see the attached file (jpg) for the result i'm trying to get, but then the upper data should have thumbnails to go with it..like the one below...