[RESOLVED] weird thing happening when uploading csv file

[ejwf]

Can anyone help

I have some code that takes a csv file and uploads the data contents into mysql database.

However the first time you perform the command to run the code I get the 'thank you, your data has been uploaded' message, but checking on the database nothing has been changed / added.
But if you go straight back to the website and perform the operation again - no changes, just hit the upload button - it works fine and updates the database.

I need to get this sorted (if I suggest to my client that the only way for this to work is to do everything twice I will not be popular!)
Has anyone come across this before

I have no idea where to start........

the code is

session_start ();					
$_SESSION['username'] = $username;
require_once ('../mysql_connect.php');		//connect to the database

$uploadDir = '/home/xx/xx/htdocs/xx/xx/upload/';
$uploadFile = $uploadDir . $_FILES['SectionCsvFile']['name'];
print "<pre>";

$filename = $uploadFile;
$fp = fopen($filename,"rb") or die('could not open file!'); 

while (!feof($fp)){ 

$data = fgetcsv($fp,500000); 

$SectionId = addslashes($data[0]); 
$ClientRef = addslashes($data[1]); 
$SectionName = addslashes($data[2]); 

$sql = "REPLACE INTO tblSection (SectionId, ClientRef, SectionName) 
VALUES ('$SectionId', '$ClientRef', '$SectionName')";
$result = mysql_query($sql) 
 or die(mysql_error());


   }
   if (move_uploaded_file($_FILES['SectionCsvFile']['tmp_name'], $uploadFile))
{ echo '<div align="center">
    <p><b><font color="#FF0000" face="Arial, Helvetica, sans-serif" size="4">Thank You, <br> The new Section Data has been added to the database</font></b></p>
</div>';   

}
else
{
    print "Not Possible To Upload Data! Please Try Again";
}
print "</pre>";

[bastien]

You are attempting to load the data from the file before its moved...shouldn't it be the other way around?

First upload, then move, then check to see that the file exists then open the file and read in the data

[ejwf]

thanks Bastien, but I thought I was doing this.........

//create the destination for the file
$uploadDir = '/home/xx/xx/htdocs/xx/xx/upload/'; 
$uploadFile = $uploadDir . $_FILES['SectionCsvFile']['name']; 
print "<pre>"; 

$filename = $uploadFile; 

//open the file
$fp = fopen($filename,"rb") or die('could not open file!'); 

while (!feof($fp)){ 

//get the data
$data = fgetcsv($fp,500000); 

$SectionId = addslashes($data[0]); 
$ClientRef = addslashes($data[1]); 
$SectionName = addslashes($data[2]); 

//replace it into the mysql table
$sql = "REPLACE INTO tblSection (SectionId, ClientRef, SectionName) 
VALUES ('$SectionId', '$ClientRef', '$SectionName')"; 
$result = mysql_query($sql) 
or die(mysql_error()); 


   } 
//if the file move was successful and therefore data was uploaded echo this message
    if (move_uploaded_file($_FILES['SectionCsvFile']['tmp_name'], $uploadFile)) 
{ echo '<div align="center"> 
    <p><b><font color="#FF0000" face="Arial, Helvetica, sans-serif" size="4">Thank You, <br> The new Section Data has been added to the database</font></b></p> 
</div>';    

} 
// if file not moved then show error message
else 
{ 
    print "Not Possible To Upload Data! Please Try Again"; 
} 
print "</pre>"; 

How else would you suggest I arrange this code?

Also why is it working on the second attempt but not the first

any help would be much appreciated..........

regards

[Weedpacket]

$filename = $uploadFile; 

You want

$filename = $_FILES['SectionCsvFile']['tmp_name'];

because until you move it, it's still stored under its temporary name.

It's working on the second attempt because by then the copy you uploaded in the first attempt has been moved to the place where you're trying to read it from.

[ejwf]

thank you - that has sorted it..........