Trouble getting value from a form

Undrium

Allright this problem have been up before, though it's different now. I've a list form with 5 different values. Those are for voting. Problem is that I cannot get the new values once someone has pushed "vote" and put them into the database at the position where they belong. Looking through the code might be easier for you guys then hearing my explanation :

            <?php



$db_name = "XXXXXXXXXX"; 
$table_name = "*"; 
//connect to server 
$connection = @mysql_connect ("localhost", "XXXXXXXX", "XXXXXXXXXX") 
or die(mysql_error()); 



$db = @mysql_select_db($db_name, $connection) or 
die(mysql_error()); 

echo $vote1; 
if (isset($_POST['newvote'])) { 
switch ($_POST['newvote']) { 
case 1: 
$vote1++; 
break; 
case 2: 
$vote1++; 
$vote1++; 
break; 
case 3: 
$vote1++; 
$vote1++; 
$vote1++; 
break; 
case 4: 
$vote1++; 
$vote1++; 
$vote1++; 
$vote1++; 
break; 
case 5: 
$vote1++; 
$vote1++; 
$vote1++; 
$vote1++; 
$vote1++; 
break; 
} 
} 
$sql2 = "UPDATE * SET vote1 = $vote1 WHERE id='id'";




$result3 = @mysql_query($connection, $sql2) 
or die(mysql_error()); 



?>

Thanks if someone could help me. It's been a really annoying problem for me.

Installer

What error messages do you get? What is 'id'? Do you really have the data stored in more than one table? If 'id' is defined, and you're updating one table, then you could probably use a query something like:

$sql2 = "UPDATE my_table SET vote1 = $vote1 WHERE id = $id";

(Note that's "$id", not "&id" as you used in an earlier thread.)

BTW, it looks like you could shorten this:

if (isset($_POST['newvote'])) { 
switch ($_POST['newvote']) { 
case 1: 
$vote1++; 
break; 
case 2: 
$vote1++; 
$vote1++; 
break; 
case 3: 
$vote1++; 
$vote1++; 
$vote1++; 
break; 
case 4: 
$vote1++; 
$vote1++; 
$vote1++; 
$vote1++; 
break; 
case 5: 
$vote1++; 
$vote1++; 
$vote1++; 
$vote1++; 
$vote1++; 
break; 
} 
}

to this:

if (isset($_POST['newvote'])) { 
    $vote1 += $_POST['newvote']
}

bodzan

...that the * here is placed by mistake because the table name should go in there...

$sql2 = "UPDATE * SET vote1 = $vote1 WHERE id='id'";

And also - please ask yourself what is id in this statement or better yet what it should be because all you will get here is WHERE id = 'id' and I highly doubt that that was what was intended to be...

Also, I would recommend to you to modify your code a bit to make it look more readable...

if (isset($_POST['newvote'])) {
switch ($_POST['newvote']) {
case 1:
$vote1++;
break;
case 2:
$vote1 += 2;
break;
case 3:
$vote1 +=3;
break;
case 4:
$vote1 +=4;
break;
case 5:
$vote1 +=5;
break;
}
}

And you might want to ad a starting value to a $vote1 like 0 or something before all of this. Not that it is a mistake of some sort - it's just you will get a NOTICE if you place it on a server where it shows NOTCES...

Undrium

Thanks for the feedback, guys! The help didn't make a difference though and I'm sorry for not being very clear ; id is a number on the row I want updated. Every object has an id and a vote1. The vote1 is a sum of all votes. I just want to get the new value into the variable vote1 in the database but it doesn't work. 🙁 It doesn't change at all.

Also thanks for the shortening, I'm sort of better with C programming, though I got the picture in another thread I couldn't use the += for instance. I'm using Installer's suggestion instead.

I really hope I could solve this problem soon, it's been way too long a dilemma to me.