[RESOLVED] unexpected T_DNUMBER - HUH???

ppowell

Offensive Line:

	    $contents = preg_replace('/([\s\t]*\*+[\s\t]*@[vV][eE][rR][sS][iI][oO][nN][\s\t]+)' . str_replace('/', '\\/', preg_quote($oldversion)) . '([\n\r\s\t]*)/e', '$1' . $newversion . '$2', $contents);

Bluntly put, I simply don't get it. It's bad enough that the RegExp fails, but why would it break and why break in such a way that makes no sense to anyone?

This is all I want to do:

REPLACE

@version 1.0.0

WITH

@version 1.1.0

Inside each non-binary file that contains that exact line pattern!

And that's all.

Thanx
Phil

devinemke

ppowell wrote:
...Inside each non-binary file that contains that exact line pattern!

then you don't need regex at all, just use [man]str_replace[/man]

ppowell

I misspoke. The line isn't exact.

the line can be this

'[\s\t]*[\s\t]@version[\s\t]' . $oldversion . '[\s\t]'

Meaning the number of spaces and/or tabs is completely variant.

Phil

devinemke

ppowell wrote:
I misspoke. The line isn't exact.

the line can be this

'[\s\t]*[\s\t]@version[\s\t]' . $oldversion . '[\s\t]'

Meaning the number of spaces and/or tabs is completely variant.

regardless of the number of spaces/tabs, if all you wish to do is replace "1.0.0" with "1.1.0" then you still do not need regex.

Weedpacket

Well, the error message makes sense to me, but then I'm not anyone.
The /e means that preg_replace() is to take the replacement string and, after interpolating backreferences, interpret the result as PHP code. In this case, the replacement string, after interpolating backreferences, is

         1.1.1

. Which is not valid PHP code because it contains an unexpected double. So why not ditch the /e modifier? It's not doing anything you need. In fact, the whole expression is unnecessarily hairy.

 $contents = preg_replace(
	'/(\s*\*+\s*@version\s+)' . preg_quote($oldversion,'/') . '(\s*)/i',
	'$1' . $newversion . '$2',
	$contents);

ppowell

I couldn't get your version to work because I believe "\s" would not match in some cases where "\t" might:

$contents = preg_replace('/([\s\t]*\*[\s\t]*@version[\s\t]+)(' . str_replace('/', '\\/', preg_quote($oldversion)) . ')([\n\r\s\t]*)/i', '$1 ' . $newversion . '$3', $contents);

I'll have to look up preg_quote a bit more carefully in the future, but thanx

Phil

Weedpacket

In locales where tabs aren't recognised as whitespace, sure.