[RESOLVED] need help filtering in query result with WHERE

[chadman]

Newbie here. I am trying to filter out records in a query using WHERE expressions.

See example below.

if ($league="All") {$leaguebool="1"} else {$leaguebool="League='$league'"};
$query = "SELECT League,HR FROM ranfranbattingsim WHERE ('$leaguebool') ORDER BY $sorder DESC LIMIT $limit";

My desire is to select all records if $league='All' and select only records where LEAGUE=$league if $league is anything other than 'All'. LEAGUE is one of the fields of the database.

I hope that I explained that well enough. I am open to any solutions, and have considered that perhaps I should be using something other than the WHERE statement to filter the records. Any suggestions would be greatly appreciated.

Thanks in advance.

[SargeZT]

First off, you need an == instead of an = in the

if ($league = "All")

.
Secondly, semicolons after the $leaguebool declarations,

{ $leaguebool = "1"; }

And the second one as well.
Lastly, delete the (' and ') around the $leaguebool in the $query. Then it should work fine.

= assigns a value, so you're basically saying in your original script:
If PHP can assign "All" to $league, then do this; which should evaluate to true every time. The == is a comparison.

[chadman]

Sarge, thanks for helping a newbie with his stupid syntax errors. Much appreciated. Works fine.

[SargeZT]

No problem.