This is really strange!!

kuber

i have written a script for admins to edit users on my site, its very simple,
it is meant to bring up the form with values filled in and when submit is pressed it changed the mysql row to the changes.

I get no errors and it seems to work fine but when i have a look at the database nothing has changed! The problem cant be my database because i can add users and view them using other scrpts i have written, also i can view and change info via mysqladmin. the link to the code is below...

http://puresourcedesigns.com/includes/admin/useredit.phps

This is really important to me, i would really apprichiate any help. Also i wish i could spell apprichiate :rolleyes:

nemonoman

here's your problem, I think:

header("Location:http://puresourcedesigns.com/index.php?page=admin&section=userview&viewfname={$_GET['editfname']}&viewlname={$_GET['editlname']}");
        if (mysql_query($sql)) {
        header("Location:http://puresourcedesigns.com/index.php?page=admin&section=userview&viewfname={$_GET['editfname']}&viewlname={$_GET['editlname']}");

The first "header" command executes, sending the browser to the new page. The (mysql_query( is therefore never executed --

kuber

nope included in my header file is ob_start(); headers are ok, thanks anyway

Weedpacket

nemonoman wrote:
The first "header" command executes, sending the browser to the new page. The (mysql_query( is therefore never executed --

Not true; scripts continue to run even after calls to the header function. Headers aren't sent until either output is started or (if there isn't any output) the script ends; which is why header('Location:') calls usually have exit; after them.

But it is a bit silly to have a redirect header and then send a second redirect header if a query succeeds. That first one probably isn't supposed to be there, since it causes a redirect whether the query succeeded or not.

This business of using $POST['editlname'] and $GET['editlname'] (there are others like that): that's a good way of getting messed up. The Location headers you're using suggest to me that you're sending a lot of stuff out to the client in hopes that it'll be sent back again (and that it will be uncorrupted). Have you considered using a [man]session[/man] to pass information from page to page instead?