newsletter/email submission form issue

thejustin

hello -

i'm trying to create a simple email submission form. obviously i'm a newb so i've been trying to scour the web for some samples. i think i'm quite close in getting this to work but would like a little assistance because i'm kind of stumped at this point.

here's the submission form:

http://www.prgallery.com/new/mail.php

here's the code i'm referencing:

?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Sendemail Script</title>
</head>
<body>

<?php
$email = $POST["email"];
$headers = "From: " . $POST["email"];
$name = $_POST["name"];
$subject = "[Newsletter Subscription Request] New User";
$time = date("l d F Y @ H:i");
$to = "justin@myemail.com";
$message2 = "\nName: " . $name . "\nEmail: " . $email . "\nAddress: " . $address . "\nCity/State: " . $citystate . "\nZip: " . $zip ;

if ($email != ") {
if (mail($to, $message2)) {
header("Location:/new/thankyou.php");
}

else {
print("The server encountered an unexpected condition which prevented it from fulfilling the request.");
}
}

else {
print("Please fill out all fields.");
}
?>

here's the error i receive when hitting submit:

Parse error: parse error, unexpected T_STRING in /home/prg/public_html/new/mailscript.php on line 15

let me know if you want to see the form for the mail.php page.

thank you very much.
justin

bpat1434

Hmm.... do you see something wrong with:

if ($email != ") {
if (mail($to, $message2)) {
header("Location:/new/thankyou.php");
}

? I do.... 🙂

The error says that it's running into a string, and it's not expecting it. Either it's a concatenation error, or you've just misplaced a quote. Seems you misplaced a quote here.... This is where syntax highlighting editors really help!!

~Brett

bpat1434

Okay, so here's your form:

<form action="/new/mailscript.php" method="post" name="email">
<!-- Excess HTML removed -->
<tr>
<td>First Name<label>:</label></td>
<td><input type="text" name="name" size="24" tabindex="1"></td>
</tr>

<tr>
<td><label>Last Name:</label></td>
<td><input type="text" name="email0" size="24" tabindex="2"></td>
</tr>

<tr>
<td><label>Company/Studio Name:<br>
(optional)</label></td>
<td><input type="text" name="email" size="24" tabindex="2"></td>
</tr>

<tr>
<td>Email Address<label>:</label></td>
<td><input type="text" name="address" size="24" tabindex="3"></td>
</tr>

<tr>
<td>Confirm Email Address:</td>
<td><input type="text" name="citystate" size="24" tabindex="4"></td>
</tr>

</td>
<td>
<div align="left">
<input type="submit" name="submitButtonName" value="Submit" tabindex="6"></div>
</td>
</tr>
<!-- Excess HTML removed -->
</form>

So, to get all your $_POST values into variables, you can do it this way:

<?php

$name = $_POST['name'].' '.$_POST['email0'];
$email = $_POST['email'];
$address = $_POST['address']."\n".$_POST['citystate'].' '.$_POST['zipcode'];
/* $address then holds a value that looks like:
1234 Some St.
Canton VA 12345
*/
$subject = "[Newsletter Subscription Request] New User";
$time = date("l d F Y @ H:i");
$to = "justin@myemail.com";

// Set the "FROM: " header
$headers = "FROM: ".$name." <".$email.">"; // Formatted as: Justin <justin@myemail.com>
                                         // Proper RFC 2882 formatting
$message = "Name: ".$name."\n".
                     "Email: ".$email."\n".
                     "Address: ".$address."\n";

if($email != "")
{
    if(mail($to, $subject, $message2, $headers))
    {
        header("Location: /new/thankyou.php");
    }
    else
    {
        echo "The server encountered an unexpected condition which prevented it from fulfilling the request.";
    }
}
else
{
    echo "Please fill out all fields.";
}
?>

Hope that helps you... 🙂

~Brett