Required fields

[Smeep]

So, It's come to the stage where I need to make it so that users must enter certain fields. There is probably a more effecient way of doing this, but I can't even get this working anyway.
What is a better (and a working) way of doing this?

if (isset(($_POST['username']))) & (isset((md5($_POST['password']))) & (isset(md5($_POST['passconfirm'])))
& (isset($_POST['email'])) & (isset($_POST['emailconfirm'])) {
			if $password == $passconfirm && $email == $emailconfirm {
//action

}
			else  {
			echo 'your confirm fields do not match';

		}
		else	{
		echo 'You have not entered all the required info';

		}

[Rackie]

Javascript this will produce a nice small alert window when you submit
: put this in your header

<script language="javascript">
<!-- form controle -->

function test() {

if(document[0].elements[0].value == '' ||
document[0].elements[1].value == ''
 ) {
alert('\nU haven't fill in all the fields.');
return false;
}
}


</script>

and this as start of form

<form action="send.php" onSubmit="return test()">

[bpat1434]

<?php
/**
 * This variable will hold all the empty value names.
 * That way, we can give the user some feedback about
 * just what fields they are missing, and such.
**/
$empty = array(); // Default it to an empty array

if ( isset($_POST['username']) || empty($_POST['username']) )
{
	// If the username isn't set, or is empty:
	// add it to our $empty array
	array_push($empty, 'username');
}
if ( isset(md5($_POST['password'])) || empty($_POST['password']) )
{
	// If the password isn't set, or is empty:
	// add it to our $empty array
	array_push($empty, 'password');
}
if ( isset(md5($_POST['passconfirm'])) || empty($_POST['passconfirm']) )
{
	// If the confirmation password isn't set, or is empty:
	// add it to our $empty array
	array_push($empty, 'passconfirm');
}
if ( isset($_POST['email']) || empty($_POST['email']) )
{
	// If the email isn't set, or is empty:
	// add it to our $empty array
	array_push($empty, 'email');
}
if ( isset($_POST['emailconfirm']) || empty($_POST['emailconfirm']) )
{
	// If the confirmation email isn't set, or is empty
	// add it to our $empty array
	array_push($empty, 'emailconfirm');
}

if(count($empty)==0)
{
	// We don't have any errors, so continue with whatever
	if($_POST['password'] == $_POST['passwordconfirm'])
	{
		if($_POST['email'] == $_POST['emailconfirm'])
		{
			// Action
		}
		else
		{
			echo 'Email addresses didn\'t match.  Sorry.';
		}
	}
	else
	{
		echo 'Passwords didn\'t match.  Stopping processing.';
	}
}
else
{
	echo 'Please fill in all the required info.  You did not fill in the following:<br>';
	foreach($empty as $field)
	{
		echo $field.'<br>';
	}
}

?>

That will work. But from looking at your code, you need to use "&&" not "&". That is probably what is holding you up.

~Brett

[Smeep]

I'll have a quick peak.

And originally, I did use &&, but that caused some crazy error that I couldn't understand 😉 so I tried just &

Thanks for your help today man 😃 Now lets see this code.

EDIT:

getting a parse error

  array_push($empty, 'username');
}
if ( isset(md5($_POST['password'])) || empty($_POST['password']) ) //ON THIS LINE

Now normally a parse error is a missing { or } but I don't see that problem here.

[bpat1434]

well, what's the error...? What is it getting and what is it expecting?

Without that info, my guess would be that we're referencing a non-existant variable. And here's what your code probably should be:

<?php
/**
* This variable will hold all the empty value names.
* That way, we can give the user some feedback about
* just what fields they are missing, and such.
**/
$empty = array(); // Default it to an empty array

if ( !isset($_POST['username']) || empty($_POST['username']) )
{
    // If the username isn't set, or is empty:
    // add it to our $empty array
    array_push($empty, 'username');
}
if ( !isset($_POST['password']) || empty($_POST['password']) )
{
    // If the password isn't set, or is empty:
    // add it to our $empty array
    array_push($empty, 'password');
}
if ( !isset($_POST['passconfirm']) || empty($_POST['passconfirm']) )
{
    // If the confirmation password isn't set, or is empty:
    // add it to our $empty array
    array_push($empty, 'passconfirm');
}
if ( !isset($_POST['email']) || empty($_POST['email']) )
{
    // If the email isn't set, or is empty:
    // add it to our $empty array
    array_push($empty, 'email');
}
if ( !isset($_POST['emailconfirm']) || empty($_POST['emailconfirm']) )
{
    // If the confirmation email isn't set, or is empty
    // add it to our $empty array
    array_push($empty, 'emailconfirm');
}

if( count($empty)==0 )
{
    // We don't have any errors, so continue with whatever
    if(md5($_POST['password']) == md5($_POST['passwordconfirm']))
    {
        if($_POST['email'] == $_POST['emailconfirm'])
        {
            // Action
        }
        else
        {
            echo 'Email addresses didn\'t match.  Sorry.';
        }
    }
    else
    {
        echo 'Passwords didn\'t match.  Stopping processing.';
    }
}
else
{
    echo 'Please fill in all the required info.  You did not fill in the following:<br>';
    foreach($empty as $field)
    {
        echo $field.'<br>';
    }
}

?>

I took care of the most likely pesky problem....

~Brett

[Smeep]

based on your advice, I will check my code, then if need be, I'll reference to yours 🙂

Seem's to be sorted 😃 I had to reference to yours, but I think I have it working now 😃 I won't mark the thread resolved just yet, because I probably have many more questions on the same thing :S

EDIT:

hehe, toldya I'd be back 😉 Right, the new problem is simple, it's just not registering the customer/webfriend now. No error. Just "doing nothing". Maybe I can add in some echo's to see what is wrong, but I'm echoing the variable wf or cx (er, webfriend and customer) and they are just fine...

/**
* This variable will hold all the empty value names.
* That way, we can give the user some feedback about
* just what fields they are missing, and such.
**/
$empty = array(); // Default it to an empty array

if ( !isset($_POST['username']) || empty($_POST['username']) )
{
    // If the username isn't set, or is empty:
    // add it to our $empty array
    array_push($empty, 'username');
}
if ( !isset($_POST['password']) || empty($_POST['password']) )
{
    // If the password isn't set, or is empty:
    // add it to our $empty array
    array_push($empty, 'password');
}
if ( !isset($_POST['passconfirm']) || empty($_POST['passconfirm']) )
{
    // If the confirmation password isn't set, or is empty:
    // add it to our $empty array
    array_push($empty, 'passconfirm');
}
if ( !isset($_POST['email']) || empty($_POST['email']) )
{
    // If the email isn't set, or is empty:
    // add it to our $empty array
    array_push($empty, 'email');
}
if ( !isset($_POST['emailconfirm']) || empty($_POST['emailconfirm']) )
{
    // If the confirmation email isn't set, or is empty
    // add it to our $empty array
    array_push($empty, 'emailconfirm');
}

if(count($empty)==0)
{
    // We don't have any errors, so continue with whatever
    if($_POST['password'] == $_POST['passconfirm'])
    {
        if($_POST['email'] == $_POST['emailconfirm'])
        {
           if ( $usertype == "webfriends" ) {	
echo 'wf '.$usertype . '<br />';	
$sql = "INSERT INTO webfriends (username, firstname, surname, password, alone, altwo, althree, county, country, daytime, evening, mobile, dob, email, postcode) VALUES ('$username', '$firstname', '$surname', '$password', '$alone', '$altwo', '$althree', '$county', '$country', '$daytime', '$evening', '$mobile', '$dob', '$email', '$postcode')";
   if (@mysql_query($sql)) {
     echo 'registration successful!';

}
}		


else if ( $usertype == "customer" ) {
 echo 'cx '.$usertype . '<br />';
$sql = "INSERT INTO customers (username, firstname, surname, password, alone, altwo, althree, county, country, daytime, evening, mobile, dob, email, postcode) VALUES ('$username', '$firstname', '$surname', '$password', '$alone', '$altwo', '$althree', '$county', '$country', '$daytime', '$evening', '$mobile', '$dob', '$email', '$postcode')";
   if (@mysql_query($sql)) {
     echo 'registration successful!';

	 }
	 }


else if ( $usertype == "both" ) {
 echo 'both'.$usertype . '<br />';
$sql = "INSERT INTO webfriends (username, firstname, surname, password, alone, altwo, althree, county, country, daytime, evening, mobile, dob, email, postcode) VALUES ('$username', '$firstname', '$surname', '$password', '$alone', '$altwo', '$althree', '$county', '$country', '$daytime', '$evening', '$mobile', '$dob', '$email', '$postcode')";
   if (@mysql_query($sql)) {
     echo 'registration successful!';

	 }
$sql = "INSERT INTO customers(username, firstname, surname, password, alone, altwo, althree, county, country, daytime, evening, mobile, dob, email, postcode) VALUES ('$username', '$firstname', '$surname', '$password', '$alone', '$altwo', '$althree', '$county', '$country', '$alone', '$daytime', '$evening', '$mobile', '$dob', '$email')";
   if (@mysql_query($sql)) {
     echo 'registration successful!';

	 }


   } else {
     echo '<p>Error registering: ' .
        mysql_error() . '</p>';
   }






// Query All entries
 $result = @mysql_query('SELECT * FROM webfriends');
 if (!$result) {
   echo ('<p>Error performing query: ' .
       mysql_error() . '</p>');
 }
        }
        else
        {
            echo 'Email addresses didn\'t match.  Sorry.';
        }
    }
    else
    {
        echo 'Passwords didn\'t match.  Stopping processing.';
    }
}
else
{
    echo 'Please fill in all the required info.  You did not fill in the following:<br>';
    foreach($empty as $field)
    {
        echo $field.'<br>';
    }
}









?>

[bpat1434]

Okay... and do you have register_globals on? Or are you populating the "$username, $email, $password, $usertype" and other such variables elsewhere?

You may also try removing the "@" from in front of the mySQL query....

~Brett