How can i access another functions variable value into this function

reddymade

I have the variable $password which gets the random passwords value, now i want to access $password 's value into my save function. I am trying to see the print statement but it gets null value.

if i put the print statement under generate password function it does show the value of random password.

Please help.


function save_page1(){
		global $smarty, $dbconn, $config, $config_admin, $page, $lang, $user;

	//Now i am calling the Random function inside
	generatePassword();

	print "Random Pwd is: $password"; // this is Random Password 

}


function generatePassword ($length = 8){
  global $password;
  // start with a blank password
  $password = "";

  // define possible characters
  $possible = "0123456789bcdfghjkmnpqrstvwxyz"; 

  // set up a counter
  $i = 0; 

  // add random characters to $password until $length is reached
  while ($i < $length) { 

// pick a random character from the possible ones
$char = substr($possible, mt_rand(0, strlen($possible)-1), 1);

// we don't want this character if it's already in the password
if (!strstr($password, $char)) { 
  $password .= $char;
  $i++;
}

  }
  // done!
  //return $password;
}

Thank you very much your help.

alexwirtz

You're almost there with this - the thing to do is pass the return value of the function to a variable accessible outside the function. Function variables, otherwise called local variables, are never accessible from outside the function. Conversely, external (global) variables are not external from within a function unless declared as global within each function that needs to access them.

To cover all bases, then, add the following line at the start of your script -

$password='';

and within both of your two functions (you've already done this for generatePassword() - add

global $password;

I notice, though, you commented out the

//return $password

line of

generatePassword().

Any particular reason for not using

$password=generatePassword()

? That way, what you wanted would have been generated in the local scope without the need for referencing the global.

Cheers, A