[RESOLVED] Simple Query Question

[frombumps2babes]

This is probably so basic and obvious but I can't get it all.

I'm trying to create a page that is called by article.php?id=x.

I need to pull a row from a database where the id value is equal to x.

This is the code I have:

<?php $dbh=mysql_connect ("localhost", "xxxxx", "xxxxxx") or die ('I cannot connect to the database because: ' . mysql_error());
$selectdb = mysql_select_db("medw1974_articles",$dbh);

$query = mysql_query("SELECT * FROM articles WHERE id=$_GET[id]");
while($row = mysql_fetch_array($query))
{
echo ".$row[title].";
}
?>

However this returns the following error:

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/medw1974/public_html/article.php on line 27

Any help would be much appreciated

Michael

[jeepin81]

Try This:
<?php $dbh=mysql_connect ("localhost", "xxxxx", "xxxxxx") or die ('I cannot connect to the database because: ' . mysql_error());
$selectdb = mysql_select_db("medw1974_articles",$dbh);

$query = mysql_query("SELECT * FROM articles WHERE id=$_GET[id]");
while($row = mysql_fetch_array($query, $dbh))
{
echo ".$row[title].";
}
?>

[frombumps2babes]

Thanks jeepin81

That clears up the error message but something still appears to be wrong with my output. It is only outputing .. (2 dots)

Any ideas?

[jeepin81]

See if this works:

$query = mysql_query("SELECT * FROM articles WHERE id=$_GET[id]");
while($row = mysql_fetch_array($query, $dbh))
{
$title = $row['title'];
}

echo "$title";
?>

I am not sure where you are getting your title variable from - so you might want to try this as well:

$query = mysql_query("SELECT * FROM articles WHERE id=$_GET[id]");
while($row = mysql_fetch_array($query, $dbh))
{
$title = $row['id'];
}

echo "$title";
?>

[frombumps2babes]

that is giving me no output whatsoever. As you can tell I'm a complete noob at this - I've double checked the data is present, so not sure whats up really.

[frombumps2babes]

The DB table has the following fields:

id, title, text, keywords

what I'm trying to do is have a link to an article passing the id no using article.php?id=1.

This should retreive the title, text and keywords for the entry with id 1.

[rincewind456]

Echo out your $_GET['id'] before it is sent to the query to see if there is a value getting to it.

The 2 dots are coming from your echo statement

echo ".$row[title].";

what are they they for?

[frombumps2babes]

echoing the $get[id] before the query outputs 1 as expected.

The dots in the ".$row[title]."; are because I based the query on one in the FAQ on this board and that is how they were on there.

[rincewind456]

OK then try this it should throw up an error if for some reason it can't succesfully query the DB

<?php $dbh=mysql_connect ("localhost", "xxxxx", "xxxxxx") or die ('I cannot connect to the database because: ' . mysql_error()); 
$selectdb = mysql_select_db("medw1974_articles",$dbh); 

$query = mysql_query("SELECT * FROM articles WHERE id=$_GET[id]"); 
if (!$query)  die( 'Error selecting data from database: ' . mysql_error() );
while($row = mysql_fetch_array($query)) 
{ 
echo $row[title]; 
} 
?>

The dots are concaternators and don't need to be there in this case.

[frombumps2babes]

Thanks

Using that code has displayed the title successfully.

[rincewind456]

Good you might want to think about changing the query to this to prevent injection attacks.

$query = mysql_query("SELECT * FROM articles WHERE id=".mysql_real_escape_string($_GET[id])); 

[frombumps2babes]

Thanks for that. I really have got a lot to learn but I guess everyone has to start somewhere.

[Installer]

If you had error level set to all and error display on, as you should for development, you'd be seeing notices due to those missing quotes.

Try it this way:

$query = sprintf("SELECT * FROM test_01 WHERE id='%s'", mysql_real_escape_string($_GET['id']));
$result = mysql_query($query)
    or die('Error selecting data from database: ' . mysql_error()); 
while ($row = mysql_fetch_assoc($result)) {
    echo $row['id'] . '<br />';
}