[RESOLVED] Cheking Form Fields & confirm Password

StevenJ

what am I doing wrong?

I have a form where the admin can add a client username and password so that a client can log in and view the work.

Now the framework all worked ok, I could add a client and password, no problem, but now - I need to "bolt it down". By that I mean - I must "Check - does that client already exist?", "Are The passwords entered the same?" (there are two password fields, one password, and one confirm password.......

code here:


if ( || ($client_exist) ) {
  	// client name exists STOP the creation of same name.
	// re display the page.
  } else { 
        // insert new record
  }

now that worked. If the client existed - I re-displayed the form

but when I add

if ( ($_POST['password'] == $_POST['re_password'] ) || ($client_exist) ) {
  	// client name exists STOP the creation of same name.
	// re display the page.
  } else { 
        // insert new record
  }

I am checking to see if the two password fields are the same....or if client exists.....the problem is with the password bits. If I enter two passwords that are different and a new client - it still inserts the new record!..........

note: if the client already exists, then it does not enter the new record...

help! (please)

bpat1434

Well, let's take time and think about your logic:

IF the passwords are the same OR the user exists, show the form.
Otherwise, insert the record....

With that logic, I can type to passwords that match, on a client name that does exist, and it would show the form. I could use an existing client name, and non-matching passwords, and the form would show.

You're trying to check to see if the user exists, then if the user doesn't exist, if the passwords match. If the passwords match, insert, otherwise show the form. If the user exists show the form, otherwise, move on with verification....

I think this might be a little more up your alley:

if(!$client_exists)
{
  // Client doesn't exist
  if($_POST['password'] == $_POST['confirmpassword'])
  {
    // Passwords match, insert the record
  }
  else
  {
    // Passwords don't match, show the form
  }
}
else
{
  // User exists, show form
}

~Brett

StevenJ

ha.........how'd I miss that?! as you pointed out - there was a fundamental error in my logic! thanks for that

just done

if(!$client_exists)
{
  // Client doesn't exist
  if($_POST['password'] == $_POST['confirmpassword'])
  {
    // Passwords match, insert the record
  }
  else
  {
    // Passwords don't match, show the form
  }
}

like you suggested - works a treat. thanks.

bpat1434

No problem. Glad to hear you got it.

~Brett