Inserting into MySQL

Minor_Threat

For some reason im having trouble inserting into a database. Here is the code:

<?PHP
include ('db_connect.php');

$igname = $_POST['igname'];
$igtag = $_POST['igtag'];
$fomun = $_POST['fomun'];
$prof = $_POST['prof'];
$dept = $_POST['dept'];
$rank = $_POST['rank'];
$submit = $_POST['submit'];
if (!$_POST['igname'] | !$_POST['igtag'] | !$_POST['fomun'] | !$_POST['submit']) {
		die('You did not fill in a required field.');
	}ELSE{
		echo "Hello $igname";
		insunuser();
		}

Function insunuser(){
$pw = rand();
$insert = "INSERT INTO unusers ( `username` , `password` , `fomname` , `fomtag` , `profession` , `department` , `rank` ) 
			VALUES (
			'".$_POST['igname']."',
			' $pw ',
			'".$_POST['fomun']."', 
			'".$_POST['igtag']."', 
			'".$_POST['prof']."', 
			'".$_POST['dept']."', 
			'".$_POST['rank']."',
			)";
mysql_query($insert);
}



?>

laserlight

State what is the problem that you have. Providing the version of PHP and MySQL used may also be useful.

parse-error

Hey,

Took a look at your code. Just noticed a couple problems. You also had taken some steps that where not necessary. I just tweaked up your code a bit. It should send back some information telling you if it worked or not. If it doesnt work, it will spit out the mysql_error(); for you. This usually gives you a good idea of whats happening.

<?PHP
// MAKE CONNECTION
include ('db_connect.php');

// CHECK FIELDS
if ($_POST['igname'] && $_POST['igtag'] && $_POST['fomun'] && $_POST['submit']) {
	echo "Hello $igname<br />";
	echo insunuser($_POST);
}else{
	echo "You did not fill in a required field."  

}

// INSERT INTO TABLE
function insunuser($postArr){
	$pw = rand();
	$insert = "INSERT INTO unusers ( 
				username , password , fomname , fomtag , profession , department , rank )VALUES (
	         '$postArr[igname]',
	         '$pw',
	         '$postArr[fomun]',
	         '$postArr[igtag]',
	         '$postArr[prof]',
	         '$postArr[dept]',
	         '$postArr[rank]',
	         )";

$result = @mysql_query($insert);

// RETURN THE RESULT OF QUERY
if ($result) {
	return "Insert Complete";
}else{
	return "There was an error: ".mysql_error();
}
}
?>

Good luck 😉

Minor_Threat

parse-error wrote:
Hey,

Took a look at your code. Just noticed a couple problems. You also had taken some steps that where not necessary. I just tweaked up your code a bit. It should send back some information telling you if it worked or not. If it doesnt work, it will spit out the mysql_error(); for you. This usually gives you a good idea of whats happening.
<?PHP
// MAKE CONNECTION
include ('db_connect.php');

// CHECK FIELDS
if ($_POST['igname'] && $_POST['igtag'] && $_POST['fomun'] && $_POST['submit']) {
	echo "Hello $igname<br />";
	echo insunuser($_POST);
}else{
	echo "You did not fill in a required field."  

}

// INSERT INTO TABLE
function insunuser($postArr){
	$pw = rand();
	$insert = "INSERT INTO unusers ( 
				username , password , fomname , fomtag , profession , department , rank )VALUES (
	         '$postArr[igname]',
	         '$pw',
	         '$postArr[fomun]',
	         '$postArr[igtag]',
	         '$postArr[prof]',
	         '$postArr[dept]',
	         '$postArr[rank]',
	         )";

$result = @mysql_query($insert);

// RETURN THE RESULT OF QUERY
if ($result) {
	return "Insert Complete";
}else{
	return "There was an error: ".mysql_error();
}
}
?> 
Good luck 😉

Thanks =D

That solves the problem I had but am now getting an SQL syntax error.

I know i should be able to find this, but i cant. Been some time since i have used PHP.

laserlight wrote:
State what is the problem that you have. Providing the version of PHP and MySQL used may also be useful.

PHP version 5.0.5
MySQL version 4.1.13-standard

laserlight

Your SQL statement looks okay... but of course you might want to check that the table and column names specified are correct.

Minor_Threat

laserlight wrote:
Your SQL statement looks okay... but of course you might want to check that the table and column names specified are correct.

Field Type

username varchar(20)
password varchar(50)
fomname varchar(20)
fomtag char(3)
profession tinyint(1)
department tinyint(1)
rank tinyint(1)

laserlight

oops. sorry, your SQL statement is incorrect. The parse error is due to parse-error's typo error 😛

Look at the line with '$postArr[rank]'
There is an extra comma at the end that should not be there.

Minor_Threat

laserlight wrote:
oops. sorry, your SQL statement is incorrect. The parse error is due to parse-error's typo error 😛

Look at the line with '$postArr[rank]'
There is an extra comma at the end that should not be there.

Thanks a ton both of you!
Works perfectly now

Minor_Threat

One more problem =(

People cant register in IE. It says all of the feilds werent filled.

laserlight

Post your updated code. Since you specified MSIE, does it mean that people can register using say, Mozilla Firefox or Opera?

Minor_Threat

laserlight wrote:
Post your updated code. Since you specified MSIE, does it mean that people can register using say, Mozilla Firefox or Opera?

Firefox and IE are the only two that i have tested with, Firefox works fine

<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<title>CMG - Register</title>
</head>

<body><p><center><img src=images/cmg.jpg width="281" height="215"></center></p>
<form action=register2.php method="POST">
  <table width="313" height="224" border='1' align=center cellpadding='0' cellspacing='0'>
    <tr id='cat'>
    <tr>
      <td bgcolor=#FFCC33 >In-Game Name<font face='verdana, arial, helvetica' size='2' align='center'>&nbsp; </font></td>
      <td bgcolor=#FFCC33 ><font face='verdana, arial, helvetica' size='2' >
        <input type ='text' class='bginput' name='igname' >
      </font></td>
    </tr>
    <tr>
      <td bgcolor=#FFCC33 >In-Game Tag<font face='verdana, arial, helvetica' size='2' align='center'>&nbsp; </font></td>
      <td bgcolor=#FFCC33 ><font face='verdana, arial, helvetica' size='2' >
        <input type ='text' class='bginput' name='igtag' maxlength=3>
      </font></td>
    </tr>
    <tr>
      <td bgcolor='#FFCC33' > FoM Forum Username <font face='verdana, arial, helvetica' size='2' align='center'>&nbsp; </font></td>
      <td bgcolor='#FFCC33' ><font face='verdana, arial, helvetica' size='1' >
        <input type ='text' class='bginput' name='fomun' >
      </font></td>
    </tr>
    <tr>
      <td bgcolor='#FFCC33' ><font face='verdana, arial, helvetica' size='2' align='center'>Proffesion</font></td>
      <td bgcolor='#FFCC33' ><font face='verdana, arial, helvetica' size='1' >
        <select name="prof">
          <option value="1">Trader</option>
          <option value="2">Combatant</option>
          <option value="3">Medic</option>
          <option value="4">Commander</option>

    </select>
  </font></td>
</tr>
<tr>
  <td bgcolor='#FFCC33' >Department</td>
  <td bgcolor='#FFCC33' ><font face='verdana, arial, helvetica' size='1' >
    <select name="dept">
	<option value="0">None</option>
      <option value="1">Economic</option>
      <option value="2">Military</option>
      <option value="3">Political</option>
    </select>
  </font></td>
</tr>
<tr>
  <td bgcolor='#FFCC33' ><font face='verdana, arial, helvetica' size='2' align='center'>Rank</font></td>
  <td bgcolor='#FFCC33' ><font face='verdana, arial, helvetica' size='1' >
    <select name="rank">
      <option value="1">1 - Colonist</option>
      <option value="2">2 - Miner</option>
      <option value="3">3 - Trader</option>
      <option value="4">4 - Supervisor</option>
      <option value="5">5 - Magistrate</option>
      <option value="6">6 - Secretary</option>
      <option value="7">7 - Director</option>
    </select>
  </font></td>
</tr>
<tr>
  <td bgcolor=#FFCC33 colspan='2' align='center'><font face='verdana, arial, helvetica' size='2' align='center'>&nbsp;
    </font>
  <p>We <font size="2" face="verdana, arial, helvetica" align="center">will have to confirm your registration, once we do, we will send you a mail IG with your username(which will be the same as your FoM forum username) and temporary password.</font></p>
  </td>
</tr>
  </table>
  <center><input type=image src="images/register_button.gif" value=submit name=submit></center>
</form>

</body>
</html>

Register2.php

<?PHP
// MAKE CONNECTION
include ('db_connect.php');

// CHECK FIELDS
if ($_POST['igname'] && $_POST['igtag'] && $_POST['fomun'] && $_POST['submit']) {
    echo "Hello $igname<br />";
    echo insunuser($_POST);
}else{
    echo "You did not fill in a required field.";  

}

// INSERT INTO TABLE
function insunuser($postArr){
    $pw = rand();
    $insert = "INSERT INTO unusers (
                `username` , `password` , `fomname` , `fomtag` , `profession` , `department` , `rank` )VALUES (
             '$postArr[igname]',
             '$pw',
             '$postArr[fomun]',
             '$postArr[igtag]',
             '$postArr[prof]',
             '$postArr[dept]',
             '$postArr[rank]'
             )";

$result = @mysql_query($insert);

// RETURN THE RESULT OF QUERY
if ($result) {
    return "Your registration has been submited. We will review your registration and contact you in-game.";
}else{
    return "There was an error: ".mysql_error();
}
}
?>

LazyJones

change this to

Minor_Threat

LazyJones wrote:
<center><input type=image src="images/register_button.gif" value=submit name=submit></center>

change this to

<center><input type=image src="images/register_button.gif" value="submit" name="submit"></center>

Tried that, still get the same result :bemused:

LazyJones

maybe the problem is type='image' :/
works fine with type='submit'

Minor_Threat

if ($_POST['igname'] && $_POST['igtag'] && $_POST['fomun']) {
    echo "Hello $igname<br />";
    echo insunuser($_POST);
}else{
    echo "You did not fill in a required field.";  

}

I got rid of the submit check

echo " $_POST[igname] $_POST[igtag] $_POST[fomun]";

And then I added this to check to see if they were going through and they were...

parse-error

Just a quick thing,

Sorry about the typo, hehe.

And for the other problem. Are you sure the form is submitting properly? Maybe that 'image input' does not work in both browsers. If you wanted to use an image for submission you could do this.

<a href="javascript:document.form_name_here.submit();">
<img src="images/yourimg.gif" alt="" />
</a>

To check if the form was submit, you could have an:

<input type="hidden" name="submit" value="set" />

When you submit the form, it would look like this.

if(isset($_POST['submit'])) {
   echo "Form has been submitted";
}else{
   echo "Form was NOT submitted";
}

Hope fully there is no typo in this one 😛

Minor_Threat

parse-error wrote:
Just a quick thing,

Sorry about the typo, hehe.

And for the other problem. Are you sure the form is submitting properly? Maybe that 'image input' does not work in both browsers. If you wanted to use an image for submission you could do this.
<a href="javascript:document.form_name_here.submit();">
<img src="images/yourimg.gif" alt="" />
</a>
To check if the form was submit, you could have an:
<input type="hidden" name="submit" value="set" />
When you submit the form, it would look like this.
if(isset($_POST['submit'])) {
   echo "Form has been submitted";
}else{
   echo "Form was NOT submitted";
}
Hope fully there is no typo in this one 😛

Well I assume it is submiting properly because the POSTs are coming through... but maybe not

<?PHP
// MAKE CONNECTION
include ('db_connect.php');

// CHECK FIELDS
if ($_POST['igname'] && $_POST['igtag'] && $_POST['fomun']) {
    echo "Hello $igname<br />";
    echo insunuser($_POST);
}else{
    echo "You did not fill in a required field.";  

}
echo " $_POST[igname] $_POST[igtag] $_POST[fomun]";
// INSERT INTO TABLE
function insunuser($postArr){
    $pw = rand();
    $insert = "INSERT INTO unusers (
                `username` , `password` , `fomname` , `fomtag` , `profession` , `department` , `rank` )VALUES (
             '$postArr[igname]',
             '$pw',
             '$postArr[fomun]',
             '$postArr[igtag]',
             '$postArr[prof]',
             '$postArr[dept]',
             '$postArr[rank]'
             )";

$result = @mysql_query($insert);

// RETURN THE RESULT OF QUERY
if ($result) {
    return "Your registration has been submited. We will review your registration and contact you in-game.";
}else{
    return "There was an error: ".mysql_error();
}
}
?>

This is coming up with

You did not fill in a required field. Test Tes Tests

The posts are coming through:

test tes tests

and the script is checking to make sure these three came through

if ($_POST['igname'] && $_POST['igtag'] && $_POST['fomun']) {
    echo "Hello $igname<br />";
    echo insunuser($_POST);
}else{
    echo "You did not fill in a required field.";  

}

laserlight

Try using [man]isset/man or [man]empty/man.

Minor_Threat

laserlight wrote:
Try using [man]isset/man or [man]empty/man.

All of them are set...

dunno what could be the problem

rincewind456

All that code works fine for me in Opera, Firefox and IE, inserts into a database no problem' even gives me the random password.

The only thing it throws up is an undefined variable $igname, which isn't surprising as it appears from nowhere on line 6, I think it's meant to be $_POST['igname'].